luya\console\commands\ModuleController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	131
Duplicated Lines	21.37 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	humanizeName()	0	4	1
A	renderReadme()	10	10	1
A	renderAdmin()	9	9	1
A	renderFrontend()	9	9	1
B	actionCreate()	0	53	6

<?php

namespace luya\console\commands;

use Yii;
use yii\helpers\Console;
use luya\helpers\FileHelper;
use yii\helpers\Inflector;

/**
 * Command to create a new LUYA Module.
 *
 * @author Basil Suter <basil@nadar.io>
 * @since 1.0.0
 */
class ModuleController extends \luya\console\Command
{
    /**
     * @inheritdoc
     */
    public $defaultAction = 'create';
    
    /**
     * Humanize the class name
     *
     * @return string The humanized name.
     */
    public function humanizeName($name)
    {
        return $name = Inflector::humanize(Inflector::camel2words($name));

$name is not used, you could remove the assignment.

    }
    
    /**
     * Render the readme template.
     *
     * @param array $folders
     * @param string $name
     * @param string $ns
     * @return string
     */
    public function renderReadme($folders, $name, $ns)

This method seems to be duplicated in your project.

    {
        return $this->view->render('@luya/console/commands/views/module/readme.php', [
            'folders' => $folders,
            'name' => $name,
            'humanName' => $this->humanizeName($name),
            'ns' => $ns,
            'luyaText' => $this->getGeneratorText('module/create'),
        ]);
    }
    
    /**
     * Render the admin template.
     *
     * @param array $folders
     * @param string $name
     * @param string $ns
     * @return string
     */
    public function renderAdmin($folders, $name, $ns)

This method seems to be duplicated in your project.

    {
        return $this->view->render('@luya/console/commands/views/module/adminmodule.php', [
            'folders' => $folders,
            'name' => $this->humanizeName($name),
            'ns' => $ns,
            'luyaText' => $this->getGeneratorText('module/create'),
        ]);
    }
    
    /**
     * Render the frontend template.
     *
     * @param array $folders
     * @param string $name
     * @param string $ns
     * @return string
     */
    public function renderFrontend($folders, $name, $ns)

This method seems to be duplicated in your project.

    {
        return $this->view->render('@luya/console/commands/views/module/frontendmodule.php', [
            'folders' => $folders,
            'name' => $this->humanizeName($name),
            'ns' => $ns,
            'luyaText' => $this->getGeneratorText('module/create'),
        ]);
    }
    
    /**
     * Create a new frontend/admin module.
     *
     * @return number
     */
    public function actionCreate()
    {
        Console::clearScreenBeforeCursor();
        
        $moduleName = $this->prompt("Enter the name of the module you like to generate:");

        $newName = preg_replace("/[^a-z]/", "", strtolower($moduleName));
        
        if ($newName !== $moduleName) {
            if (!$this->confirm("We have changed the name to '{$newName}'. Do you want to proceed with this name?")) {

The expression $this->confirm("We have changed the name to '{$newName}'. Do you want to proceed with this name?") of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

                return $this->outputError('Abort by user.');
            } else {
                $moduleName = $newName;
            }
        }
        
        $appModulesFolder = Yii::$app->basePath . DIRECTORY_SEPARATOR . 'modules';
        $moduleFolder = $appModulesFolder . DIRECTORY_SEPARATOR . $moduleName;
        
        if (file_exists($moduleFolder)) {
            return $this->outputError("The folder " . $moduleFolder . " exists already.");
        }
        
        $folders = [
            'basePath' => $moduleFolder,
            'adminPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'admin',
            'adminAwsPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'admin' . DIRECTORY_SEPARATOR . 'aws',
            'adminMigrationPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'admin' . DIRECTORY_SEPARATOR . 'migrations',
            'frontendPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend',
            'frontendBlocksPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend' . DIRECTORY_SEPARATOR . 'blocks',
            'frontendControllersPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend' . DIRECTORY_SEPARATOR . 'controllers',
            'frontendViewsPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'frontend' . DIRECTORY_SEPARATOR . 'views',
            'modelsPath' => $moduleFolder . DIRECTORY_SEPARATOR . 'models',
        ];

        $ns = 'app\\modules\\'.$moduleName;
        
        foreach ($folders as $folder) {
            FileHelper::createDirectory($folder);
        }
        
        $contents = [
            $moduleFolder. DIRECTORY_SEPARATOR . 'README.md' => $this->renderReadme($folders, $moduleName, $ns),
            $moduleFolder. DIRECTORY_SEPARATOR . 'admin/Module.php' => $this->renderAdmin($folders, $moduleName, $ns),
            $moduleFolder. DIRECTORY_SEPARATOR . 'frontend/Module.php' => $this->renderFrontend($folders, $moduleName, $ns),
        ];
        
        foreach ($contents as $fileName => $content) {
            FileHelper::writeFile($fileName, $content);
        }
        
        return $this->outputSuccess("Module files has been created successfully. Check the README file to understand how to add the module to your config.");
    }
}