Luminark\Url\UrlServiceProvider

Complexity

Total Complexity

5

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	5
Bugs	0	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	boot()	0	6	1
A	register()	0	14	4

<?php

namespace Luminark\Url;

use Illuminate\Support\ServiceProvider;
use Luminark\Url\Interfaces\HasUrlInterface;

class UrlServiceProvider extends ServiceProvider
{
    public function boot()
    {
        $this->publishes([
            __DIR__ . '/../database/migrations/' => database_path('migrations')
        ], 'migrations');
    }
    
    public function register()
    {
        $this->app['events']->listen('eloquent.saved*', function ($model) {
            if ($model instanceof HasUrlInterface) {
                $model->saveUri();
            }
        });
        
        $this->app['events']->listen('eloquent.deleted*', function ($model) {
            if ($model instanceof HasUrlInterface && $model->url) {

Accessing url on the interface Luminark\Url\Interfaces\HasUrlInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

                $model->url->delete();

Accessing url on the interface Luminark\Url\Interfaces\HasUrlInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            }
        });
    }
}