RedisSortedSetForm::submit() - Code Metrics - Inspection of "Added sorted set management" - lulco/uniman - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Michal

created 2018-08-20 13:42 UTC

RedisSortedSetForm::submit() A

↳ Parent: RedisSortedSetForm

Complexity

Conditions	5
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	0
cts	12
cp	0
rs	9.3888
c	0
b	0
f	0
cc	5
nc	6
nop	2
crap	30

<?php

namespace UniMan\Drivers\Redis\Forms;

use Nette\Application\UI\Form;
use Nette\Utils\ArrayHash;
use RedisProxy\RedisProxy;
use UniMan\Core\Forms\TableForm\TableFormInterface;

class RedisSortedSetForm implements TableFormInterface
{
    private $connection;

    private $key;

    public function __construct(RedisProxy $connection, string $key = null)
    {
        $this->connection = $connection;
        $this->key = $key;
    }

    public function addFieldsToForm(Form $form)
    {
        $form->addText('key', 'redis.sorted_set_form.key.label')
            ->setRequired('redis.sorted_set_form.key.required');

        $form->addTextArea('members', 'redis.sorted_set_form.members.label')
            ->setOption('description', 'redis.sorted_set_form.members.description')
            ->setRequired('redis.sorted_set_form.members.required');

        if ($this->key) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $members = [];
            foreach ($this->connection->zrange($this->key, 0, -1, true) as $member => $score) {
                $members[] = $member . ':' . $score;
            }
            $form->setDefaults([
                'key' => $this->key,
                'members' => implode(',', $members),
            ]);
        }
    }

    public function submit(Form $form, ArrayHash $values)
    {
        if ($this->key && $this->key !== $values->key) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->connection->rename($this->key, $values->key);
        }

        $members = [];
        foreach (array_map('trim', explode(',', $values->members)) as $item) {
            $member = $item;
            $score = 0;
            if (strpos($item, ':')) {
                list($member, $score) = explode(':', $item, 2);
            }
            $members[trim($member)] = floatval(trim($score));
        }
        $this->connection->zadd($values->key, $members);
    }
}


1			<?php
2
3			namespace UniMan\Drivers\Redis\Forms;
4
5			use Nette\Application\UI\Form;
6			use Nette\Utils\ArrayHash;
7			use RedisProxy\RedisProxy;
8			use UniMan\Core\Forms\TableForm\TableFormInterface;
9
10			class RedisSortedSetForm implements TableFormInterface
11			{
12			private $connection;
13
14			private $key;
15
16			public function __construct(RedisProxy $connection, string $key = null)
17			{
18			$this->connection = $connection;
19			$this->key = $key;
20			}
21
22			public function addFieldsToForm(Form $form)
23			{
24			$form->addText('key', 'redis.sorted_set_form.key.label')
25			->setRequired('redis.sorted_set_form.key.required');
26
27			$form->addTextArea('members', 'redis.sorted_set_form.members.label')
28			->setOption('description', 'redis.sorted_set_form.members.description')
29			->setRequired('redis.sorted_set_form.members.required');
30
31			if ($this->key) {
			0 ignored issues – show Bug Best Practice introduced 2018-08-20 13:29 UTC by Report Bug Copy Issue Report The expression `$this->key` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
32			$members = [];
33			foreach ($this->connection->zrange($this->key, 0, -1, true) as $member => $score) {
34			$members[] = $member . ':' . $score;
35			}
36			$form->setDefaults([
37			'key' => $this->key,
38			'members' => implode(',', $members),
39			]);
40			}
41			}
42
43			public function submit(Form $form, ArrayHash $values)
44			{
45			if ($this->key && $this->key !== $values->key) {
			0 ignored issues – show Bug Best Practice introduced 2018-08-20 13:29 UTC by Report Bug Copy Issue Report The expression `$this->key` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
46			$this->connection->rename($this->key, $values->key);
47			}
48
49			$members = [];
50			foreach (array_map('trim', explode(',', $values->members)) as $item) {
51			$member = $item;
52			$score = 0;
53			if (strpos($item, ':')) {
54			list($member, $score) = explode(':', $item, 2);
55			}
56			$members[trim($member)] = floatval(trim($score));
57			}
58			$this->connection->zadd($values->key, $members);
59			}
60			}
61

lulco / uniman

Pull Request — master (#30)

RedisSortedSetForm::submit() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like