Completed
Pull Request — master (#21)
by Michal
02:30
created

RouterFactory::createRouter()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 6
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 6
ccs 0
cts 4
cp 0
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 4
nc 1
nop 0
crap 2
1
<?php
2
3
namespace UniMan\Router;
4
5
use Nette\Application\IRouter;
6
use Nette\Application\Routers\RouteList;
7
use Nette\Application\Routers\SimpleRouter;
8
9
class RouterFactory
10
{
11
    /**
12
     * @return IRouter
13
     */
14
    public static function createRouter()
15
    {
16
        $router = new RouteList();
17
        $router[] = new SimpleRouter('Default:default');
0 ignored issues
show
Documentation introduced by
'Default:default' is of type string, but the function expects a array.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
18
        return $router;
19
    }
20
}
21