Completed
Pull Request — master (#21)
by Michal
02:30
created

RedisEditSetForm::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 5
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 5
ccs 0
cts 4
cp 0
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 3
nc 1
nop 2
crap 2
1
<?php
2
3
namespace UniMan\Drivers\Redis\Forms;
4
5
use UniMan\Core\Forms\TableForm\TableFormInterface;
6
use Nette\Application\UI\Form;
7
use Nette\Utils\ArrayHash;
8
use RedisProxy\RedisProxy;
9
10
class RedisEditSetForm implements TableFormInterface
11
{
12
    private $connection;
13
14
    private $key;
15
16
    public function __construct(RedisProxy $connection, $key)
17
    {
18
        $this->connection = $connection;
19
        $this->key = $key;
20
    }
21
22
    public function addFieldsToForm(Form $form)
23
    {
24
        $form->addText('key', 'redis.set_form.key.label')
25
            ->setRequired('redis.set_form.key.required');
0 ignored issues
show
Documentation introduced by
'redis.set_form.key.required' is of type string, but the function expects a boolean.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
26
        $form->addText('members', 'redis.set_form.members.label')
27
            ->setRequired('redis.set_form.members.required')
0 ignored issues
show
Documentation introduced by
'redis.set_form.members.required' is of type string, but the function expects a boolean.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
28
            ->setOption('description', 'redis.set_form.members.description');
29
        if ($this->key) {
30
            $form->setDefaults([
31
                'key' => $this->key,
32
                'members' => implode(',', $this->connection->smembers($this->key)),
33
            ]);
34
        }
35
    }
36
37
    public function submit(Form $form, ArrayHash $values)
38
    {
39
        $key = $values['key'];
40
        $actualMembers = $this->connection->smembers($this->key);
41
        $members = array_map('trim', explode(',', $values['members']));
42
43
        $membersToRemove = array_diff($actualMembers, $members);
44
        $membersToAdd = array_diff($members, $actualMembers);
45
        call_user_func_array([$this->connection, 'srem'], array_merge([$this->key], $membersToRemove));
46
        call_user_func_array([$this->connection, 'sadd'], array_merge([$this->key], $membersToAdd));
47
48
        if ($this->key != $key) {
49
            $this->connection->rename($this->key, $key);
50
        }
51
    }
52
}
53