Completed
Pull Request — master (#21)
by Michal
02:30
created

MemcacheKeyForm::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 5
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 5
ccs 0
cts 4
cp 0
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 3
nc 1
nop 2
crap 2
1
<?php
2
3
namespace UniMan\Drivers\Memcache\Forms;
4
5
use UniMan\Core\Forms\TableForm\TableFormInterface;
6
use Memcache;
7
use Nette\Application\UI\Form;
8
use Nette\Utils\ArrayHash;
9
10
class MemcacheKeyForm implements TableFormInterface
11
{
12
    private $connection;
13
14
    private $key;
15
16
    public function __construct(Memcache $connection, $key = null)
17
    {
18
        $this->connection = $connection;
19
        $this->key = $key;
20
    }
21
22
    public function addFieldsToForm(Form $form)
23
    {
24
        $form->addText('key', 'memcache.key_form.key.label')
25
            ->setRequired('memcache.key_form.key.required');
0 ignored issues
show
Documentation introduced by
'memcache.key_form.key.required' is of type string, but the function expects a boolean.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
26
        $form->addText('value', 'memcache.key_form.value.label')
27
            ->setRequired('memcache.key_form.value.required');
0 ignored issues
show
Documentation introduced by
'memcache.key_form.value.required' is of type string, but the function expects a boolean.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
28
        $form->addCheckbox('compressed', 'memcache.key_form.compressed.label');
29
        $form->addText('expiration', 'memcache.key_form.expiration.label')
30
            ->addCondition(Form::FILLED)
31
            ->addRule(Form::INTEGER, 'memcache.key_form.expiration.rule_integer');
32
33
        if ($this->key) {
34
            $flags = false;
35
            $form->setDefaults([
36
                'key' => $this->key,
37
                'value' => $this->connection->get($this->key, $flags),
38
                'compressed' => $flags == MEMCACHE_COMPRESSED,
39
            ]);
40
        }
41
    }
42
43
    public function submit(Form $form, ArrayHash $values)
44
    {
45
        if ($this->key) {
46
            $this->connection->delete($this->key);
47
        }
48
        $this->connection->set($values['key'], $values['value'], $values['compressed'] ? MEMCACHE_COMPRESSED : 0, $values['expiration'] ? intval($values['expiration']) : null);
49
    }
50
}
51