RabbitMQMessageForm::submit() - Code Metrics - Inspection of "Rename adminerng to uniman in all namespaces, sett..." - lulco/uniman - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6d1120...3e38c4 )

by Michal

created 2017-03-01 18:15 UTC

RabbitMQMessageForm::submit() A

↳ Parent: RabbitMQMessageForm

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	8
cp	0
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	2
crap	2

<?php

namespace UniMan\Drivers\RabbitMQ\Forms;

use UniMan\Core\Forms\ItemForm\ItemFormInterface;
use Nette\Application\UI\Form;
use Nette\Utils\ArrayHash;
use PhpAmqpLib\Connection\AMQPStreamConnection;
use PhpAmqpLib\Message\AMQPMessage;

class RabbitMQMessageForm implements ItemFormInterface
{
    private $connection;

    private $queue;

    public function __construct(AMQPStreamConnection $connection, $queue)
    {
        $this->connection = $connection;
        $this->queue = $queue;
    }

    public function addFieldsToForm(Form $form)
    {
        $form->addText('message', 'rabbitmq.message_form.message.label')
            ->setRequired('rabbitmq.message_form.message.required');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function submit(Form $form, ArrayHash $values)
    {
        $channel = $this->connection->channel();
        $channel->queue_declare($this->queue, false, false, false, false);
        $messsage = new AMQPMessage($values['message']);
        $channel->basic_publish($messsage, '', $this->queue);
        $channel->close();
        $this->connection->close();
    }
}


1			<?php
2
3			namespace UniMan\Drivers\RabbitMQ\Forms;
4
5			use UniMan\Core\Forms\ItemForm\ItemFormInterface;
6			use Nette\Application\UI\Form;
7			use Nette\Utils\ArrayHash;
8			use PhpAmqpLib\Connection\AMQPStreamConnection;
9			use PhpAmqpLib\Message\AMQPMessage;
10
11			class RabbitMQMessageForm implements ItemFormInterface
12			{
13			private $connection;
14
15			private $queue;
16
17			public function __construct(AMQPStreamConnection $connection, $queue)
18			{
19			$this->connection = $connection;
20			$this->queue = $queue;
21			}
22
23			public function addFieldsToForm(Form $form)
24			{
25			$form->addText('message', 'rabbitmq.message_form.message.label')
26			->setRequired('rabbitmq.message_form.message.required');
			0 ignored issues – show Documentation introduced 2016-12-19 15:38 UTC by Report Bug Copy Issue Report `'rabbitmq.message_form.message.required'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			}
28
29			public function submit(Form $form, ArrayHash $values)
30			{
31			$channel = $this->connection->channel();
32			$channel->queue_declare($this->queue, false, false, false, false);
33			$messsage = new AMQPMessage($values['message']);
34			$channel->basic_publish($messsage, '', $this->queue);
35			$channel->close();
36			$this->connection->close();
37			}
38			}
39

lulco / uniman

Push — master ( 6d1120...3e38c4 )

RabbitMQMessageForm::submit() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like