RedisSetDataManager::items() - Code Metrics - Inspection of "Splitted RedisDataManager (#26)" - lulco/uniman - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 85ddb2...d5b935 )

by Michal

created 2018-08-14 20:28 UTC

RedisSetDataManager::items() B

↳ Parent: RedisSetDataManager

Complexity

Conditions	8
Paths	6

Size

Total Lines

Duplication

Lines	26
Ratio	76.47 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

Metric	Value
dl	26
loc	34
ccs	0
cts	22
cp	0
rs	8.1315
c	0
b	0
f	0
cc	8
nc	6
nop	4
crap	72

<?php

namespace UniMan\Drivers\Redis\DataManager;

use RedisProxy\RedisProxy;
use UniMan\Core\Utils\Filter;

class RedisSetDataManager
{
    private $connection;

    public function __construct(RedisProxy $connection)
    {
        $this->connection = $connection;
    }

    public function itemsCount(string $table, array $filter): int
    {
        if (!$filter) {

            return $this->connection->scard($table);
        }
        $iterator = '';
        $totalItems = 0;
        do {
            $res = $this->connection->sscan($table, $iterator, null, 1000);
            if (!$res) {
                return $totalItems;
            }
            foreach ($res as $member) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $item = [
                    'member' => $member,
                    'length' => strlen($member),
                ];
                if (Filter::apply($item, $filter)) {
                    $totalItems++;
                }
            }
        } while ($iterator !== 0);
        return $totalItems;
    }

    public function items(string $table, int $page, int $onPage, array $filter = []): array
    {
        $skipped = 0;
        $offset = ($page - 1) * $onPage;
        $items = [];
        $iterator = '';
        do {

            $pattern = null;
            $res = $this->connection->sscan($table, $iterator, $pattern, $onPage * 10);
            if (!$res) {
                return $items;
            }
            foreach ($res as $member) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $item = [
                    'member' => $member,
                    'length' => strlen($member),
                ];
                if (!Filter::apply($item, $filter)) {
                    continue;
                }

                if ($skipped < $offset) {
                    $skipped++;
                    continue;
                }

                $items[$member] = $item;
                if (count($items) === $onPage) {
                    break;
                }
            }
        } while ($iterator !== 0 && count($items) < $onPage);
        return $items;
    }
}


1		<?php
2
3		namespace UniMan\Drivers\Redis\DataManager;
4
5		use RedisProxy\RedisProxy;
6		use UniMan\Core\Utils\Filter;
7
8		class RedisSetDataManager
9		{
10		private $connection;
11
12		public function __construct(RedisProxy $connection)
13		{
14		$this->connection = $connection;
15		}
16
17		public function itemsCount(string $table, array $filter): int
18		{
19		if (!$filter) {
		0 ignored issues – show Bug Best Practice introduced 2018-08-14 20:39 UTC by Report Bug Copy Issue Report The expression `$filter` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
20		return $this->connection->scard($table);
21		}
22		$iterator = '';
23		$totalItems = 0;
24		do {
25		$res = $this->connection->sscan($table, $iterator, null, 1000);
26		if (!$res) {
27		return $totalItems;
28		}
29	View Code Duplication	foreach ($res as $member) {
		0 ignored issues – show Bug introduced 2018-08-14 20:39 UTC by Report Bug Copy Issue Report The expression `$res` of type `array\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history... Duplication introduced 2018-08-14 20:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		$item = [
31		'member' => $member,
32		'length' => strlen($member),
33		];
34		if (Filter::apply($item, $filter)) {
35		$totalItems++;
36		}
37		}
38		} while ($iterator !== 0);
39		return $totalItems;
40		}
41
42		public function items(string $table, int $page, int $onPage, array $filter = []): array
43		{
44		$skipped = 0;
45		$offset = ($page - 1) * $onPage;
46		$items = [];
47		$iterator = '';
48	View Code Duplication	do {
		0 ignored issues – show Duplication introduced 2018-08-14 20:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		$pattern = null;
50		$res = $this->connection->sscan($table, $iterator, $pattern, $onPage * 10);
51		if (!$res) {
52		return $items;
53		}
54		foreach ($res as $member) {
		0 ignored issues – show Bug introduced 2017-03-03 06:52 UTC by Report Bug Copy Issue Report The expression `$res` of type `array\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
55		$item = [
56		'member' => $member,
57		'length' => strlen($member),
58		];
59		if (!Filter::apply($item, $filter)) {
60		continue;
61		}
62
63		if ($skipped < $offset) {
64		$skipped++;
65		continue;
66		}
67
68		$items[$member] = $item;
69		if (count($items) === $onPage) {
70		break;
71		}
72		}
73		} while ($iterator !== 0 && count($items) < $onPage);
74		return $items;
75		}
76		}
77

lulco / uniman

Push — master ( 85ddb2...d5b935 )

RedisSetDataManager::items() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like