RedisHashDataManager::items() - Code Metrics - Inspection of "Splitted RedisDataManager (#26)" - lulco/uniman - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 85ddb2...d5b935 )

by Michal

created 2018-08-14 20:28 UTC

RedisHashDataManager::items() C

↳ Parent: RedisHashDataManager

Complexity

Conditions	12
Paths	15

Size

Total Lines

Duplication

Lines	26
Ratio	49.06 %

Code Coverage

Tests	0
CRAP Score	156

Importance

Changes

Metric	Value
dl	26
loc	53
ccs	0
cts	35
cp	0
rs	6.9666
c	0
b	0
f	0
cc	12
nc	15
nop	4
crap	156

How to fix Long Method Complexity

<?php

namespace UniMan\Drivers\Redis\DataManager;

use RedisProxy\RedisProxy;
use UniMan\Core\Utils\Filter;

class RedisHashDataManager
{
    private $connection;

    public function __construct(RedisProxy $connection)
    {
        $this->connection = $connection;
    }

    public function itemsCount(string $table, array $filter): int
    {
        if (!$filter) {

            return $this->connection->hlen($table);
        }

        $totalItems = 0;
        foreach ($filter as $filterParts) {
            if (isset($filterParts['key'][Filter::OPERATOR_EQUAL])) {
                $res = $this->connection->hget($table, $filterParts['key'][Filter::OPERATOR_EQUAL]);
                if ($res) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                    $item = [
                        'key' => $filterParts['key'][Filter::OPERATOR_EQUAL],
                        'length' => strlen($res),
                        'value' => $res,
                    ];
                    if (Filter::apply($item, $filter)) {
                        $totalItems++;
                    }
                }
                return $totalItems;
            }
        }
        $iterator = '';
        do {
            $pattern = null;
            $res = $this->connection->hscan($table, $iterator, $pattern, 1000);
            $res = $res ?: [];
            foreach ($res as $key => $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $item = [
                    'key' => $key,
                    'length' => strlen($value),
                    'value' => $value,
                ];
                if (Filter::apply($item, $filter)) {
                    $totalItems++;
                }
            }
        } while ($iterator !== 0);
        return $totalItems;
    }

    public function items(string $table, int $page, int $onPage, array $filter = []): array
    {
        $items = [];
        foreach ($filter as $filterParts) {
            if (!isset($filterParts['key'][Filter::OPERATOR_EQUAL])) {
                continue;
            }
            $res = $this->connection->hget($table, $filterParts['key'][Filter::OPERATOR_EQUAL]);
            if (!$res) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                return $items;
            }
            $item = [
                'key' => $filterParts['key'][Filter::OPERATOR_EQUAL],
                'length' => strlen($res),
                'value' => $res,
            ];
            if (Filter::apply($item, $filter)) {
                $items[$item['key']] = $item;
            }
            return $items;
        }

        $skipped = 0;
        $offset = ($page - 1) * $onPage;
        $iterator = '';
        do {

            $pattern = null;
            $res = $this->connection->hscan($table, $iterator, $pattern, $onPage * 10);
            if (!$res) {
                return $items;
            }
            foreach ($res as $key => $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $item = [
                    'key' => $key,
                    'length' => strlen($value),
                    'value' => $value,
                ];
                if (!Filter::apply($item, $filter)) {
                    continue;
                }
                if ($skipped < $offset) {
                    $skipped++;
                    continue;
                }

                $items[$key] = $item;
                if (count($items) === $onPage) {
                    break;
                }
            }
        } while ($iterator !== 0 && count($items) < $onPage);
        return $items;
    }
}


1		<?php
2
3		namespace UniMan\Drivers\Redis\DataManager;
4
5		use RedisProxy\RedisProxy;
6		use UniMan\Core\Utils\Filter;
7
8		class RedisHashDataManager
9		{
10		private $connection;
11
12		public function __construct(RedisProxy $connection)
13		{
14		$this->connection = $connection;
15		}
16
17		public function itemsCount(string $table, array $filter): int
18		{
19		if (!$filter) {
		0 ignored issues – show Bug Best Practice introduced 2018-08-14 20:39 UTC by Report Bug Copy Issue Report The expression `$filter` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
20		return $this->connection->hlen($table);
21		}
22
23		$totalItems = 0;
24		foreach ($filter as $filterParts) {
25		if (isset($filterParts['key'][Filter::OPERATOR_EQUAL])) {
26		$res = $this->connection->hget($table, $filterParts['key'][Filter::OPERATOR_EQUAL]);
27		if ($res) {
		0 ignored issues – show Bug Best Practice introduced 2017-03-03 06:52 UTC by Report Bug Copy Issue Report The expression `$res` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
28		$item = [
29		'key' => $filterParts['key'][Filter::OPERATOR_EQUAL],
30		'length' => strlen($res),
31		'value' => $res,
32		];
33		if (Filter::apply($item, $filter)) {
34		$totalItems++;
35		}
36		}
37		return $totalItems;
38		}
39		}
40		$iterator = '';
41		do {
42		$pattern = null;
43		$res = $this->connection->hscan($table, $iterator, $pattern, 1000);
44		$res = $res ?: [];
45	View Code Duplication	foreach ($res as $key => $value) {
		0 ignored issues – show Bug introduced 2017-03-03 06:52 UTC by Report Bug Copy Issue Report The expression `$res` of type `array\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history... Duplication introduced 2016-12-19 15:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		$item = [
47		'key' => $key,
48		'length' => strlen($value),
49		'value' => $value,
50		];
51		if (Filter::apply($item, $filter)) {
52		$totalItems++;
53		}
54		}
55		} while ($iterator !== 0);
56		return $totalItems;
57		}
58
59		public function items(string $table, int $page, int $onPage, array $filter = []): array
60		{
61		$items = [];
62		foreach ($filter as $filterParts) {
63		if (!isset($filterParts['key'][Filter::OPERATOR_EQUAL])) {
64		continue;
65		}
66		$res = $this->connection->hget($table, $filterParts['key'][Filter::OPERATOR_EQUAL]);
67		if (!$res) {
		0 ignored issues – show Bug Best Practice introduced 2018-08-14 20:39 UTC by Report Bug Copy Issue Report The expression `$res` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
68		return $items;
69		}
70		$item = [
71		'key' => $filterParts['key'][Filter::OPERATOR_EQUAL],
72		'length' => strlen($res),
73		'value' => $res,
74		];
75		if (Filter::apply($item, $filter)) {
76		$items[$item['key']] = $item;
77		}
78		return $items;
79		}
80
81		$skipped = 0;
82		$offset = ($page - 1) * $onPage;
83		$iterator = '';
84	View Code Duplication	do {
		0 ignored issues – show Duplication introduced 2018-08-14 20:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		$pattern = null;
86		$res = $this->connection->hscan($table, $iterator, $pattern, $onPage * 10);
87		if (!$res) {
88		return $items;
89		}
90		foreach ($res as $key => $value) {
		0 ignored issues – show Bug introduced 2017-01-19 17:13 UTC by Report Bug Copy Issue Report The expression `$res` of type `array\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
91		$item = [
92		'key' => $key,
93		'length' => strlen($value),
94		'value' => $value,
95		];
96		if (!Filter::apply($item, $filter)) {
97		continue;
98		}
99		if ($skipped < $offset) {
100		$skipped++;
101		continue;
102		}
103
104		$items[$key] = $item;
105		if (count($items) === $onPage) {
106		break;
107		}
108		}
109		} while ($iterator !== 0 && count($items) < $onPage);
110		return $items;
111		}
112		}
113

lulco / uniman

Push — master ( 85ddb2...d5b935 )

RedisHashDataManager::items() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like