UniMan\Drivers\Redis\Forms\RedisListForm

Complexity

Total Complexity

5

Size/Duplication

Total Lines	39
Duplicated Lines	41.03 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	addFieldsToForm()	16	16	2
A	submit()	0	9	2

<?php

namespace UniMan\Drivers\Redis\Forms;

use Nette\Application\UI\Form;
use Nette\Utils\ArrayHash;
use RedisProxy\RedisProxy;
use UniMan\Core\Forms\TableForm\TableFormInterface;

class RedisListForm implements TableFormInterface
{
    private $connection;

    private $key;

    public function __construct(RedisProxy $connection, string $key = null)
    {
        $this->connection = $connection;
        $this->key = $key;
    }

    public function addFieldsToForm(Form $form)

This method seems to be duplicated in your project.

    {
        $form->addText('key', 'redis.list_form.key.label')
            ->setRequired('redis.list_form.key.required');

        $form->addText('elements', 'redis.list_form.elements.label')
            ->setRequired('redis.list_form.elements.required')
            ->setOption('description', 'redis.list_form.elements.description');

        if ($this->key) {

The expression $this->key of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $form->setDefaults([
                'key' => $this->key,
                'elements' => implode(',', $this->connection->lrange($this->key, 0, -1)),
            ]);
        }
    }

    public function submit(Form $form, ArrayHash $values)
    {
        if ($this->key) {

The expression $this->key of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $this->connection->del($this->key);
        }

        $elements = array_map('trim', explode(',', $values->elements));
        $this->connection->rpush($values->key, $elements);
    }
}