UniMan\Drivers\Redis\DataManager\RedisListDataManager

Complexity

Total Complexity

13

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	itemsCount()	0	14	4
B	items()	0	30	7
A	createElement()	0	8	1

<?php

namespace UniMan\Drivers\Redis\DataManager;

use RedisProxy\RedisProxy;
use UniMan\Core\Utils\Filter;

class RedisListDataManager
{
    private $connection;

    public function __construct(RedisProxy $connection)
    {
        $this->connection = $connection;
    }

    public function itemsCount(string $key, array $filter): int
    {
        if (!$filter) {

The expression $filter of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->connection->llen($key);
        }
        $totalItems = 0;
        foreach ($this->connection->lrange($key, 0, -1) as $index => $element) {
            $item = $this->createElement($index, $element);
            if (Filter::apply($item, $filter)) {
                $totalItems++;
            }
        }
        return $totalItems;
    }

    public function items(string $key, int $page, int $onPage, array $filter = []): array
    {
        $items = [];
        $offset = ($page - 1) * $onPage;
        if (!$filter) {

The expression $filter of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $res = $this->connection->lrange($key, $offset, $offset + $onPage - 1);
            foreach ($res as $pos => $element) {
                $index = $offset + $pos;
                $items[$index] = $this->createElement($index, $element);
            }
            return $items;
        }

        $skipped = 0;
        foreach ($this->connection->lrange($key, 0, -1) as $index => $element) {
            $item = $this->createElement($index, $element);
            if (!Filter::apply($item, $filter)) {
                continue;
            }
            if ($skipped < $offset) {
                $skipped++;
                continue;
            }
            $items[$index] = $item;
            if (count($items) === $onPage) {
                break;
            }
        }
        return $items;
    }

    private function createElement(int $index, string $element): array
    {
        return [
            'index' => $index,
            'element' => $element,
            'length' => strlen($element),
        ];
    }
}