RedisDataManager::tablesCount() - Code Metrics - Inspection of "Added sorted set management" - lulco/uniman - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Michal

created 2018-08-20 13:22 UTC

RedisDataManager::tablesCount() B

↳ Parent: RedisDataManager

Complexity

Conditions	7
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
dl	0
loc	32
ccs	0
cts	24
cp	0
rs	8.4746
c	0
b	0
f	0
cc	7
nc	7
nop	0
crap	56

<?php

namespace UniMan\Drivers\Redis;

use RedisProxy\RedisProxy;
use UniMan\Core\DataManager\AbstractDataManager;
use UniMan\Core\Utils\Multisort;
use UniMan\Drivers\Redis\DataManager\RedisHashDataManager;
use UniMan\Drivers\Redis\DataManager\RedisKeyDataManager;
use UniMan\Drivers\Redis\DataManager\RedisListDataManager;
use UniMan\Drivers\Redis\DataManager\RedisSetDataManager;
use UniMan\Drivers\Redis\DataManager\RedisSortedSetDataManager;
use UniMan\Drivers\Redis\RedisDatabaseAliasStorage;

class RedisDataManager extends AbstractDataManager
{
    private $connection;

    private $databaseAliasStorage;

    private $itemsCountCache = false;

    public function __construct(RedisProxy $connection, RedisDatabaseAliasStorage $databaseAliasStorage)
    {
        $this->connection = $connection;
        $this->databaseAliasStorage = $databaseAliasStorage;
    }

    public function databases(array $sorting = [])
    {
        $keyspace = $this->connection->info('keyspace');
        $aliases = $this->databaseAliasStorage->loadAll();
        $databases = [];
        foreach ($keyspace as $db => $info) {
            $db = str_replace('db', '', $db);
            $alias = isset($aliases[$db]) ? ' (' . $aliases[$db] . ')' : '';
            $info['database'] = $db . $alias;
            $databases[$db] = $info;
        }
        return Multisort::sort($databases, $sorting);
    }

    protected function getDatabaseNameColumn()
    {
        return 'database';
    }

    public function tablesCount()
    {
        $tables = [
            RedisDriver::TYPE_KEY => 0,
            RedisDriver::TYPE_HASH => 0,
            RedisDriver::TYPE_SET => 0,
            RedisDriver::TYPE_LIST => 0,
            RedisDriver::TYPE_SORTED_SET => 0,
        ];
        foreach ($this->connection->keys('*') as $key) {
            $type = $this->connection->type($key);
            switch ($type) {
                case RedisProxy::TYPE_STRING:
                    $tables[RedisDriver::TYPE_KEY]++;
                    break;
                case RedisProxy::TYPE_HASH:
                    $tables[RedisDriver::TYPE_HASH]++;
                    break;
                case RedisProxy::TYPE_SET:
                    $tables[RedisDriver::TYPE_SET]++;
                    break;
                case RedisProxy::TYPE_LIST:
                    $tables[RedisDriver::TYPE_LIST]++;
                    break;
                case RedisProxy::TYPE_SORTED_SET:

                    $tables[RedisDriver::TYPE_SORTED_SET]++;
                default:
                    break;
            }
        }
        return $tables;
    }

    public function tables(array $sorting = [])
    {
        $tables = [
            RedisDriver::TYPE_KEY => [
                'list_of_all_keys' => [
                    'key' => 'Show all keys',
                    'number_of_keys' => 0,
                ]
            ],
            RedisDriver::TYPE_HASH => [],
            RedisDriver::TYPE_SET => [],
            RedisDriver::TYPE_LIST => [],
            RedisDriver::TYPE_SORTED_SET => [],
        ];
        foreach ($this->connection->keys('*') as $key) {
            $type = $this->connection->type($key);
            if ($type === RedisProxy::TYPE_STRING) {
                $tables[RedisDriver::TYPE_KEY]['list_of_all_keys']['number_of_keys']++;
            } elseif ($type === RedisProxy::TYPE_HASH) {

                $result = $this->connection->hlen($key);
                $ttl = $this->connection->ttl($key);
                $tables[RedisDriver::TYPE_HASH][$key] = [
                    'key' => $key,
                    'number_of_fields' => $result,
                    'ttl' => $ttl > 0 ? $ttl : null,
                ];
            } elseif ($type === RedisProxy::TYPE_SET) {
                $result = $this->connection->scard($key);
                $ttl = $this->connection->ttl($key);
                $tables[RedisDriver::TYPE_SET][$key] = [
                    'key' => $key,
                    'number_of_members' => $result,
                    'ttl' => $ttl > 0 ? $ttl : null,
                ];
            } elseif ($type === RedisProxy::TYPE_LIST) {

                $result = $this->connection->llen($key);
                $ttl = $this->connection->ttl($key);
                $tables[RedisDriver::TYPE_LIST][$key] = [
                    'key' => $key,
                    'number_of_elements' => $result,
                    'ttl' => $ttl > 0 ? $ttl : null,
                ];
            } elseif ($type === RedisProxy::TYPE_SORTED_SET) {
                $result = $this->connection->zcard($key);
                $ttl = $this->connection->ttl($key);
                $tables[RedisDriver::TYPE_SORTED_SET][$key] = [
                    'key' => $key,
                    'number_of_members' => $result,
                    'ttl' => $ttl > 0 ? $ttl : null,
                ];
            }
        }
        return [
            RedisDriver::TYPE_KEY => Multisort::sort($tables[RedisDriver::TYPE_KEY], $sorting),
            RedisDriver::TYPE_HASH => Multisort::sort($tables[RedisDriver::TYPE_HASH], $sorting),
            RedisDriver::TYPE_SET => Multisort::sort($tables[RedisDriver::TYPE_SET], $sorting),
            RedisDriver::TYPE_LIST => Multisort::sort($tables[RedisDriver::TYPE_LIST], $sorting),
            RedisDriver::TYPE_SORTED_SET => Multisort::sort($tables[RedisDriver::TYPE_SORTED_SET], $sorting),
        ];
    }

    public function itemsCount($type, $table, array $filter = [])
    {
        if ($this->itemsCountCache !== false) {
            return $this->itemsCountCache;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
        $itemsCount = 0;
        if ($type === RedisDriver::TYPE_KEY) {
            $manager = new RedisKeyDataManager($this->connection);
            $itemsCount = $manager->itemsCount($filter);
        } elseif ($type === RedisDriver::TYPE_HASH) {

            $manager = new RedisHashDataManager($this->connection);
            $itemsCount = $manager->itemsCount($table, $filter);
        } elseif ($type === RedisDriver::TYPE_SET) {
            $manager = new RedisSetDataManager($this->connection);
            $itemsCount = $manager->itemsCount($table, $filter);
        } elseif ($type === RedisDriver::TYPE_LIST) {

            $manager = new RedisListDataManager($this->connection);
            $itemsCount = $manager->itemsCount($table, $filter);
        } elseif ($type === RedisDriver::TYPE_SORTED_SET) {
            $manager = new RedisSortedSetDataManager($this->connection);
            $itemsCount = $manager->itemsCount($table, $filter);
        }
        $this->itemsCountCache = $itemsCount;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        return $itemsCount;
    }

    public function items($type, $table, $page, $onPage, array $filter = [], array $sorting = [])
    {
        $items = [];
        if ($type === RedisDriver::TYPE_KEY) {
            $manager = new RedisKeyDataManager($this->connection);
            $items = $manager->items($page, $onPage, $filter);
        } elseif ($type === RedisDriver::TYPE_HASH) {

            $manager = new RedisHashDataManager($this->connection);
            $items = $manager->items($table, $page, $onPage, $filter);
        } elseif ($type === RedisDriver::TYPE_SET) {
            $manager = new RedisSetDataManager($this->connection);
            $items = $manager->items($table, $page, $onPage, $filter);
        } elseif ($type === RedisDriver::TYPE_LIST) {

            $manager = new RedisListDataManager($this->connection);
            $items = $manager->items($table, $page, $onPage, $filter);
        } elseif ($type === RedisDriver::TYPE_SORTED_SET) {
            $manager = new RedisSortedSetDataManager($this->connection);
            $items = $manager->items($table, $page, $onPage, $filter);
        }

        if ($this->itemsCount($type, $table, $filter) <= $onPage) {
            $items = Multisort::sort($items, $sorting);
        } elseif ($sorting) {

            $this->addMessage('Sorting has not been applied because the number of items is greater then the limit. Increase the limit or modify the filter.');
        }

        return $items;
    }

    public function deleteItem($type, $table, $item)
    {
        if ($type === RedisDriver::TYPE_HASH) {
            return $this->connection->hdel($table, $item);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
        if ($type === RedisDriver::TYPE_KEY) {
            return $this->connection->del($item);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
        if ($type === RedisDriver::TYPE_SET) {
            return $this->connection->srem($table, $item);
        }
        if ($type === RedisDriver::TYPE_LIST) {
            $value = md5(uniqid());
            $this->connection->lset($table, $item, $value);
            return $this->connection->lrem($table, $value);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
        if ($type === RedisDriver::TYPE_SORTED_SET) {
            return $this->connection->zrem($table, $item);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
        return parent::deleteItem($type, $table, $item);
    }

    public function deleteTable($type, $table)
    {
        return $this->connection->del($table);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function selectDatabase($database)
    {
        $this->connection->select($database);
    }

    public function execute($commands)
    {
        $listOfCommands = array_filter(array_map('trim', explode("\n", $commands)), function ($command) {
            return $command;
        });

        $results = [];
        foreach ($listOfCommands as $command) {
            $commandParts = explode(' ', $command);
            $function = array_shift($commandParts);
            $function = strtolower($function);
            $results[$command]['headers'] = $this->headers($function);
            $rows = call_user_func_array([$this->connection, $function], $commandParts);
            $items = $this->getItems($function, $rows);
            $results[$command]['items'] = $items;
            $results[$command]['count'] = count($items);
        }
        return $results;
    }

    private function headers($function)
    {
        if ($function === 'get' || $function === 'hget') {
            return ['value'];
        }
        if ($function === 'keys') {
            return ['key'];
        }
        if ($function === 'hgetall') {
            return ['key', 'value'];
        }
        if ($function === 'hlen') {
            return ['items_count'];
        }
        return [];
    }

    private function getItems($function, $rows)
    {
        $items = [];
        if ($function === 'keys') {
            foreach ($rows as $key) {
                $items[] = [$key];
            }
        } elseif ($function === 'hgetall') {
            foreach ($rows as $key => $value) {
                $items[] = [$key, $value];
            }
        } else {
            return [[$rows]];
        }
        return $items;
    }
}


1		<?php
2
3		namespace UniMan\Drivers\Redis;
4
5		use RedisProxy\RedisProxy;
6		use UniMan\Core\DataManager\AbstractDataManager;
7		use UniMan\Core\Utils\Multisort;
8		use UniMan\Drivers\Redis\DataManager\RedisHashDataManager;
9		use UniMan\Drivers\Redis\DataManager\RedisKeyDataManager;
10		use UniMan\Drivers\Redis\DataManager\RedisListDataManager;
11		use UniMan\Drivers\Redis\DataManager\RedisSetDataManager;
12		use UniMan\Drivers\Redis\DataManager\RedisSortedSetDataManager;
13		use UniMan\Drivers\Redis\RedisDatabaseAliasStorage;
14
15		class RedisDataManager extends AbstractDataManager
16		{
17		private $connection;
18
19		private $databaseAliasStorage;
20
21		private $itemsCountCache = false;
22
23	2	public function __construct(RedisProxy $connection, RedisDatabaseAliasStorage $databaseAliasStorage)
24		{
25	2	$this->connection = $connection;
26	2	$this->databaseAliasStorage = $databaseAliasStorage;
27	2	}
28
29		public function databases(array $sorting = [])
30		{
31		$keyspace = $this->connection->info('keyspace');
32		$aliases = $this->databaseAliasStorage->loadAll();
33		$databases = [];
34		foreach ($keyspace as $db => $info) {
35		$db = str_replace('db', '', $db);
36		$alias = isset($aliases[$db]) ? ' (' . $aliases[$db] . ')' : '';
37		$info['database'] = $db . $alias;
38		$databases[$db] = $info;
39		}
40		return Multisort::sort($databases, $sorting);

lulco / uniman

Pull Request — master (#30)

RedisDataManager::tablesCount() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like