RedisSortedSetMemberForm::addFieldsToForm() - Code Metrics - lulco/uniman - Measure and Improve Code Quality continuously with Scrutinizer

RedisSortedSetMemberForm::addFieldsToForm() A
last analyzed 2020-10-14 14:07 UTC

↳ Parent: RedisSortedSetMemberForm

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	0
cts	10
cp	0
rs	9.7666
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	6

<?php

namespace UniMan\Drivers\Redis\Forms;

use UniMan\Core\Forms\ItemForm\ItemFormInterface;
use Nette\Application\UI\Form;
use Nette\Utils\ArrayHash;
use RedisProxy\RedisProxy;

class RedisSortedSetMemberForm implements ItemFormInterface
{
    private $connection;

    private $key;

    private $member;

    public function __construct(RedisProxy $connection, $key, $member)
    {
        $this->connection = $connection;
        $this->key = $key;
        $this->member = $member;
    }

    public function addFieldsToForm(Form $form)
    {
        $form->addText('member', 'redis.sorted_set_member_form.member.label')
            ->setRequired('redis.sorted_set_member_form.member.required');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $form->addText('score', 'redis.sorted_set_member_form.score.label')
            ->setRequired('redis.sorted_set_member_form.score.required');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if ($this->member !== null) {
            $form->setDefaults([
                'member' => $this->member,
                'score' => $this->connection->zscore($this->key, $this->member),
            ]);
        }
    }

    public function submit(Form $form, ArrayHash $values)
    {
        if ($this->member !== $values->member) {
            $this->connection->zrem($this->key, $this->member);
        }
        $this->connection->zadd($this->key, [$values->member => str_replace(',', '.', $values->score)]);
    }
}


1			<?php
2
3			namespace UniMan\Drivers\Redis\Forms;
4
5			use UniMan\Core\Forms\ItemForm\ItemFormInterface;
6			use Nette\Application\UI\Form;
7			use Nette\Utils\ArrayHash;
8			use RedisProxy\RedisProxy;
9
10			class RedisSortedSetMemberForm implements ItemFormInterface
11			{
12			private $connection;
13
14			private $key;
15
16			private $member;
17
18			public function __construct(RedisProxy $connection, $key, $member)
19			{
20			$this->connection = $connection;
21			$this->key = $key;
22			$this->member = $member;
23			}
24
25			public function addFieldsToForm(Form $form)
26			{
27			$form->addText('member', 'redis.sorted_set_member_form.member.label')
28			->setRequired('redis.sorted_set_member_form.member.required');
			0 ignored issues – show Documentation introduced 2018-08-20 13:29 UTC by Report Bug Copy Issue Report `'redis.sorted_set_member_form.member.required'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29
30			$form->addText('score', 'redis.sorted_set_member_form.score.label')
31			->setRequired('redis.sorted_set_member_form.score.required');
			0 ignored issues – show Documentation introduced 2018-08-20 13:29 UTC by Report Bug Copy Issue Report `'redis.sorted_set_member_form.score.required'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32
33			if ($this->member !== null) {
34			$form->setDefaults([
35			'member' => $this->member,
36			'score' => $this->connection->zscore($this->key, $this->member),
37			]);
38			}
39			}
40
41			public function submit(Form $form, ArrayHash $values)
42			{
43			if ($this->member !== $values->member) {
44			$this->connection->zrem($this->key, $this->member);
45			}
46			$this->connection->zadd($this->key, [$values->member => str_replace(',', '.', $values->score)]);
47			}
48			}
49

lulco / uniman

RedisSortedSetMemberForm::addFieldsToForm() A last analyzed 2020-10-14 14:07 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RedisSortedSetMemberForm::addFieldsToForm() A
last analyzed 2020-10-14 14:07 UTC