RedisRenameHashForm::addFieldsToForm() - Code Metrics - lulco/uniman - Measure and Improve Code Quality continuously with Scrutinizer

RedisRenameHashForm::addFieldsToForm() A
last analyzed 2020-10-14 14:07 UTC

↳ Parent: RedisRenameHashForm

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	8
cp	0
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace UniMan\Drivers\Redis\Forms;

use Nette\Application\UI\Form;
use Nette\Utils\ArrayHash;
use RedisProxy\RedisProxy;
use UniMan\Core\Forms\TableForm\TableFormInterface;

class RedisRenameHashForm implements TableFormInterface
{
    private $connection;

    private $key;

    public function __construct(RedisProxy $connection, $key)
    {
        $this->connection = $connection;
        $this->key = $key;
    }

    public function addFieldsToForm(Form $form)
    {
        $form->addText('key', 'redis.hash_form.key.label')
            ->setRequired('redis.hash_form.key.required')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setDisabled()
            ->setValue($this->key);
        $form->addText('new_key', 'redis.hash_form.new_key.label')
            ->setRequired('redis.hash_form.new_key.required');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function submit(Form $form, ArrayHash $values)
    {
        if (!$this->connection->rename($this->key, $values['new_key'])) {
            $form->addError('Key "' . $this->key . '" doesn\'t exist');
            return;
        }
    }
}


1			<?php
2
3			namespace UniMan\Drivers\Redis\Forms;
4
5			use Nette\Application\UI\Form;
6			use Nette\Utils\ArrayHash;
7			use RedisProxy\RedisProxy;
8			use UniMan\Core\Forms\TableForm\TableFormInterface;
9
10			class RedisRenameHashForm implements TableFormInterface
11			{
12			private $connection;
13
14			private $key;
15
16			public function __construct(RedisProxy $connection, $key)
17			{
18			$this->connection = $connection;
19			$this->key = $key;
20			}
21
22			public function addFieldsToForm(Form $form)
23			{
24			$form->addText('key', 'redis.hash_form.key.label')
25			->setRequired('redis.hash_form.key.required')
			0 ignored issues – show Documentation introduced 2016-12-19 15:38 UTC by Report Bug Copy Issue Report `'redis.hash_form.key.required'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			->setDisabled()
27			->setValue($this->key);
28			$form->addText('new_key', 'redis.hash_form.new_key.label')
29			->setRequired('redis.hash_form.new_key.required');
			0 ignored issues – show Documentation introduced 2016-12-19 15:38 UTC by Report Bug Copy Issue Report `'redis.hash_form.new_key.required'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30			}
31
32			public function submit(Form $form, ArrayHash $values)
33			{
34			if (!$this->connection->rename($this->key, $values['new_key'])) {
35			$form->addError('Key "' . $this->key . '" doesn\'t exist');
36			return;
37			}
38			}
39			}
40

lulco / uniman

RedisRenameHashForm::addFieldsToForm() A last analyzed 2020-10-14 14:07 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RedisRenameHashForm::addFieldsToForm() A
last analyzed 2020-10-14 14:07 UTC