RedisRenameHashForm::__construct()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 5

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 5
ccs 0
cts 4
cp 0
rs 10
c 0
b 0
f 0
cc 1
nc 1
nop 2
crap 2
1
<?php
2
3
namespace UniMan\Drivers\Redis\Forms;
4
5
use Nette\Application\UI\Form;
6
use Nette\Utils\ArrayHash;
7
use RedisProxy\RedisProxy;
8
use UniMan\Core\Forms\TableForm\TableFormInterface;
9
10
class RedisRenameHashForm implements TableFormInterface
11
{
12
    private $connection;
13
14
    private $key;
15
16
    public function __construct(RedisProxy $connection, $key)
17
    {
18
        $this->connection = $connection;
19
        $this->key = $key;
20
    }
21
22
    public function addFieldsToForm(Form $form)
23
    {
24
        $form->addText('key', 'redis.hash_form.key.label')
25
            ->setRequired('redis.hash_form.key.required')
0 ignored issues
show
Documentation introduced by
'redis.hash_form.key.required' is of type string, but the function expects a boolean.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
26
            ->setDisabled()
27
            ->setValue($this->key);
28
        $form->addText('new_key', 'redis.hash_form.new_key.label')
29
            ->setRequired('redis.hash_form.new_key.required');
0 ignored issues
show
Documentation introduced by
'redis.hash_form.new_key.required' is of type string, but the function expects a boolean.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
30
    }
31
32
    public function submit(Form $form, ArrayHash $values)
33
    {
34
        if (!$this->connection->rename($this->key, $values['new_key'])) {
35
            $form->addError('Key "' . $this->key . '" doesn\'t exist');
36
            return;
37
        }
38
    }
39
}
40