RedisEditSetForm::submit() - Code Metrics - lulco/uniman - Measure and Improve Code Quality continuously with Scrutinizer

RedisEditSetForm::submit() A
last analyzed 2020-10-14 14:07 UTC

↳ Parent: RedisEditSetForm

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	0
cts	11
cp	0
rs	9.7666
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	6

<?php

namespace UniMan\Drivers\Redis\Forms;

use UniMan\Core\Forms\TableForm\TableFormInterface;
use Nette\Application\UI\Form;
use Nette\Utils\ArrayHash;
use RedisProxy\RedisProxy;

class RedisEditSetForm implements TableFormInterface
{
    private $connection;

    private $key;

    public function __construct(RedisProxy $connection, $key)
    {
        $this->connection = $connection;
        $this->key = $key;
    }

    public function addFieldsToForm(Form $form)

    {
        $form->addText('key', 'redis.set_form.key.label')
            ->setRequired('redis.set_form.key.required');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('members', 'redis.set_form.members.label')
            ->setRequired('redis.set_form.members.required')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setOption('description', 'redis.set_form.members.description');
        if ($this->key) {
            $form->setDefaults([
                'key' => $this->key,
                'members' => implode(',', $this->connection->smembers($this->key)),
            ]);
        }
    }

    public function submit(Form $form, ArrayHash $values)
    {
        $key = $values['key'];
        $actualMembers = $this->connection->smembers($this->key);
        $members = array_map('trim', explode(',', $values['members']));

        $membersToRemove = array_diff($actualMembers, $members);
        $membersToAdd = array_diff($members, $actualMembers);
        call_user_func_array([$this->connection, 'srem'], array_merge([$this->key], $membersToRemove));
        call_user_func_array([$this->connection, 'sadd'], array_merge([$this->key], $membersToAdd));

        if ($this->key != $key) {
            $this->connection->rename($this->key, $key);
        }
    }
}


1		<?php
2
3		namespace UniMan\Drivers\Redis\Forms;
4
5		use UniMan\Core\Forms\TableForm\TableFormInterface;
6		use Nette\Application\UI\Form;
7		use Nette\Utils\ArrayHash;
8		use RedisProxy\RedisProxy;
9
10		class RedisEditSetForm implements TableFormInterface
11		{
12		private $connection;
13
14		private $key;
15
16		public function __construct(RedisProxy $connection, $key)
17		{
18		$this->connection = $connection;
19		$this->key = $key;
20		}
21
22	View Code Duplication	public function addFieldsToForm(Form $form)
		0 ignored issues – show Duplication introduced 2018-08-15 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		$form->addText('key', 'redis.set_form.key.label')
25		->setRequired('redis.set_form.key.required');
		0 ignored issues – show Documentation introduced 2016-12-19 15:38 UTC by Report Bug Copy Issue Report `'redis.set_form.key.required'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26		$form->addText('members', 'redis.set_form.members.label')
27		->setRequired('redis.set_form.members.required')
		0 ignored issues – show Documentation introduced 2016-12-19 15:38 UTC by Report Bug Copy Issue Report `'redis.set_form.members.required'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28		->setOption('description', 'redis.set_form.members.description');
29		if ($this->key) {
30		$form->setDefaults([
31		'key' => $this->key,
32		'members' => implode(',', $this->connection->smembers($this->key)),
33		]);
34		}
35		}
36
37		public function submit(Form $form, ArrayHash $values)
38		{
39		$key = $values['key'];
40		$actualMembers = $this->connection->smembers($this->key);
41		$members = array_map('trim', explode(',', $values['members']));
42
43		$membersToRemove = array_diff($actualMembers, $members);
44		$membersToAdd = array_diff($members, $actualMembers);
45		call_user_func_array([$this->connection, 'srem'], array_merge([$this->key], $membersToRemove));
46		call_user_func_array([$this->connection, 'sadd'], array_merge([$this->key], $membersToAdd));
47
48		if ($this->key != $key) {
49		$this->connection->rename($this->key, $key);
50		}
51		}
52		}
53

lulco / uniman

RedisEditSetForm::submit() A last analyzed 2020-10-14 14:07 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RedisEditSetForm::submit() A
last analyzed 2020-10-14 14:07 UTC