RedisCredentialsForm::addFieldsToForm() - Code Metrics - lulco/uniman - Measure and Improve Code Quality continuously with Scrutinizer

RedisCredentialsForm::addFieldsToForm() A
last analyzed 2020-10-14 14:07 UTC

↳ Parent: RedisCredentialsForm

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	8
cts	8
cp	1
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

namespace UniMan\Drivers\Redis\Forms;

use UniMan\Core\CredentialsFormInterface;
use Nette\Application\UI\Form;

class RedisCredentialsForm implements CredentialsFormInterface
{
    public function addFieldsToForm(Form $form)
    {
        $form->addText('host', 'redis.form.host.label')
            ->setAttribute('placeholder', 'localhost');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('port', 'redis.form.port.label')
            ->setAttribute('placeholder', '6379');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('database', 'redis.form.database.label')
            ->setAttribute('placeholder', 0);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace UniMan\Drivers\Redis\Forms;
4
5		use UniMan\Core\CredentialsFormInterface;
6		use Nette\Application\UI\Form;
7
8		class RedisCredentialsForm implements CredentialsFormInterface
9		{
10	2	public function addFieldsToForm(Form $form)
11		{
12	2	$form->addText('host', 'redis.form.host.label')
13	2	->setAttribute('placeholder', 'localhost');
		0 ignored issues – show Documentation introduced 2016-12-19 15:38 UTC by Report Bug Copy Issue Report `'localhost'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
14	2	$form->addText('port', 'redis.form.port.label')
15	2	->setAttribute('placeholder', '6379');
		0 ignored issues – show Documentation introduced 2016-12-19 15:38 UTC by Report Bug Copy Issue Report `'6379'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
16	2	$form->addText('database', 'redis.form.database.label')
17	2	->setAttribute('placeholder', 0);
		0 ignored issues – show Documentation introduced 2016-12-19 15:38 UTC by Report Bug Copy Issue Report `0` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
18	2	}
19		}
20

lulco / uniman

RedisCredentialsForm::addFieldsToForm() A last analyzed 2020-10-14 14:07 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RedisCredentialsForm::addFieldsToForm() A
last analyzed 2020-10-14 14:07 UTC