UniMan\Presenters\CommandPresenter

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	renderDefault()	0	9	2
A	createComponentForm()	0	12	1
A	formSuccess()	0	4	1

<?php

namespace UniMan\Presenters;

use Nette\Application\ForbiddenRequestException;
use Nette\Application\UI\Form;
use Nette\Utils\ArrayHash;
use Tomaj\Form\Renderer\BootstrapVerticalRenderer;

class CommandPresenter extends BasePresenter
{
    private $commands;

    private $results = [];

    public function renderDefault($driver, $database = null, $commands = null)

The parameter $driver is not used and could be removed.

    {
        if (!$this->driver->permissions()->canExecuteCommands()) {
            throw new ForbiddenRequestException('Executing commands is not available');
        }
        $this->database = $database;
        $this->commands = $commands;
        $this->template->results = $this->results;
    }

    protected function createComponentForm()
    {
        $form = new Form();
        $form->setMethod('get');
        $form->setRenderer(new BootstrapVerticalRenderer());
        $form->addTextArea('commands', 'Commands', null, 10)
            ->setDefaultValue($this->commands)
            ->setRequired('%label is required');

'%label is required' is of type string, but the function expects a boolean.

        $form->addSubmit('submit', 'Execute');
        $form->onSuccess[] = [$this, 'formSuccess'];
        return $form;
    }

    public function formSuccess(Form $form, ArrayHash $values)
    {
        $this->results = $this->driver->dataManager()->execute($values['commands']);

It seems like $this->driver->dataManager()->execute($values['commands']) can be null. However, the property $results is declared as array. Maybe change the type of the property to array|null or add a type check?

    }
}