UniMan\Drivers\Redis\Forms\RedisHashKeyItemForm

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	54.05 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	addFieldsToForm()	13	13	2
A	submit()	7	7	2

<?php

namespace UniMan\Drivers\Redis\Forms;

use UniMan\Core\Forms\ItemForm\ItemFormInterface;
use Nette\Application\UI\Form;
use Nette\Utils\ArrayHash;
use RedisProxy\RedisProxy;

class RedisHashKeyItemForm implements ItemFormInterface
{
    private $connection;

    private $hash;

    private $key;

    public function __construct(RedisProxy $connection, $hash, $key)
    {
        $this->connection = $connection;
        $this->hash = $hash;
        $this->key = $key;
    }

    public function addFieldsToForm(Form $form)

This method seems to be duplicated in your project.

    {
        $form->addText('key', 'redis.key_form.key.label')
            ->setRequired('redis.key_form.key.required');

'redis.key_form.key.required' is of type string, but the function expects a boolean.

        $form->addText('value', 'redis.key_form.value.label');

        if ($this->key) {
            $form->setDefaults([
                'key' => $this->key,
                'value' => $this->connection->hget($this->hash, $this->key),
            ]);
        }
    }

    public function submit(Form $form, ArrayHash $values)

This method seems to be duplicated in your project.

    {
        if ($this->key) {
            $this->connection->hdel($this->hash, $this->key);
        }
        $this->connection->hset($this->hash, $values['key'], $values['value']);
    }
}