Complex classes like RedisProxy often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RedisProxy, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class RedisProxy |
||
| 24 | { |
||
| 25 | const DRIVER_REDIS = 'redis'; |
||
| 26 | |||
| 27 | const DRIVER_PREDIS = 'predis'; |
||
| 28 | |||
| 29 | private $driver; |
||
| 30 | |||
| 31 | private $host; |
||
| 32 | |||
| 33 | private $port; |
||
| 34 | |||
| 35 | private $database = 0; |
||
| 36 | |||
| 37 | private $timeout; |
||
| 38 | |||
| 39 | private $supportedDrivers = [ |
||
| 40 | self::DRIVER_REDIS, |
||
| 41 | self::DRIVER_PREDIS, |
||
| 42 | ]; |
||
| 43 | |||
| 44 | private $driversOrder = []; |
||
| 45 | |||
| 46 | 112 | public function __construct($host, $port, $timeout = null) |
|
| 53 | |||
| 54 | 112 | public function setDriversOrder(array $driversOrder) |
|
| 67 | |||
| 68 | 108 | private function init() |
|
| 73 | |||
| 74 | 108 | private function prepareDriver() |
|
| 92 | |||
| 93 | 108 | private function connect($host, $port, $timeout = null) |
|
| 97 | |||
| 98 | 108 | private function isConnected() |
|
| 102 | |||
| 103 | 108 | public function __call($name, $arguments) |
|
| 114 | |||
| 115 | /** |
||
| 116 | * @param integer $database |
||
| 117 | * @return boolean true on success |
||
| 118 | * @throws RedisProxyException on failure |
||
| 119 | */ |
||
| 120 | 108 | public function select($database) |
|
| 141 | |||
| 142 | /** |
||
| 143 | * @param string|null $section |
||
| 144 | * @return array |
||
| 145 | */ |
||
| 146 | 8 | public function info($section = null) |
|
| 162 | |||
| 163 | /** |
||
| 164 | * Set multiple values to multiple keys |
||
| 165 | * @param array $dictionary |
||
| 166 | * @return boolean true on success |
||
| 167 | * @throws RedisProxyException if number of arguments is wrong |
||
| 168 | */ |
||
| 169 | 12 | public function mset(...$dictionary) |
|
| 170 | { |
||
| 171 | 12 | if (is_array($dictionary[0])) { |
|
| 172 | 8 | $result = $this->driver->mset(...$dictionary); |
|
| 173 | 8 | return $this->transformResult($result); |
|
| 174 | } |
||
| 175 | 8 | $dictionary = $this->prepareKeyValue($dictionary, 'mset'); |
|
| 176 | 4 | $result = $this->driver->mset($dictionary); |
|
| 177 | 4 | return $this->transformResult($result); |
|
| 178 | } |
||
| 179 | |||
| 180 | /** |
||
| 181 | * @param string $key |
||
| 182 | * @return string|null null if hash field is not set |
||
| 183 | */ |
||
| 184 | 16 | public function get($key) |
|
| 190 | |||
| 191 | /** |
||
| 192 | * Delete a key(s) |
||
| 193 | * @param array ...$keys |
||
| 194 | * @return integer number of deleted keys |
||
| 195 | */ |
||
| 196 | 20 | public function del(...$keys) |
|
| 201 | |||
| 202 | /** |
||
| 203 | * Delete a key(s) |
||
| 204 | * @param array ...$keys |
||
| 205 | * @return integer number of deleted keys |
||
| 206 | */ |
||
| 207 | 8 | public function delete(...$keys) |
|
| 211 | |||
| 212 | /** |
||
| 213 | * Incrementally iterate the keys space |
||
| 214 | * @param mixed $iterator iterator / cursor, use $iterator = null for start scanning, when $iterator is changed to 0 or '0', scanning is finished |
||
| 215 | * @param string $pattern pattern for keys, use * as wild card |
||
| 216 | * @param integer $count |
||
| 217 | * @return array|boolean|null list of found keys, returns null if $iterator is 0 or '0' |
||
| 218 | */ |
||
| 219 | 4 | public function scan(&$iterator, $pattern = null, $count = null) |
|
| 232 | |||
| 233 | /** |
||
| 234 | * Get the value of a hash field |
||
| 235 | * @param string $key |
||
| 236 | * @param string $field |
||
| 237 | * @return string|null null if hash field is not set |
||
| 238 | */ |
||
| 239 | 16 | public function hget($key, $field) |
|
| 245 | |||
| 246 | /** |
||
| 247 | * Delete one or more hash fields, returns number of deleted fields |
||
| 248 | * @param array $key |
||
| 249 | * @param array ...$fields |
||
| 250 | * @return integer |
||
| 251 | */ |
||
| 252 | 8 | public function hdel($key, ...$fields) |
|
| 259 | |||
| 260 | /** |
||
| 261 | * Increment the integer value of hash field by given number |
||
| 262 | * @param string $key |
||
| 263 | * @param string $field |
||
| 264 | * @param integer $increment |
||
| 265 | * @return integer |
||
| 266 | */ |
||
| 267 | 4 | public function hincrby($key, $field, $increment = 1) |
|
| 271 | |||
| 272 | /** |
||
| 273 | * Increment the float value of hash field by given amount |
||
| 274 | * @param string $key |
||
| 275 | * @param string $field |
||
| 276 | * @param float $increment |
||
| 277 | * @return float |
||
| 278 | */ |
||
| 279 | 4 | public function hincrbyfloat($key, $field, $increment = 1) |
|
| 283 | |||
| 284 | /** |
||
| 285 | * Set multiple values to multiple hash fields |
||
| 286 | * @param string $key |
||
| 287 | * @param array $dictionary |
||
| 288 | * @return boolean true on success |
||
| 289 | * @throws RedisProxyException if number of arguments is wrong |
||
| 290 | */ |
||
| 291 | 12 | public function hmset($key, ...$dictionary) |
|
| 301 | |||
| 302 | /** |
||
| 303 | * Incrementally iterate hash fields and associated values |
||
| 304 | * @param string $key |
||
| 305 | * @param mixed $iterator iterator / cursor, use $iterator = null for start scanning, when $iterator is changed to 0 or '0', scanning is finished |
||
| 306 | * @param string $pattern pattern for fields, use * as wild card |
||
| 307 | * @param integer $count |
||
| 308 | * @return array|boolean|null list of found fields with associated values, returns null if $iterator is 0 or '0' |
||
| 309 | */ |
||
| 310 | 4 | public function hscan($key, &$iterator, $pattern = null, $count = null) |
|
| 323 | |||
| 324 | /** |
||
| 325 | * Add one or more members to a set |
||
| 326 | * @param string $key |
||
| 327 | * @param array ...$members |
||
| 328 | * @return integer number of new members added to set |
||
| 329 | */ |
||
| 330 | 12 | public function sadd($key, ...$members) |
|
| 337 | |||
| 338 | /** |
||
| 339 | * Remove and return one or multiple random members from a set |
||
| 340 | * @param string $key |
||
| 341 | * @param integer $count number of members |
||
| 342 | * @return mixed string if $count is null or 1 and $key exists, array if $count > 1 and $key exists, null if $key doesn't exist |
||
| 343 | */ |
||
| 344 | 4 | public function spop($key, $count = 1) |
|
| 361 | |||
| 362 | /** |
||
| 363 | * Incrementally iterate Set elements |
||
| 364 | * @param string $key |
||
| 365 | * @param mixed $iterator iterator / cursor, use $iterator = null for start scanning, when $iterator is changed to 0 or '0', scanning is finished |
||
| 366 | * @param string $pattern pattern for member's values, use * as wild card |
||
| 367 | * @param integer $count |
||
| 368 | * @return array|boolean|null list of found members, returns null if $iterator is 0 or '0' |
||
| 369 | */ |
||
| 370 | 4 | public function sscan($key, &$iterator, $pattern = null, $count = null) |
|
| 383 | |||
| 384 | /** |
||
| 385 | * Incrementally iterate sorted sets elements and associated scores |
||
| 386 | * @param string $key |
||
| 387 | * @param mixed $iterator iterator / cursor, use $iterator = null for start scanning, when $iterator is changed to 0 or '0', scanning is finished |
||
| 388 | * @param string $pattern pattern for element's values, use * as wild card |
||
| 389 | * @param integer $count |
||
| 390 | * @return array|boolean|null list of found elements, returns null if $iterator is 0 or '0' |
||
| 391 | */ |
||
| 392 | public function zscan($key, &$iterator, $pattern = null, $count = null) |
||
| 405 | |||
| 406 | 36 | private function convertFalseToNull($result) |
|
| 410 | |||
| 411 | 108 | private function transformResult($result) |
|
| 418 | |||
| 419 | /** |
||
| 420 | * Create array from input array - odd keys are used as keys, even keys are used as values |
||
| 421 | * @param array $dictionary |
||
| 422 | * @param string $command |
||
| 423 | * @return array |
||
| 424 | * @throws RedisProxyException if number of keys is not the same as number of values |
||
| 425 | */ |
||
| 426 | 16 | private function prepareKeyValue(array $dictionary, $command) |
|
| 440 | } |
||
| 441 |