RedisProxy\ListBehavior

Complexity

Total Complexity

5

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
	init()	0	1	?
	actualDriver()	0	1	?
A	lpush()	0	6	1
A	rpush()	0	6	1
A	lpop()	0	6	1
A	rpop()	0	6	1
A	lindex()	0	6	1

<?php

namespace RedisProxy;

/**
 * @method int llen(string $key) Get the length of a list
 * @method array lrange(string $key, int $start, int $stop) Get a range of elements from a list
 */
trait ListBehavior
{
    private $driver;

    abstract protected function init();

    abstract public function actualDriver();

    /**
     * Prepend one or multiple values to a list
     * @param string $key
     * @param array $elements
     * @return int the length of the list after the push operations
     */
    public function lpush($key, ...$elements)
    {
        $elements = $this->prepareArguments('lpush', ...$elements);

It seems like prepareArguments() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->init();
        return $this->driver->lpush($key, ...$elements);
    }

    /**
     * Append one or multiple values to a list
     * @param string $key
     * @param array $elements
     * @return int the length of the list after the push operations
     */
    public function rpush($key, ...$elements)
    {
        $elements = $this->prepareArguments('rpush', ...$elements);

It seems like prepareArguments() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->init();
        return $this->driver->rpush($key, ...$elements);
    }

    /**
     * Remove and get the first element in a list
     * @param string $key
     * @return string|null
     */
    public function lpop($key)
    {
        $this->init();
        $result = $this->driver->lpop($key);
        return $this->convertFalseToNull($result);

It seems like convertFalseToNull() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Remove and get the last element in a list
     * @param string $key
     * @return string|null
     */
    public function rpop($key)
    {
        $this->init();
        $result = $this->driver->rpop($key);
        return $this->convertFalseToNull($result);

It seems like convertFalseToNull() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Get an element from a list by its index
     * @param string $key
     * @param int $index zero-based, so 0 means the first element, 1 the second element and so on. -1 means the last element, -2 means the penultimate and so forth
     * @return string|null
     */
    public function lindex($key, $index)
    {
        $this->init();
        $result = $this->driver->lindex($key, $index);
        return $this->convertFalseToNull($result);

It seems like convertFalseToNull() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}