Mula::set() - Code Metrics - Inspection of "Merge pull request #2 from lukeraymonddowning/smar..." - lukeraymonddowning/mula - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7ed496...ae90dd )

by Luke

created 2020-09-30 14:47 UTC

Mula::set() A

↳ Parent: Mula

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	4

<?php

namespace Lukeraymonddowning\Mula\Casts;

use Illuminate\Contracts\Database\Eloquent\CastsAttributes;
use Illuminate\Support\Str;
use Lukeraymonddowning\Mula\Facades;

class Mula implements CastsAttributes
{
    protected $columns = [];

    public function __construct(...$columns)
    {
        $this->columns = $columns;
    }

    public function get($model, string $key, $money, array $attributes)
    {
        return Facades\Mula::create(...$this->getMonetaryValues($money, $attributes));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    protected function getMonetaryValues($money, $attributes)
    {
        return $this->expectsCurrencyAndAmountInSameColumn()
            ? explode('|', $money, 2)
            : [$attributes[$this->columns[0]], $attributes[$this->columns[1]]];
    }

    protected function expectsCurrencyAndAmountInSameColumn()
    {
        return empty($this->columns);
    }

    public function set($model, string $key, $money, array $attributes)
    {
        if ($this->expectsCurrencyAndAmountInSameColumn()) {
            return "{$money->value()}|{$money->currency()}";
        }

        return [
            $this->columns[0] => $money->value(),
            $this->columns[1] => $money->currency()
        ];
    }
}


1			<?php
2
3			namespace Lukeraymonddowning\Mula\Casts;
4
5			use Illuminate\Contracts\Database\Eloquent\CastsAttributes;
6			use Illuminate\Support\Str;
7			use Lukeraymonddowning\Mula\Facades;
8
9			class Mula implements CastsAttributes
10			{
11			protected $columns = [];
12
13			public function __construct(...$columns)
14			{
15			$this->columns = $columns;
16			}
17
18			public function get($model, string $key, $money, array $attributes)
19			{
20			return Facades\Mula::create(...$this->getMonetaryValues($money, $attributes));
			0 ignored issues – show Documentation introduced 2020-09-30 14:47 UTC by Report Bug Copy Issue Report `$this->getMonetaryValues($money, $attributes)` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21			}
22
23			protected function getMonetaryValues($money, $attributes)
24			{
25			return $this->expectsCurrencyAndAmountInSameColumn()
26			? explode('\|', $money, 2)
27			: [$attributes[$this->columns[0]], $attributes[$this->columns[1]]];
28			}
29
30			protected function expectsCurrencyAndAmountInSameColumn()
31			{
32			return empty($this->columns);
33			}
34
35			public function set($model, string $key, $money, array $attributes)
36			{
37			if ($this->expectsCurrencyAndAmountInSameColumn()) {
38			return "{$money->value()}\|{$money->currency()}";
39			}
40
41			return [
42			$this->columns[0] => $money->value(),
43			$this->columns[1] => $money->currency()
44			];
45			}
46			}
47

lukeraymonddowning / mula

Push — master ( 7ed496...ae90dd )

Mula::set() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like