Complex classes like LaraCart often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LaraCart, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class LaraCart implements LaraCartContract |
||
| 16 | { |
||
| 17 | const QTY = 'qty'; |
||
| 18 | const HASH = 'generateCartHash'; |
||
| 19 | const PRICE = 'price'; |
||
| 20 | const SERVICE = 'laracart'; |
||
| 21 | const RANHASH = 'generateRandomCartItemHash'; |
||
| 22 | |||
| 23 | protected $events; |
||
| 24 | protected $session; |
||
| 25 | |||
| 26 | public $cart; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * LaraCart constructor. |
||
| 30 | * |
||
| 31 | * @param SessionManager $session |
||
| 32 | * @param Dispatcher $events |
||
| 33 | */ |
||
| 34 | public function __construct(SessionManager $session, Dispatcher $events) |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Sets and Gets the instance of the cart in the session we should be using |
||
| 44 | * |
||
| 45 | * @param string $instance |
||
| 46 | * |
||
| 47 | * @return LaraCart |
||
| 48 | */ |
||
| 49 | public function setInstance($instance = 'default') |
||
| 50 | { |
||
| 51 | $this->get($instance); |
||
| 52 | |||
| 53 | $this->session->set('laracart.instance', $instance); |
||
| 54 | |||
| 55 | $this->events->fire('laracart.new'); |
||
| 56 | |||
| 57 | return $this; |
||
| 58 | } |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Gets the instance in the session |
||
| 62 | * |
||
| 63 | * @param string $instance |
||
| 64 | * |
||
| 65 | * @return $this cart instance |
||
| 66 | */ |
||
| 67 | public function get($instance = 'default') |
||
| 75 | |||
| 76 | /** |
||
| 77 | * Gets an an attribute from the cart |
||
| 78 | * |
||
| 79 | * @param $attribute |
||
| 80 | * @param $defaultValue |
||
| 81 | * |
||
| 82 | * @return mixed |
||
| 83 | */ |
||
| 84 | public function getAttribute($attribute, $defaultValue = null) |
||
| 85 | { |
||
| 86 | return array_get($this->cart->attributes, $attribute, $defaultValue); |
||
| 87 | } |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Gets all the carts attributes |
||
| 91 | * |
||
| 92 | * @return mixed |
||
| 93 | */ |
||
| 94 | public function getAttributes() |
||
| 95 | { |
||
| 96 | return $this->cart->attributes; |
||
| 97 | } |
||
| 98 | |||
| 99 | /** |
||
| 100 | * Adds an Attribute to the cart |
||
| 101 | * |
||
| 102 | * @param $attribute |
||
| 103 | * @param $value |
||
| 104 | */ |
||
| 105 | public function setAttribute($attribute, $value) |
||
| 106 | { |
||
| 107 | array_set($this->cart->attributes, $attribute, $value); |
||
| 108 | |||
| 109 | $this->update(); |
||
| 110 | } |
||
| 111 | |||
| 112 | /** |
||
| 113 | * Updates cart session |
||
| 114 | */ |
||
| 115 | public function update() |
||
| 116 | { |
||
| 117 | $this->session->set(config('laracart.cache_prefix', 'laracart') . '.' . $this->cart->instance, $this->cart); |
||
| 118 | |||
| 119 | $this->events->fire('laracart.update', $this->cart); |
||
| 120 | } |
||
| 121 | |||
| 122 | /** |
||
| 123 | * Removes an attribute from the cart |
||
| 124 | * |
||
| 125 | * @param $attribute |
||
| 126 | */ |
||
| 127 | public function removeAttribute($attribute) |
||
| 128 | { |
||
| 129 | array_forget($this->cart->attributes, $attribute); |
||
| 130 | |||
| 131 | $this->update(); |
||
| 132 | } |
||
| 133 | |||
| 134 | /** |
||
| 135 | * Creates a CartItem and then adds it to cart |
||
| 136 | * |
||
| 137 | * @param string|int $itemID |
||
| 138 | * @param null $name |
||
| 139 | * @param int $qty |
||
| 140 | * @param string $price |
||
| 141 | * @param array $options |
||
| 142 | * @param bool|true $taxable |
||
| 143 | * |
||
| 144 | * @return CartItem |
||
| 145 | */ |
||
| 146 | public function addLine($itemID, $name = null, $qty = 1, $price = '0.00', $options = [], $taxable = true) |
||
| 150 | |||
| 151 | /** |
||
| 152 | * Creates a CartItem and then adds it to cart |
||
| 153 | * |
||
| 154 | * @param $itemID |
||
| 155 | * @param null $name |
||
| 156 | * @param int $qty |
||
| 157 | * @param string $price |
||
| 158 | * @param array $options |
||
| 159 | * @param bool|false $taxable |
||
| 160 | * @param bool|false $lineItem |
||
| 161 | * |
||
| 162 | * @return CartItem |
||
| 163 | */ |
||
| 164 | public function add( |
||
| 165 | $itemID, |
||
| 166 | $name = null, |
||
| 167 | $qty = 1, |
||
| 168 | $price = '0.00', |
||
| 169 | $options = [], |
||
| 170 | $taxable = true, |
||
| 171 | $lineItem = false |
||
| 172 | ) { |
||
| 173 | $item = $this->addItem( |
||
| 174 | new CartItem( |
||
| 175 | $itemID, |
||
| 176 | $name, |
||
| 177 | $qty, |
||
| 178 | $price, |
||
| 179 | $options, |
||
| 180 | $taxable, |
||
| 181 | $lineItem |
||
| 182 | ) |
||
| 183 | ); |
||
| 184 | |||
| 185 | return $this->getItem($item->getHash()); |
||
| 186 | } |
||
| 187 | |||
| 188 | /** |
||
| 189 | * Adds the cartItem into the cart session |
||
| 190 | * |
||
| 191 | * @param CartItem $cartItem |
||
| 192 | * |
||
| 193 | * @return CartItem |
||
| 194 | */ |
||
| 195 | public function addItem(CartItem $cartItem) |
||
| 211 | |||
| 212 | /** |
||
| 213 | * Increment the quantity of a cartItem based on the itemHash |
||
| 214 | * |
||
| 215 | * @param $itemHash |
||
| 216 | * |
||
| 217 | * @return CartItem | null |
||
| 218 | */ |
||
| 219 | public function increment($itemHash) |
||
| 226 | |||
| 227 | /** |
||
| 228 | * Decrement the quantity of a cartItem based on the itemHash |
||
| 229 | * |
||
| 230 | * @param $itemHash |
||
| 231 | * |
||
| 232 | * @return CartItem | null |
||
| 233 | */ |
||
| 234 | public function decrement($itemHash) |
||
| 247 | |||
| 248 | /* |
||
| 249 | * Find items in the cart matching a data set |
||
| 250 | * |
||
| 251 | * @return array |
||
| 252 | */ |
||
| 253 | public function find($data) |
||
| 265 | |||
| 266 | /** |
||
| 267 | * Finds a cartItem based on the itemHash |
||
| 268 | * |
||
| 269 | * @param $itemHash |
||
| 270 | * |
||
| 271 | * @return CartItem | null |
||
| 272 | */ |
||
| 273 | public function getItem($itemHash) |
||
| 277 | |||
| 278 | /** |
||
| 279 | * Gets all the items within the cart |
||
| 280 | * |
||
| 281 | * @return array |
||
| 282 | */ |
||
| 283 | public function getItems() |
||
| 294 | |||
| 295 | /** |
||
| 296 | * Updates an items attributes |
||
| 297 | * |
||
| 298 | * @param $itemHash |
||
| 299 | * @param $key |
||
| 300 | * @param $value |
||
| 301 | * |
||
| 302 | * @return CartItem |
||
| 303 | * |
||
| 304 | * @throws Exceptions\InvalidPrice |
||
| 305 | * @throws Exceptions\InvalidQuantity |
||
| 306 | */ |
||
| 307 | public function updateItem($itemHash, $key, $value) |
||
| 317 | |||
| 318 | /** |
||
| 319 | * Removes a CartItem based on the itemHash |
||
| 320 | * |
||
| 321 | * @param $itemHash |
||
| 322 | */ |
||
| 323 | public function removeItem($itemHash) |
||
| 334 | |||
| 335 | /** |
||
| 336 | * Empties the carts items |
||
| 337 | */ |
||
| 338 | public function emptyCart() |
||
| 346 | |||
| 347 | /** |
||
| 348 | * Completely destroys cart and anything associated with it |
||
| 349 | */ |
||
| 350 | public function destroyCart() |
||
| 360 | |||
| 361 | /** |
||
| 362 | * Gets the coupons for the current cart |
||
| 363 | * |
||
| 364 | * @return array |
||
| 365 | */ |
||
| 366 | public function getCoupons() |
||
| 370 | |||
| 371 | /** |
||
| 372 | * Finds a specific coupon in the cart |
||
| 373 | * |
||
| 374 | * @param $code |
||
| 375 | * @return mixed |
||
| 376 | */ |
||
| 377 | public function findCoupon($code) |
||
| 381 | |||
| 382 | /** |
||
| 383 | * Applies a coupon to the cart |
||
| 384 | * |
||
| 385 | * @param CouponContract $coupon |
||
| 386 | */ |
||
| 387 | public function addCoupon(CouponContract $coupon) |
||
| 397 | |||
| 398 | /** |
||
| 399 | * Removes a coupon in the cart |
||
| 400 | * |
||
| 401 | * @param $code |
||
| 402 | */ |
||
| 403 | public function removeCoupon($code) |
||
| 417 | |||
| 418 | /** |
||
| 419 | * Gets a speific fee from the fees array |
||
| 420 | * |
||
| 421 | * @param $name |
||
| 422 | * |
||
| 423 | * @return mixed |
||
| 424 | */ |
||
| 425 | public function getFee($name) |
||
| 429 | |||
| 430 | /** |
||
| 431 | * Allows to charge for additional fees that may or may not be taxable |
||
| 432 | * ex - service fee , delivery fee, tips |
||
| 433 | * |
||
| 434 | * @param $name |
||
| 435 | * @param $amount |
||
| 436 | * @param bool|false $taxable |
||
| 437 | * @param array $options |
||
| 438 | */ |
||
| 439 | public function addFee($name, $amount, $taxable = false, array $options = []) |
||
| 445 | |||
| 446 | /** |
||
| 447 | * Reemoves a fee from the fee array |
||
| 448 | * |
||
| 449 | * @param $name |
||
| 450 | */ |
||
| 451 | public function removeFee($name) |
||
| 457 | |||
| 458 | /** |
||
| 459 | * Gets the total tax for the cart |
||
| 460 | * |
||
| 461 | * @param bool|true $format |
||
| 462 | * |
||
| 463 | * @return string |
||
| 464 | */ |
||
| 465 | public function taxTotal($format = true) |
||
| 495 | |||
| 496 | /** |
||
| 497 | * Gets the total of the cart with or without tax |
||
| 498 | * |
||
| 499 | * @param boolean $format |
||
| 500 | * @param boolean $withDiscount |
||
| 501 | * |
||
| 502 | * @return string |
||
| 503 | */ |
||
| 504 | public function total($format = true, $withDiscount = true, $withTax = true) |
||
| 518 | |||
| 519 | /** |
||
| 520 | * Gets the subtotal of the cart with or without tax |
||
| 521 | * |
||
| 522 | * @param boolean $format |
||
| 523 | * @param boolean $withDiscount |
||
| 524 | * |
||
| 525 | * @return string |
||
| 526 | */ |
||
| 527 | public function subTotal($format = true, $withDiscount = true) |
||
| 539 | |||
| 540 | /** |
||
| 541 | * Get the count based on qty, or number of unique items |
||
| 542 | * |
||
| 543 | * @param bool $withItemQty |
||
| 544 | * |
||
| 545 | * @return int |
||
| 546 | */ |
||
| 547 | public function count($withItemQty = true) |
||
| 561 | |||
| 562 | /** |
||
| 563 | * |
||
| 564 | * Formats the number into a money format based on the locale and international formats |
||
| 565 | * |
||
| 566 | * @param $number |
||
| 567 | * @param $locale |
||
| 568 | * @param $internationalFormat |
||
| 569 | * @param $format |
||
| 570 | * |
||
| 571 | * @return string |
||
| 572 | */ |
||
| 573 | public static function formatMoney($number, $locale = null, $internationalFormat = null, $format = true) |
||
| 590 | |||
| 591 | /** |
||
| 592 | * Gets all the fee totals |
||
| 593 | * |
||
| 594 | * @param boolean $format |
||
| 595 | * |
||
| 596 | * @return string |
||
| 597 | */ |
||
| 598 | public function feeTotals($format = true, $withTax = false) |
||
| 612 | |||
| 613 | /** |
||
| 614 | * Gets all the fees on the cart object |
||
| 615 | * |
||
| 616 | * @return mixed |
||
| 617 | */ |
||
| 618 | public function getFees() |
||
| 622 | |||
| 623 | /** |
||
| 624 | * Gets the total amount discounted |
||
| 625 | * |
||
| 626 | * @param boolean $format |
||
| 627 | * |
||
| 628 | * @return string |
||
| 629 | */ |
||
| 630 | public function totalDiscount($format = true) |
||
| 642 | } |
||
| 643 |
Since your code implements the magic setter
_set, this function will be called for any write access on an undefined variable. You can add the@propertyannotation to your class or interface to document the existence of this variable.Since the property has write access only, you can use the @property-write annotation instead.
Of course, you may also just have mistyped another name, in which case you should fix the error.
See also the PhpDoc documentation for @property.