ProfileController::filters() - Code Metrics - Inspection of "add template" - lugnsk/micro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6bb8e...21b718 )

by Oleg

created 2016-03-13 00:12 UTC

ProfileController::filters() B

↳ Parent: ProfileController

Complexity

Conditions	1
Paths	1

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	26
rs	8.8571
cc	1
eloc	14
nc	1
nop	0

<?php

namespace App\Controllers;

use App\Components\Controller;
use App\Components\View;
use App\Models\User;

/**
 * Class ProfileController
 * @package App\Controllers
 */
class ProfileController extends Controller
{
    public function filters()
    {
        return [
            [
                'class' => '\Micro\Filter\AccessFilter',
                'actions' => ['index'],
                'rules' => [
                    [
                        'allow' => false,
                        'actions' => ['index'],
                        'users' => ['?'],
                        'message' => 'Only for authorized!'
                    ]
                ]
            ],
            [
                'class' => '\Micro\Filter\CsrfFilter',
                'actions' => ['index']
            ],
            [
                'class' => '\Micro\Filter\XssFilter',
                'actions' => ['index'],
                'clean' => '*'
            ]
        ];
    }

    public function actionIndex()
    {
        $user = User::findByPk($this->container->user->getID(), $this->container);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        if (!$user) {
            $this->redirect('/logout');
        }

        /** @var array $setup */
        if ($setup = $this->container->request->post('Setup')) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            if (!empty($setup['pass'])) {
                $user->pass = md5($setup['pass']);
            }

            if (!empty($setup['fio'])) {
                $user->fio = $setup['fio'];
            }

            $user->save();
        }

        $v = new View($this->container);
        $v->addParameter('user', $user);

        return $v;
    }
}


1			<?php
2
3			namespace App\Controllers;
4
5			use App\Components\Controller;
6			use App\Components\View;
7			use App\Models\User;
8
9			/**
10			* Class ProfileController
11			* @package App\Controllers
12			*/
13			class ProfileController extends Controller
14			{
15			public function filters()
16			{
17			return [
18			[
19			'class' => '\Micro\Filter\AccessFilter',
20			'actions' => ['index'],
21			'rules' => [
22			[
23			'allow' => false,
24			'actions' => ['index'],
25			'users' => ['?'],
26			'message' => 'Only for authorized!'
27			]
28			]
29			],
30			[
31			'class' => '\Micro\Filter\CsrfFilter',
32			'actions' => ['index']
33			],
34			[
35			'class' => '\Micro\Filter\XssFilter',
36			'actions' => ['index'],
37			'clean' => '*'
38			]
39			];
40			}
41
42			public function actionIndex()
43			{
44			$user = User::findByPk($this->container->user->getID(), $this->container);
			0 ignored issues – show Bug introduced 2016-03-13 00:17 UTC by Report Bug Copy Issue Report Accessing `user` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
45			if (!$user) {
46			$this->redirect('/logout');
47			}
48
49			/** @var array $setup */
50			if ($setup = $this->container->request->post('Setup')) {
			0 ignored issues – show Bug introduced 2016-03-13 00:17 UTC by Report Bug Copy Issue Report Accessing `request` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
51			if (!empty($setup['pass'])) {
52			$user->pass = md5($setup['pass']);
53			}
54
55			if (!empty($setup['fio'])) {
56			$user->fio = $setup['fio'];
57			}
58
59			$user->save();
60			}
61
62			$v = new View($this->container);
63			$v->addParameter('user', $user);
64
65			return $v;
66			}
67			}
68

lugnsk / micro

Push — master ( d6bb8e...21b718 )

ProfileController::filters() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like