DefaultController::filters() - Code Metrics - Inspection of "add template" - lugnsk/micro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6bb8e...21b718 )

by Oleg

created 2016-03-13 00:12 UTC

DefaultController::filters() B

↳ Parent: DefaultController

Complexity

Conditions	1
Paths	1

Size

Total Lines	38
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	38
rs	8.8571
cc	1
eloc	22
nc	1
nop	0

<?php

namespace App\Controllers;

use App\Components\Controller;
use App\Components\View;
use App\Models\LoginFormModel;
use Micro\Form\FormBuilder;
use Micro\Web\Html;

/**
 * Class DefaultController
 * @package App\Controllers
 */
class DefaultController extends Controller
{
    public function filters()
    {
        return [
            [
                'class' => '\Micro\Filter\AccessFilter',
                'actions' => ['login', 'logout', 'index'],
                'rules' => [
                    [
                        'allow' => false,
                        'actions' => ['index'],
                        'users' => ['@'],
                        'message' => 'Only for not authorized!'
                    ],
                    [
                        'allow' => false,
                        'actions' => ['login'],
                        'users' => ['@'],
                        'message' => 'Not authorized only'
                    ],
                    [
                        'allow' => false,
                        'actions' => ['logout'],
                        'users' => ['?'],
                        'message' => 'Authorized only'
                    ]
                ]
            ],
            [
                'class' => '\Micro\Filter\CsrfFilter',
                'actions' => ['login']
            ],
            [
                'class' => '\Micro\Filter\XssFilter',
                'actions' => ['index', 'login', 'logout'],
                'clean' => '*'
            ]
        ];
    }

    public function actionIndex()
    {
        return new View($this->container);
    }

    public function actionLogin()
    {
        /** @noinspection PhpIncludeInspection */
        $form = new FormBuilder(
            include $this->container->kernel->getAppDir() . '/views/default/loginform.php',
            new LoginFormModel($this->container),
            'POST'
        );

        if ($post = $this->container->request->post('LoginFormModel')) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $form->setModelData($post);
            /** @noinspection PhpUndefinedMethodInspection */
            if ($form->validateModel() && $form->getModel()->logined()) {

                $this->redirect('/profile');
            }
        }

        $v = new View($this->container);
        $v->addParameter('form', $form);

        return $v;
    }

    public function actionError()
    {
        $result = null;
        /** @var \Micro\Base\Exception $error */
        if ($error = $this->container->request->post('error')) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $result .= Html::heading(3, $error->getMessage(), ['class' => 'text-danger bg-danger']);
        }
        $v = new View($this->container);
        $v->data = $result ?: 'undefined error';

        return $v;
    }

    public function actionLogout()
    {
        $this->container->session->destroy();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->redirect('/');
    }
}


1			<?php
2
3			namespace App\Controllers;
4
5			use App\Components\Controller;
6			use App\Components\View;
7			use App\Models\LoginFormModel;
8			use Micro\Form\FormBuilder;
9			use Micro\Web\Html;
10
11			/**
12			* Class DefaultController
13			* @package App\Controllers
14			*/
15			class DefaultController extends Controller
16			{
17			public function filters()
18			{
19			return [
20			[
21			'class' => '\Micro\Filter\AccessFilter',
22			'actions' => ['login', 'logout', 'index'],
23			'rules' => [
24			[
25			'allow' => false,
26			'actions' => ['index'],
27			'users' => ['@'],
28			'message' => 'Only for not authorized!'
29			],
30			[
31			'allow' => false,
32			'actions' => ['login'],
33			'users' => ['@'],
34			'message' => 'Not authorized only'
35			],
36			[
37			'allow' => false,
38			'actions' => ['logout'],
39			'users' => ['?'],
40			'message' => 'Authorized only'
41			]
42			]
43			],
44			[
45			'class' => '\Micro\Filter\CsrfFilter',
46			'actions' => ['login']
47			],
48			[
49			'class' => '\Micro\Filter\XssFilter',
50			'actions' => ['index', 'login', 'logout'],
51			'clean' => '*'
52			]
53			];
54			}
55
56			public function actionIndex()
57			{
58			return new View($this->container);
59			}
60
61			public function actionLogin()
62			{
63			/** @noinspection PhpIncludeInspection */
64			$form = new FormBuilder(
65			include $this->container->kernel->getAppDir() . '/views/default/loginform.php',
66			new LoginFormModel($this->container),
67			'POST'
68			);
69
70			if ($post = $this->container->request->post('LoginFormModel')) {
			0 ignored issues – show Bug introduced 2016-03-13 00:17 UTC by Report Bug Copy Issue Report Accessing `request` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
71			$form->setModelData($post);
72			/** @noinspection PhpUndefinedMethodInspection */
73			if ($form->validateModel() && $form->getModel()->logined()) {
			0 ignored issues – show Bug introduced 2016-03-13 00:17 UTC by Report Bug Copy Issue Report The method `logined()` does not seem to exist on `object<Micro\Mvc\Models\Model>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
74			$this->redirect('/profile');
75			}
76			}
77
78			$v = new View($this->container);
79			$v->addParameter('form', $form);
80
81			return $v;
82			}
83
84			public function actionError()
85			{
86			$result = null;
87			/** @var \Micro\Base\Exception $error */
88			if ($error = $this->container->request->post('error')) {
			0 ignored issues – show Bug introduced 2016-03-13 00:17 UTC by Report Bug Copy Issue Report Accessing `request` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
89			$result .= Html::heading(3, $error->getMessage(), ['class' => 'text-danger bg-danger']);
90			}
91			$v = new View($this->container);
92			$v->data = $result ?: 'undefined error';
93
94			return $v;
95			}
96
97			public function actionLogout()
98			{
99			$this->container->session->destroy();
			0 ignored issues – show Bug introduced 2016-03-13 00:17 UTC by Report Bug Copy Issue Report Accessing `session` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
100			$this->redirect('/');
101			}
102			}
103

lugnsk / micro

Push — master ( d6bb8e...21b718 )

DefaultController::filters() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like