View::__construct() - Code Metrics - Inspection of "add template" - lugnsk/micro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6bb8e...21b718 )

by Oleg

created 2016-03-13 00:12 UTC

View::__construct() A

↳ Parent: View

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	12
rs	9.4285
cc	2
eloc	8
nc	2
nop	1

<?php

namespace App\Components;

use Micro\Base\IContainer;
use Micro\Mvc\Views\PhpView;

/**
 * Class View
 *
 * @package App\Components
 */
class View extends PhpView
{
    public $title = 'Micro';
    public $menu = ['<a href="/">Главная</a>', '<a href="/blog/post">Блог</a>'];
    public $user = [];

    /**
     * View constructor.
     * @param IContainer $container
     */
    public function __construct(IContainer $container)
    {
        parent::__construct($container);

        if (!$this->container->user->isGuest()) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $this->user[] = '<a href="/profile">Профиль</a>';
            $this->user[] = ' (<a href="/logout">Выйти</a>)';
        } else {
            $this->user[] = '<a href="/login">Войти</a>';
            $this->user[] = '<a href="/register">Регистрация</a>';
        }
    }
} 


1			<?php
2
3			namespace App\Components;
4
5			use Micro\Base\IContainer;
6			use Micro\Mvc\Views\PhpView;
7
8			/**
9			* Class View
10			*
11			* @package App\Components
12			*/
13			class View extends PhpView
14			{
15			public $title = 'Micro';
16			public $menu = ['<a href="/">Главная</a>', '<a href="/blog/post">Блог</a>'];
17			public $user = [];
18
19			/**
20			* View constructor.
21			* @param IContainer $container
22			*/
23			public function __construct(IContainer $container)
24			{
25			parent::__construct($container);
26
27			if (!$this->container->user->isGuest()) {
			0 ignored issues – show Bug introduced 2016-03-13 00:17 UTC by Report Bug Copy Issue Report Accessing `user` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
28			$this->user[] = '<a href="/profile">Профиль</a>';
29			$this->user[] = ' (<a href="/logout">Выйти</a>)';
30			} else {
31			$this->user[] = '<a href="/login">Войти</a>';
32			$this->user[] = '<a href="/register">Регистрация</a>';
33			}
34			}
35			}
36

lugnsk / micro

Push — master ( d6bb8e...21b718 )

View::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like