Console::action() - Code Metrics - Inspection of "CamelCase namespaces + bug fixes" - lugnsk/micro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 579af5...b29473 )

by Oleg

created 2016-02-08 20:56 UTC

Console::action() A

↳ Parent: Console

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	0
loc	15
rs	9.4285
c	1
b	1
f	0
cc	3
eloc	8
nc	4
nop	1

<?php /** MicroConsole */

namespace Micro\Cli;

use Micro\Base\IContainer;

/**
 * Console class file.
 *
 * @author Oleg Lunegov <[email protected]>
 * @link https://github.com/lugnsk/micro
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Cli
 * @version 1.0
 * @since 1.0
 * @abstract
 */
class Console
{
    /** @var IContainer $container */
    protected $container;
    /** @var string $command Parsed command */
    protected $command;
    /** @var array $args Arguments from params */
    protected $args = [];

    /**
     * Constructor command
     *
     * @access public
     *
     * @param IContainer $container
     *
     * @result void
     */
    public function __construct(IContainer $container)
    {
        $this->container = $container;

        foreach ($container->request->getArguments() AS $param) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            if ($pos = strpos($param, '=')) {
                $this->args[substr($param, 0, $pos)] = substr($param, $pos + 1);
            }
        }
    }

    /**
     * Run action of console command by name
     *
     * @access public
     *
     * @param string $name Command name
     *
     * @return bool|ConsoleCommand|string
     */
    public function action($name)
    {
        $command = '\\Micro\\Cli\\Consoles\\' . $name . 'ConsoleCommand';
        $command = class_exists($command) ? $command : '\\App\\Consoles\\' . $name . 'ConsoleCommand';

        if (!class_exists($command)) {
            return false;
        }

        /** @var ConsoleCommand $command */
        $command = new $command (['container' => $this->container, 'args' => $this->args]);
        $command->execute();

        return $command;
    }
}


1			<?php /** MicroConsole */
2
3			namespace Micro\Cli;
4
5			use Micro\Base\IContainer;
6
7			/**
8			* Console class file.
9			*
10			* @author Oleg Lunegov <[email protected]>
11			* @link https://github.com/lugnsk/micro
12			* @copyright Copyright © 2013 Oleg Lunegov
13			* @license /LICENSE
14			* @package Micro
15			* @subpackage Cli
16			* @version 1.0
17			* @since 1.0
18			* @abstract
19			*/
20			class Console
21			{
22			/** @var IContainer $container */
23			protected $container;
24			/** @var string $command Parsed command */
25			protected $command;
26			/** @var array $args Arguments from params */
27			protected $args = [];
28
29			/**
30			* Constructor command
31			*
32			* @access public
33			*
34			* @param IContainer $container
35			*
36			* @result void
37			*/
38			public function __construct(IContainer $container)
39			{
40			$this->container = $container;
41
42			foreach ($container->request->getArguments() AS $param) {
			0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `request` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
43			if ($pos = strpos($param, '=')) {
44			$this->args[substr($param, 0, $pos)] = substr($param, $pos + 1);
45			}
46			}
47			}
48
49			/**
50			* Run action of console command by name
51			*
52			* @access public
53			*
54			* @param string $name Command name
55			*
56			* @return bool\|ConsoleCommand\|string
57			*/
58			public function action($name)
59			{
60			$command = '\\Micro\\Cli\\Consoles\\' . $name . 'ConsoleCommand';
61			$command = class_exists($command) ? $command : '\\App\\Consoles\\' . $name . 'ConsoleCommand';
62
63			if (!class_exists($command)) {
64			return false;
65			}
66
67			/** @var ConsoleCommand $command */
68			$command = new $command (['container' => $this->container, 'args' => $this->args]);
69			$command->execute();
70
71			return $command;
72			}
73			}
74

lugnsk / micro

Push — master ( 579af5...b29473 )

Console::action() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like