MemcachedCache::__construct() - Code Metrics - Inspection of "CamelCase namespaces + bug fixes" - lugnsk/micro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 579af5...b29473 )

by Oleg

created 2016-02-08 20:56 UTC

MemcachedCache::__construct() C

↳ Parent: MemcachedCache

Complexity

Conditions	11
Paths	38

Size

Total Lines	40
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	40
rs	5.2653
cc	11
eloc	27
nc	38
nop	1

How to fix Complexity

<?php /** MicroMemcachedCache */

namespace Micro\Cache;

use Micro\Base\Exception;

/**
 * Class MemcachedCache
 *
 * @author Oleg Lunegov <[email protected]>
 * @link https://github.com/lugnsk/micro
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Cache
 * @version 1.0
 * @since 1.0
 */
class MemcachedCache extends BaseCache
{
    /** @var \Memcache|\Memcached $driver driver memcache(d) */
    protected $driver;

    /**
     * Constructor
     *
     * @access public
     *
     * @param array $config config array
     *
     * @result void
     * @throws Exception
     */
    public function __construct(array $config = [])
    {
        parent::__construct($config);

        if (empty($config['type']) || !$this->check()) {
            throw new Exception('Memcache(d) not installed or not select type');
        }

        switch (strtolower($config['type'])) {
            case 'memcached':
                $this->driver = new \Memcached;
                break;

            case 'memcache':
                $this->driver = new \Memcache;
                break;

            default:
                throw new Exception('Selected type not valid in the driver');
        }

        if (!empty($config['servers'])) {
            $this->driver->addServers($config['servers']);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        } elseif ($config['server']) {
            $conf = $config['server'];
            $server = [
                'hostname' => (!empty($conf['hostname']) ? $conf['hostname'] : '127.0.0.1'),
                'port' => (!empty($conf['port']) ? $conf['port'] : 11211),
                'weight' => (!empty($conf['weight']) ? $conf['weight'] : 1)
            ];

            if (get_class($this->driver) === 'Memcached') {
                $this->driver->addServer($server['hostname'], $server['port'], $server['weight']);
            } else {
                $this->driver->addServer($server['hostname'], $server['port'], true, $server['weight']);
            }
        } else {
            throw new Exception('Server(s) not configured');
        }
    }

    /**
     * @inheritdoc
     */
    public function check()
    {
        return (!extension_loaded('memcached') && !extension_loaded('memcache')) ?: true;
    }

    /**
     * Destructor
     *
     * @access public
     * @result void
     */
    public function __destruct()
    {
        if ($this->driver) {
            $this->driver->close();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }
    }

    /**
     * @inheritdoc
     */
    public function get($name)
    {
        $data = $this->driver->get($name);

        return is_array($data) ? $data[0] : $data;
    }

    /**
     * @inheritdoc
     */
    public function set($name, $value, $duration = 0)
    {
        switch (get_class($this->driver)) {
            case 'Memcached':
                return $this->driver->set($name, $value, $duration);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'Memcache':
                return $this->driver->set($name, $value, 0, $duration);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            default:
                return false;
        }
    }

    /**
     * @inheritdoc
     */
    public function delete($name)
    {
        return $this->driver->delete($name);
    }

    /**
     * @inheritdoc
     */
    public function clean()
    {
        return $this->driver->flush();
    }

    /**
     * @inheritdoc
     */
    public function info()
    {
        return $this->driver->getStats();
    }

    /**
     * @inheritdoc
     */
    public function getMeta($id)
    {
        $stored = $this->driver->get($id);
        if (count($stored) !== 3) {
            return false;
        }

        list($data, $time, $ttl) = $stored;

        return ['expire' => $time + $ttl, 'mtime' => $time, 'data' => $data];
    }

    /**
     * @inheritdoc
     */
    public function increment($name, $offset = 1)
    {
        return $this->driver->increment($name, $offset);
    }

    /**
     * @inheritdoc
     */
    public function decrement($name, $offset = 1)
    {
        return $this->driver->decrement($name, $offset);
    }
}


1			<?php /** MicroMemcachedCache */
2
3			namespace Micro\Cache;
4
5			use Micro\Base\Exception;
6
7			/**
8			* Class MemcachedCache
9			*
10			* @author Oleg Lunegov <[email protected]>
11			* @link https://github.com/lugnsk/micro
12			* @copyright Copyright © 2013 Oleg Lunegov
13			* @license /LICENSE
14			* @package Micro
15			* @subpackage Cache
16			* @version 1.0
17			* @since 1.0
18			*/
19			class MemcachedCache extends BaseCache
20			{
21			/** @var \Memcache\|\Memcached $driver driver memcache(d) */
22			protected $driver;
23
24			/**
25			* Constructor
26			*
27			* @access public
28			*
29			* @param array $config config array
30			*
31			* @result void
32			* @throws Exception
33			*/
34			public function __construct(array $config = [])
35			{
36			parent::__construct($config);
37
38			if (empty($config['type']) \|\| !$this->check()) {
39			throw new Exception('Memcache(d) not installed or not select type');
40			}
41
42			switch (strtolower($config['type'])) {
43			case 'memcached':
44			$this->driver = new \Memcached;
45			break;
46
47			case 'memcache':
48			$this->driver = new \Memcache;
49			break;
50
51			default:
52			throw new Exception('Selected type not valid in the driver');
53			}
54
55			if (!empty($config['servers'])) {
56			$this->driver->addServers($config['servers']);
			0 ignored issues – show Bug introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report The method `addServers` does only exist in `Memcached`, but not in `Memcache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
57			} elseif ($config['server']) {
58			$conf = $config['server'];
59			$server = [
60			'hostname' => (!empty($conf['hostname']) ? $conf['hostname'] : '127.0.0.1'),
61			'port' => (!empty($conf['port']) ? $conf['port'] : 11211),
62			'weight' => (!empty($conf['weight']) ? $conf['weight'] : 1)
63			];
64
65			if (get_class($this->driver) === 'Memcached') {
66			$this->driver->addServer($server['hostname'], $server['port'], $server['weight']);
67			} else {
68			$this->driver->addServer($server['hostname'], $server['port'], true, $server['weight']);
69			}
70			} else {
71			throw new Exception('Server(s) not configured');
72			}
73			}
74
75			/**
76			* @inheritdoc
77			*/
78			public function check()
79			{
80			return (!extension_loaded('memcached') && !extension_loaded('memcache')) ?: true;
81			}
82
83			/**
84			* Destructor
85			*
86			* @access public
87			* @result void
88			*/
89			public function __destruct()
90			{
91			if ($this->driver) {
92			$this->driver->close();
			0 ignored issues – show Bug introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report The method `close` does only exist in `Memcache`, but not in `Memcached`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
93			}
94			}
95
96			/**
97			* @inheritdoc
98			*/
99			public function get($name)
100			{
101			$data = $this->driver->get($name);
102
103			return is_array($data) ? $data[0] : $data;
104			}
105
106			/**
107			* @inheritdoc
108			*/
109			public function set($name, $value, $duration = 0)
110			{
111			switch (get_class($this->driver)) {
112			case 'Memcached':
113			return $this->driver->set($name, $value, $duration);
114			break;
			0 ignored issues – show Unused Code introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
115
116			case 'Memcache':
117			return $this->driver->set($name, $value, 0, $duration);
118			break;
			0 ignored issues – show Unused Code introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
119
120			default:
121			return false;
122			}
123			}
124
125			/**
126			* @inheritdoc
127			*/
128			public function delete($name)
129			{
130			return $this->driver->delete($name);
131			}
132
133			/**
134			* @inheritdoc
135			*/
136			public function clean()
137			{
138			return $this->driver->flush();
139			}
140
141			/**
142			* @inheritdoc
143			*/
144			public function info()
145			{
146			return $this->driver->getStats();
147			}
148
149			/**
150			* @inheritdoc
151			*/
152			public function getMeta($id)
153			{
154			$stored = $this->driver->get($id);
155			if (count($stored) !== 3) {
156			return false;
157			}
158
159			list($data, $time, $ttl) = $stored;
160
161			return ['expire' => $time + $ttl, 'mtime' => $time, 'data' => $data];
162			}
163
164			/**
165			* @inheritdoc
166			*/
167			public function increment($name, $offset = 1)
168			{
169			return $this->driver->increment($name, $offset);
170			}
171
172			/**
173			* @inheritdoc
174			*/
175			public function decrement($name, $offset = 1)
176			{
177			return $this->driver->decrement($name, $offset);
178			}
179			}
180

lugnsk / micro

Push — master ( 579af5...b29473 )

MemcachedCache::__construct() C

Complexity

Size

Duplication

How to fix Complexity

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like