DbRbac::check() - Code Metrics - Inspection of "CamelCase namespaces + bug fixes" - lugnsk/micro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 579af5...b29473 )

by Oleg

created 2016-02-08 20:56 UTC

DbRbac::check() A

↳ Parent: DbRbac

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	8
rs	9.4285
cc	2
eloc	4
nc	2
nop	3

<?php /** MicroDbRBAC */

namespace Micro\Auth;

use Micro\Mvc\Models\Query;

/**
 * Database RBAC class file.
 *
 * RBAC security logic with DB
 *
 * @author Oleg Lunegov <[email protected]>
 * @link https://github.com/lugnsk/micro
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Auth
 * @version 1.0
 * @since 1.0
 */
class DbRbac extends Rbac
{
    /**
     * Constructor file RBAC
     *
     * @inheritdoc
     */
    public function __construct(array $params = [])
    {
        parent::__construct($params);

        if (!$this->container->db->tableExists('rbac_role')) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $this->container->db->createTable('rbac_role', [
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                '`name` varchar(127) NOT NULL',
                '`type` int(11) NOT NULL DEFAULT \'0\'',
                '`based` varchar(127)',
                '`data` text',
                'UNIQUE KEY `name` (`name`)'
            ], 'ENGINE=MyISAM DEFAULT CHARSET=utf8');
        }
    }

    /**
     * Assign RBAC element into user
     *
     * @access public
     *
     * @param integer $userId user ID
     * @param string $name assign element name
     *
     * @return bool
     */
    public function assign($userId, $name)
    {
        if ($this->container->db->exists('rbac_role', ['name' => $name]) && $this->container->db->exists('user',
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                ['id' => $userId])
        ) {
            return $this->container->db->insert('rbac_user', ['role' => $name, 'user' => $userId]);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        }

        return false;
    }

    /**
     * Check privileges to operation
     *
     * @access public
     *
     * @param integer $userId user id
     * @param string $action checked action
     * @param array $data action params
     *
     * @return boolean
     * @throws \Micro\Base\Exception
     */
    public function check($userId, $action, array $data = [])
    {
        if (!$this->container->db->exists('rbac_role', ['name' => $action])) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return false;
        }

        return parent::check($userId, $action, $data);
    }

    /**
     * Add new element into RBAC rules
     *
     * @access public
     *
     * @param string $name element name
     * @param int $type element type
     * @param string $based based element name
     * @param string $data element params
     *
     * @return bool
     */
    public function create($name, $type = self::TYPE_ROLE, $based = null, $data = null)
    {
        if ($this->container->db->exists('rbac_role', ['name' => $name])) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return false;
        }

        if (null !== $based && !$this->container->db->exists('rbac_role', ['name' => $based])) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return false;
        }

        switch ($type) {
            case Rbac::TYPE_ROLE:
            case Rbac::TYPE_OPERATION:
            case Rbac::TYPE_PERMISSION:
                break;
            default:
                return false;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }

        return $this->container->db->insert('rbac_role',
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ['name' => $name, 'type' => $type, 'based' => $based, 'data' => $data]);
    }

    /**
     * Delete element from RBAC rules
     *
     * @access public
     *
     * @param string $name element name
     *
     * @result void
     * @throws \Micro\Base\Exception
     */
    public function delete($name)
    {
        $tree = $this->searchRoleRecursive($this->tree($this->rawRoles()), $name);

        if ($tree) {
            $this->recursiveDelete($tree);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }
    }

    /**
     * Get raw roles
     *
     * @access public
     *
     * @param int $pdo PHPDataObject fetch key
     *
     * @return mixed
     * @throws \Micro\Base\Exception
     */
    public function rawRoles($pdo = \PDO::FETCH_ASSOC)
    {
        $query = new Query($this->container->db);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $query->table = 'rbac_role';
        $query->order = '`type` ASC';
        $query->single = false;

        return $query->run($pdo);
    }

    /**
     * Recursive delete roles from array
     *
     * @access public
     *
     * @param array $tree elements tree
     *
     * @return void
     */
    public function recursiveDelete(&$tree)
    {
        foreach ($tree AS $key => $element) {
            $this->container->db->delete('rbac_user', 'role=:name', ['name' => $element['name']]);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $this->container->db->delete('rbac_role', 'name=:name', ['name' => $element['name']]);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

            if (!empty($tree['childs'])) {
                $this->recursiveDelete($element['childs']);
            }
            unset($tree[$key]);
        }
    }
}


1		<?php /** MicroDbRBAC */
2
3		namespace Micro\Auth;
4
5		use Micro\Mvc\Models\Query;
6
7		/**
8		* Database RBAC class file.
9		*
10		* RBAC security logic with DB
11		*
12		* @author Oleg Lunegov <[email protected]>
13		* @link https://github.com/lugnsk/micro
14		* @copyright Copyright © 2013 Oleg Lunegov
15		* @license /LICENSE
16		* @package Micro
17		* @subpackage Auth
18		* @version 1.0
19		* @since 1.0
20		*/
21		class DbRbac extends Rbac
22		{
23		/**
24		* Constructor file RBAC
25		*
26		* @inheritdoc
27		*/
28		public function __construct(array $params = [])
29		{
30		parent::__construct($params);
31
32	View Code Duplication	if (!$this->container->db->tableExists('rbac_role')) {
		0 ignored issues – show Duplication introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
33		$this->container->db->createTable('rbac_role', [
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
34		'`name` varchar(127) NOT NULL',
35		'`type` int(11) NOT NULL DEFAULT \'0\'',
36		'`based` varchar(127)',
37		'`data` text',
38		'UNIQUE KEY `name` (`name`)'
39		], 'ENGINE=MyISAM DEFAULT CHARSET=utf8');
40		}
41		}
42
43		/**
44		* Assign RBAC element into user
45		*
46		* @access public
47		*
48		* @param integer $userId user ID
49		* @param string $name assign element name
50		*
51		* @return bool
52		*/
53		public function assign($userId, $name)
54		{
55		if ($this->container->db->exists('rbac_role', ['name' => $name]) && $this->container->db->exists('user',
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
56		['id' => $userId])
57		) {
58		return $this->container->db->insert('rbac_user', ['role' => $name, 'user' => $userId]);
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
59		}
60
61		return false;
62		}
63
64		/**
65		* Check privileges to operation
66		*
67		* @access public
68		*
69		* @param integer $userId user id
70		* @param string $action checked action
71		* @param array $data action params
72		*
73		* @return boolean
74		* @throws \Micro\Base\Exception
75		*/
76		public function check($userId, $action, array $data = [])
77		{
78		if (!$this->container->db->exists('rbac_role', ['name' => $action])) {
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
79		return false;
80		}
81
82		return parent::check($userId, $action, $data);
83		}
84
85		/**
86		* Add new element into RBAC rules
87		*
88		* @access public
89		*
90		* @param string $name element name
91		* @param int $type element type
92		* @param string $based based element name
93		* @param string $data element params
94		*
95		* @return bool
96		*/
97		public function create($name, $type = self::TYPE_ROLE, $based = null, $data = null)
98		{
99		if ($this->container->db->exists('rbac_role', ['name' => $name])) {
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
100		return false;
101		}
102
103		if (null !== $based && !$this->container->db->exists('rbac_role', ['name' => $based])) {
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
104		return false;
105		}
106
107		switch ($type) {
108		case Rbac::TYPE_ROLE:
109		case Rbac::TYPE_OPERATION:
110		case Rbac::TYPE_PERMISSION:
111		break;
112		default:
113		return false;
114		break;
		0 ignored issues – show Unused Code introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
115		}
116
117		return $this->container->db->insert('rbac_role',
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
118		['name' => $name, 'type' => $type, 'based' => $based, 'data' => $data]);
119		}
120
121		/**
122		* Delete element from RBAC rules
123		*
124		* @access public
125		*
126		* @param string $name element name
127		*
128		* @result void
129		* @throws \Micro\Base\Exception
130		*/
131		public function delete($name)
132		{
133		$tree = $this->searchRoleRecursive($this->tree($this->rawRoles()), $name);
		0 ignored issues – show Bug introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report `$this->rawRoles()` cannot be passed to `tree()` as the parameter `$elements` expects a reference. Loading history...
134		if ($tree) {
135		$this->recursiveDelete($tree);
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report It seems like `$tree` defined by `$this->searchRoleRecursi...is->rawRoles()), $name)` on line `133` can also be of type `boolean`; however, `Micro\Auth\DbRbac::recursiveDelete()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
136		}
137		}
138
139		/**
140		* Get raw roles
141		*
142		* @access public
143		*
144		* @param int $pdo PHPDataObject fetch key
145		*
146		* @return mixed
147		* @throws \Micro\Base\Exception
148		*/
149		public function rawRoles($pdo = \PDO::FETCH_ASSOC)
150		{
151		$query = new Query($this->container->db);
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
152		$query->table = 'rbac_role';
153		$query->order = '`type` ASC';
154		$query->single = false;
155
156		return $query->run($pdo);
157		}
158
159		/**
160		* Recursive delete roles from array
161		*
162		* @access public
163		*
164		* @param array $tree elements tree
165		*
166		* @return void
167		*/
168		public function recursiveDelete(&$tree)
169		{
170		foreach ($tree AS $key => $element) {
171		$this->container->db->delete('rbac_user', 'role=:name', ['name' => $element['name']]);
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
172		$this->container->db->delete('rbac_role', 'name=:name', ['name' => $element['name']]);
		0 ignored issues – show Bug introduced 2016-02-08 21:03 UTC by Report Bug Copy Issue Report Accessing `db` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
173
174		if (!empty($tree['childs'])) {
175		$this->recursiveDelete($element['childs']);
176		}
177		unset($tree[$key]);
178		}
179		}
180		}
181

lugnsk / micro

Push — master ( 579af5...b29473 )

DbRbac::check() A

Complexity

Size

Duplication

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like