Micro\Filter\AccessFilter

Complexity

Total Complexity

45

Size/Duplication

Total Lines	219
Duplicated Lines	20.55 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	1	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
B	pre()	8	21	7
B	checkRule()	0	14	6
A	matchAction()	0	12	3
D	matchUser()	0	36	10
B	matchRole()	18	18	5
B	matchIP()	0	20	8
B	matchVerb()	19	20	5
A	post()	0	4	1

<?php /** AccessFilterMicro */

namespace Micro\Filter;

/**
 * Class AccessFilter
 *
 * @author Oleg Lunegov <testuser@mail.linpax.org>
 * @link https://github.com/lugnsk/micro
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Filter
 * @version 1.0
 * @since 1.0
 */
class AccessFilter extends Filter
{
    /**
     * @inheritdoc
     */
    public function pre(array $params)
    {
        foreach ($params['rules'] AS $rule) {
            $res = $this->checkRule($rule);

            if ($res === true) {
                return true;
            } elseif ($res === false) {

This code seems to be duplicated across your project.

                $this->result = [
                    'redirect' => !empty($rule['redirect']) ? $rule['redirect'] : null,
                    'message' => !empty($rule['message']) ? $rule['message'] : 'Access denied!'
                ];

                return false;
            } elseif ($res === null) {
                continue;
            }
        }

        return true;
    }

    /**
     * Check one rule
     *
     * @access protected
     *
     * @param array $rule rule definition
     *
     * @return bool|null
     */
    protected function checkRule(array $rule)
    {
        if (
            $this->matchAction($rule)
            && $this->matchUser($rule)
            && $this->matchRole($rule)
            && $this->matchIP($rule)
            && $this->matchVerb($rule)
        ) {
            return $rule['allow'];
        } else {
            return null;
        }
    }

    /**
     * Match action
     *
     * @access protected
     *
     * @param array $rule rule definition
     *
     * @return bool
     */
    protected function matchAction($rule)
    {
        if (empty($rule['actions'])) {
            return true;
        }

        if (is_array($rule['actions'])) {
            return in_array($this->action, $rule['actions'], true);
        }

        return $this->action === $rule['actions'];
    }

    /**
     * Match user
     *
     * @access protected
     * @global Container
     *
     * @param array $rule rule definition
     *
     * @return bool
     */
    protected function matchUser($rule)
    {
        if (empty($rule['users'])) {
            return true;
        }

        if (!is_array($rule['users'])) {
            $rule['users'][] = $rule['users'];
        }

        foreach ($rule['users'] AS $u) {
            switch ($u) {
                case '*':
                    return true;

                case '?':
                    if ($this->container->user->isGuest()) {

Accessing user on the interface Micro\Base\IContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

                        return true;
                    }
                    break;

                case '@':
                    if (!$this->container->user->isGuest()) {

Accessing user on the interface Micro\Base\IContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

                        return true;
                    }
                    break;

                default:
                    if ($this->container->user->getID() === $u) {

Accessing user on the interface Micro\Base\IContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

                        return true;
                    }
            }
        }

        return false;
    }

    /**
     * Match role
     *
     * @access protected
     * @global Container
     *
     * @param array $rule rule definition
     *
     * @return bool
     */
    protected function matchRole($rule)

This method seems to be duplicated in your project.

    {
        if (empty($rule['roles'])) {
            return true;
        }

        if (!is_array($rule['roles'])) {
            $rule['roles'][] = $rule['roles'];
        }

        foreach ($rule['roles'] AS $role) {
            if ($this->container->user->check($role)) {

Accessing user on the interface Micro\Base\IContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

                return true;
            }
        }

        return false;
    }

    /**
     * Match IP
     *
     * @access protected
     * @global Container
     *
     * @param array $rule rule definition
     *
     * @return bool
     */
    protected function matchIP($rule)
    {
        if (empty($rule['ips'])) {
            return true;
        }

        if (!is_array($rule['ips'])) {
            $rule['ips'][] = $rule['ips'];
        }

        $userIp = $this->container->request->getUserIP();

Accessing request on the interface Micro\Base\IContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

        foreach ($rule['ips'] AS $r) {
            if ($r === '*' || $r === $userIp || (($pos = strpos($r, '*')) !== false && !strncmp($userIp, $r, $pos))) {
                return true;
            }
        }

        return false;
    }

    /**
     * Match verbose
     *
     * @access protected
     * @global Container
     *
     * @param array $rule rule definition
     *
     * @return bool
     */
    protected function matchVerb($rule)

This method seems to be duplicated in your project.

    {
        if (empty($rule['verb'])) {
            return true;
        }

        if (!is_array($rule['verb'])) {
            $rule['verb'][] = $rule['verb'];
        }

        $verb = $this->container->request->getMethod();

Accessing request on the interface Micro\Base\IContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

        foreach ($rule['verb'] AS $v) {
            if ($v === $verb) {
                return true;
            }
        }

        return false;
    }

    /**
     * @inheritdoc
     */
    public function post(array $params)
    {
        return $params['data'];
    }
}