Micro\Mvc\Controllers\RichController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	118
Duplicated Lines	5.93 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
C	action()	7	40	8
	actionsTypes()	0	1	?
B	switchContentType()	0	17	5

<?php /** MicroRichController */

namespace Micro\Mvc\Controllers;

use Micro\Base\IContainer;

/**
 * Class RichController
 *
 * @author Oleg Lunegov <testuser@mail.linpax.org>
 * @link https://github.com/lugnsk/micro
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Mvc\Controllers
 * @version 1.0
 * @since 1.0
 * @abstract
 */
abstract class RichController extends Controller
{
    /** @var string $format Format for response */
    public $format = 'application/json';
    /** @var string $methodType */
    protected $methodType = 'get';


    /**
     * Construct RICH controller
     *
     * @access public
     *
     * @param IContainer $container
     * @param string $modules
     *
     * @result void
     */
    public function __construct(IContainer $container, $modules = '')
    {
        parent::__construct($container, $modules);

        $this->methodType = $this->container->request->getMethod() ?: 'GET';

Accessing request on the interface Micro\Base\IContainer suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * @inheritdoc
     */
    public function action($name = 'index')
    {
        $actionClass = false;
        if (!method_exists($this, 'action' . ucfirst($name)) && !$actionClass = $this->getActionClassByName($name)) {
            $this->response->setStatus(500, 'Action "' . $name . '" not found into ' . get_class($this));

            return $this->response;
        }

        $types = $this->actionsTypes();

        if (!empty($types[$name]) && $this->methodType !== $types[$name]) {
            $this->response->setStatus(500,
                'Action "' . $name . '" not run with method "' . $this->methodType . '" into ' . get_class($this)
            );

            return $this->response;
        }

        $filters = method_exists($this, 'filters') ? $this->filters() : [];

The method filters() does not exist on Micro\Mvc\Controllers\RichController. Did you maybe mean applyFilters()?

        $this->applyFilters($name, true, $filters, null);

        $view = null;

$view is not used, you could remove the assignment.

        if ($actionClass) {

This code seems to be duplicated across your project.

            /** @var \Micro\Mvc\Action $cl */
            $cl = new $actionClass ($this->container);
            $view = $cl->run();
        } else {
            $view = $this->{'action' . ucfirst($name)}();
        }

        if ($this->response->getContentType() !== $this->format) {
            $this->response->setContentType($this->format);
        }

        $this->response->setBody($this->switchContentType($this->applyFilters($name, false, $filters, $view)));

        return $this->response;
    }

    /**
     * Define types for actions
     *
     * <code>
     *  // DELETE, GET, HEAD, OPTIONS, POST, PUT
     * public function actionsTypes() {
     *  return [
     *     'create' => 'POST',
     *     'read'   => 'GET',
     *     'update' => 'UPDATE'
     *     'delete' => 'DELETE'
     *  ];
     * }
     * </code>
     *
     * @access public
     *
     * @return array
     * @abstract
     */
    abstract public function actionsTypes();

    /**
     * Switch content type
     *
     * @access protected
     *
     * @param mixed $data Any content
     *
     * @return string
     */
    protected function switchContentType($data)
    {
        switch ($this->format) {
            case 'application/json':
                $data = json_encode(is_object($data) ? (array)$data : $data);
                break;

            case 'application/xml':
                $data = is_object($data) ? (string)$data : $data;
                break;

            default:
                $data = (string)$data;
        }

        return $data;
    }
}