Dispatcher::signal() - Code Metrics - Inspection of "Patch Resolver" - lugnsk/micro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f7ee5f...7c37a7 )

by Oleg

created 2016-03-06 15:05 UTC

Dispatcher::signal() B

↳ Parent: Dispatcher

Complexity

Conditions	5
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	16
rs	8.8571
cc	5
eloc	8
nc	3
nop	2

<?php /** MicroDispatcher */

namespace Micro\Base;

use Micro\Web\IResponse;

/**
 * Dispatcher class file.
 *
 * @author Oleg Lunegov <[email protected]>
 * @link https://github.com/lugnsk/micro
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Base
 * @version 1.0
 * @since 1.0
 */
class Dispatcher implements IDispatcher
{
    /** @var array $listeners listeners objects on events */
    protected $listeners = [];

    /**
     * Add listener on event
     *
     * @access public
     *
     * @param string $listener listener name
     * @param array $event ['Object', 'method'] or callable
     * @param int|null $prior priority
     *
     * @return bool
     */
    public function addListener($listener, $event, $prior = null)
    {
        if (!is_callable($event)) {
            return false;
        }

        if (!array_key_exists($listener, $this->listeners)) {
            $this->listeners[$listener] = [];
        }

        if (!$prior) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $this->listeners[$listener][] = $event;
        } else {
            array_splice($this->listeners[$listener], $prior, 0, $event);
        }

        return true;
    }

    /**
     * Send signal to run event
     *
     * @access public
     *
     * @param string $listener listener name
     * @param array $params Signal parameters
     *
     * @return mixed
     */
    public function signal($listener, array $params = [])
    {
        $result = null;

        if ($this->listeners && array_key_exists($listener, $this->listeners)) {

            foreach ($this->listeners[$listener] as $listen) {
                $result = call_user_func($listen, $params);

                if ($result instanceof IResponse) {
                    return $result;
                }
            }
        }

        return $result;
    }
}


1			<?php /** MicroDispatcher */
2
3			namespace Micro\Base;
4
5			use Micro\Web\IResponse;
6
7			/**
8			* Dispatcher class file.
9			*
10			* @author Oleg Lunegov <[email protected]>
11			* @link https://github.com/lugnsk/micro
12			* @copyright Copyright © 2013 Oleg Lunegov
13			* @license /LICENSE
14			* @package Micro
15			* @subpackage Base
16			* @version 1.0
17			* @since 1.0
18			*/
19			class Dispatcher implements IDispatcher
20			{
21			/** @var array $listeners listeners objects on events */
22			protected $listeners = [];
23
24			/**
25			* Add listener on event
26			*
27			* @access public
28			*
29			* @param string $listener listener name
30			* @param array $event ['Object', 'method'] or callable
31			* @param int\|null $prior priority
32			*
33			* @return bool
34			*/
35			public function addListener($listener, $event, $prior = null)
36			{
37			if (!is_callable($event)) {
38			return false;
39			}
40
41			if (!array_key_exists($listener, $this->listeners)) {
42			$this->listeners[$listener] = [];
43			}
44
45			if (!$prior) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report The expression `$prior` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be zero. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
46			$this->listeners[$listener][] = $event;
47			} else {
48			array_splice($this->listeners[$listener], $prior, 0, $event);
49			}
50
51			return true;
52			}
53
54			/**
55			* Send signal to run event
56			*
57			* @access public
58			*
59			* @param string $listener listener name
60			* @param array $params Signal parameters
61			*
62			* @return mixed
63			*/
64			public function signal($listener, array $params = [])
65			{
66			$result = null;
67
68			if ($this->listeners && array_key_exists($listener, $this->listeners)) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-21 13:17 UTC by Report Bug Copy Issue Report The expression `$this->listeners` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
69			foreach ($this->listeners[$listener] as $listen) {
70			$result = call_user_func($listen, $params);
71
72			if ($result instanceof IResponse) {
73			return $result;
74			}
75			}
76			}
77
78			return $result;
79			}
80			}
81

lugnsk / micro

Push — master ( f7ee5f...7c37a7 )

Dispatcher::signal() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like