lucajackal85 / ImageMerge

src/Metadata/Parser/AbstractParser.php

<?php

namespace Jackal\ImageMerge\Metadata\Parser;

/**
 * Class AbstractParser
 * @package Jackal\ImageMerge\Metadata\Parser
 */
abstract class AbstractParser implements ParserInterface
{
    /**
     * @var array
     */
    protected $data = [];

    /**
     * @return bool
     */
    public function isEmpty()
    {
        return !$this->data;
    }

    /**
     * @param $key
     * @return string|null|array
     */
    protected function getValue($key)
    {
        if (isset($this->data[$key])) {
            return $this->data[$key];
        }

        return null;
    }

    /**
     * @param $key
     * @return int|string
     */
    protected function getDivisionValue($key)
    {
        $value = $this->getValue($key);
        if (strpos($value, '/1') !== false) {

It seems like $value can also be of type array; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

            return (int) str_replace('/1', '', $value);
        }

            return $value;

The expression return $value also could return the type array which is incompatible with the documented return type integer|string.

    }

    /**
     * @param $key
     * @return bool|null
     */
    protected function getBooleanValue($key)
    {
        $value = $this->getSingleValue($key);
        if (is_null($value)) {
            return $value;
        }

        return $value == true and strtolower($value) != 'false';

It seems like you are loosely comparing $value of type string to the boolean true. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

    }

    /**
     * @param $data
     * @return string|null
     */
    protected function removeEmptyData($data)
    {
        if (is_string($data) and $data == '') {
            return null;
        }

        return $data;
    }

    /**
     * @param $key
     * @return string|null
     */
    protected function getSingleValue($key)
    {
        $value = $this->getValue($key);
        if (is_array($value)) {
            $value = array_shift($value);
        }
        $value = preg_replace('/[\r\n]/', "\n", $value);

        return $value;
    }
}