lucajackal85 / ImageMerge

src/Command/Effect/CropOuter.php

<?php

namespace Jackal\ImageMerge\Command\Effect;

use Jackal\ImageMerge\Builder\ImageBuilder;
use Jackal\ImageMerge\Command\AbstractCommand;
use Jackal\ImageMerge\Command\Options\DimensionCommandOption;
use Jackal\ImageMerge\Model\Image;

class CropOuter extends AbstractCommand
{
    /**
     * CropOuter constructor.
     * @param DimensionCommandOption $options
     */
    public function __construct(DimensionCommandOption $options)
    {
        parent::__construct($options);
    }

    /**
     * @param Image $image
     * @return Image
     */
    public function execute(Image $image)
    {
        $newWidth = $this->options->getDimention()->getWidth();

The method getDimention() does not exist on Jackal\ImageMerge\Command\Options\CommandOptionInterface. It seems like you code against a sub-type of Jackal\ImageMerge\Command\Options\CommandOptionInterface such as Jackal\ImageMerge\Command\Options\DimensionCommandOption.

        $newHeight = $this->options->getDimention()->getHeight();

        $thumbAspect = $newWidth / $newHeight;
        $builder = new ImageBuilder($image);
        if ($image->getAspectRatio() >= $thumbAspect) {
            $builder->resize($newWidth, null);
        } else {
            $builder->resize(null, $newHeight);
        }

        $posX = ($newWidth - $image->getWidth()) / 2;
        $posY = ($newHeight - $image->getHeight()) / 2;

        $image_p = imagecreatetruecolor($newWidth, $newHeight);
        imagecopyresampled($image_p, $image->getResource(), $posX, $posY, 0, 0, $image->getWidth(), $image->getHeight(), $image->getWidth(), $image->getHeight());

It seems like $image_p can also be of type false; however, parameter $dst_image of imagecopyresampled() does only seem to accept resource, maybe add an additional type check?

        $image->assignResource($image_p);

        return $image;
    }
}