Jackal\ImageMerge\Command\ResizeCommand

Complexity

Total Complexity

6

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	execute()	0	25	5

<?php

namespace Jackal\ImageMerge\Command;

use Jackal\ImageMerge\Command\Options\DimensionCommandOption;
use Jackal\ImageMerge\Model\Image;
use Jackal\ImageMerge\ValueObject\Dimention;

class ResizeCommand extends AbstractCommand
{
    /**
     * ResizeCommand constructor.
     * @param DimensionCommandOption $options
     */
    public function __construct(DimensionCommandOption $options)
    {
        parent::__construct($options);
    }

    /**
     * @param Image $image
     * @return Image
     */
    public function execute(Image $image)
    {
        if (!$this->options->getDimention()->getWidth()) {

The method getDimention() does not exist on Jackal\ImageMerge\Command\Options\CommandOptionInterface. It seems like you code against a sub-type of Jackal\ImageMerge\Command\Options\CommandOptionInterface such as Jackal\ImageMerge\Command\Options\DimensionCommandOption.

            $this->options->add('dimention', new Dimention(round($image->getAspectRatio() * $this->options->getDimention()->getHeight()), $this->options->getDimention()->getHeight()));

The method add() does not exist on Jackal\ImageMerge\Command\Options\CommandOptionInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Jackal\ImageMerge\Command\Options\CommandOptionInterface.

        }

        if (!$this->options->getDimention()->getHeight()) {
            $this->options->add('dimention', new Dimention($this->options->getDimention()->getWidth(), round($this->options->getDimention()->getWidth() / $image->getAspectRatio())));
        }

        $width = $this->options->getDimention()->getWidth();
        $height = $this->options->getDimention()->getHeight();

        if ($image->getWidth() != $width or $image->getHeight() != $height) {
            $resourceResized = imagecreatetruecolor($width, $height);
            imagealphablending($resourceResized, false);

It seems like $resourceResized can also be of type false; however, parameter $image of imagealphablending() does only seem to accept resource, maybe add an additional type check?

            imagesavealpha($resourceResized, true);

It seems like $resourceResized can also be of type false; however, parameter $image of imagesavealpha() does only seem to accept resource, maybe add an additional type check?

            $transparent = imagecolorallocatealpha($resourceResized, 255, 255, 255, 127);

It seems like $resourceResized can also be of type false; however, parameter $image of imagecolorallocatealpha() does only seem to accept resource, maybe add an additional type check?

            imagecolortransparent($resourceResized, $transparent);

It seems like $resourceResized can also be of type false; however, parameter $image of imagecolortransparent() does only seem to accept resource, maybe add an additional type check?

            imagecopyresampled($resourceResized, $image->getResource(), 0, 0, 0, 0, $width, $height, $image->getWidth(), $image->getHeight());

It seems like $resourceResized can also be of type false; however, parameter $dst_image of imagecopyresampled() does only seem to accept resource, maybe add an additional type check?

            return $image->assignResource($resourceResized);
        }

        return $image;
    }
}