AbstractVideoGenerator::generate() - Code Metrics - Inspection of "added checks for invalid input file" - lucajackal85/Giffhanger - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Luca

created 2020-04-06 14:17 UTC

AbstractVideoGenerator::generate() B

↳ Parent: AbstractVideoGenerator

Complexity

Conditions	8
Paths	134

Size

Total Lines	67
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	8
eloc	40
c	2
b	1
f	0
nc	134
nop	0
dl	0
loc	67
rs	7.8088

How to fix Long Method

<?php

namespace Jackal\Giffhanger\Generator;

use Alchemy\BinaryDriver\Exception\ExecutionFailureException;
use FFMpeg\Coordinate\Dimension;
use FFMpeg\Coordinate\FrameRate;
use FFMpeg\Coordinate\TimeCode;
use FFMpeg\Exception\RuntimeException;
use FFMpeg\FFMpeg;
use FFMpeg\Filters\Audio\SimpleFilter;
use FFMpeg\Media\Video;
use Jackal\Giffhanger\Configuration\Configuration;
use Jackal\Giffhanger\Exception\GiffhangerException;
use Jackal\Giffhanger\FFMpeg\ext\Filters\CropCenterFilter;

abstract class AbstractVideoGenerator implements GeneratorInterface
{
    abstract protected function getVideoFormat();

    protected $destination;
    protected $sourceFile;

    protected $options = [];
    private $tempFilesToRemove = [];

    public function __construct($sourceFile, $destionationFile, Configuration $options)
    {
        $this->options = $options;

        if (!is_dir($this->options->getTempFolder())) {
            if (!mkdir($this->options->getTempFolder(), 0777, true)) {
                $this->__destruct();

                throw new \Exception('Cannot create temp folder in path "' . $this->options->getTempFolder() . '"');
            }
        }

        $this->sourceFile = $sourceFile;
        $this->destination = $destionationFile;
    }

    /**
     * @return FFMpeg
     */
    protected function getFFMpeg() : FFMpeg
    {
        return FFMpeg::create([
            'ffmpeg.binaries' => $this->options->getFFMpegBinaries(),
            'ffprobe.binaries' => $this->options->getFFProbeBinaries(),
            'timeout' => 3600,
        ]);
    }

    protected function getDuration() : int
    {
        $ffmpeg = $this->getFFMpeg();
        $ffmpeg = $ffmpeg->open($this->sourceFile);

        return $ffmpeg->getFFProbe()->format($this->sourceFile)->get('duration');

    }

    protected function getCutPoints() : array
    {
        $cutPoints = [];
        $videoDuration = $this->getDuration();
        for ($i = 1;$i <= $this->options->getNumberOfFrames();$i++) {
            $cutPoints[] = (($videoDuration / $this->options->getNumberOfFrames()) - ($videoDuration / $this->options->getNumberOfFrames() / 2)) * $i;
        }

        return $cutPoints;
    }

    protected function getRatio() : float
    {
        $ffmpeg = $this->getFFMpeg();
        $ffmpeg = $ffmpeg->open($this->sourceFile);

        return $ffmpeg->getStreams()->first()->getDimensions()->getRatio()->getValue();
    }

    public function __destruct()
    {
        foreach (array_unique($this->tempFilesToRemove) as $fileToRemove) {
            if (is_file($fileToRemove)) {
                unlink($fileToRemove);
            }
            //if folder is empty, remove
            if (is_dir(dirname($fileToRemove)) and count(scandir(dirname($fileToRemove))) == 2) {
            if (is_dir(dirname($fileToRemove)) and count(/** @scrutinizer ignore-type */ scandir(dirname($fileToRemove))) == 2) {
                rmdir(dirname($fileToRemove));
            }
        }
    }

    protected function addTempFileToRemove($filePath) : void
    {
        $this->tempFilesToRemove[] = $filePath;
    }

    public function generate() : void
    {
        $ffmpeg = $this->getFFMpeg();
        $videoFormat = $this->getVideoFormat();

        try {
            $cutPoints = $this->getCutPoints();

            /** @var Video $video */
            $video = $ffmpeg->open($this->sourceFile);

            $files = [];
            foreach ($cutPoints as $k => $cutPoint) {
                $partFile = $this->options->getTempFolder() . '/' . md5($this->sourceFile) . '_' . ($k + 1) . '.avi';

                //remove audio track
                $video->addFilter(new SimpleFilter(['-an']));

                $video->filters()->clip(
                    TimeCode::fromSeconds($cutPoint),
                    TimeCode::fromSeconds($this->options->getOutputDuration() / count($cutPoints))
                );

                $video->filters()->resize(
                    new Dimension(
                        (int) round($this->options->getDimensionWidth()),
                        (int) round($this->options->getDimensionWidth() / $this->getRatio())
                    )
                );
                $video->filters()->framerate(new FrameRate($this->options->getFrameRate()), 1);
                $video->save($videoFormat, $partFile);

                $files[] = $partFile;
                $this->addTempFileToRemove($partFile);
            }

            if (count($files) == 1) {
                rename($files[0], $this->destination);
            } else {
                /** @var Video $video */
                $video = $ffmpeg->open($files[0]);

                if (is_file($this->destination)) {
                    unlink($this->destination);
                }

                $video
                    ->concat($files)
                    ->saveFromSameCodecs($this->destination);
            }

            if ($this->options->getCropRatio() and ($this->options->getCropRatio() != $this->getRatio())) {
                $fileCropped = $this->options->getTempFolder() . '/' . md5($this->sourceFile) . '_cropped.avi';

                $video = $ffmpeg->open($this->destination);
                $video->addFilter(new CropCenterFilter($this->options->getCropRatio()));
                $video->save($videoFormat, $fileCropped);
                rename($fileCropped, $this->destination);
            }
        } catch (RuntimeException $e) {
            $message = $e->getMessage();

            if ($e->getPrevious() instanceof ExecutionFailureException) {
                $message = $e->getPrevious()->getMessage();
            }

            throw new GiffhangerException(sprintf('%s', $message));
        }
    }
}


lucajackal85 / Giffhanger

Pull Request — master (#1)

AbstractVideoGenerator::generate() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like