Workflow::process() - Code Metrics - lucajackal85/Copycat - Measure and Improve Code Quality continuously with Scrutinizer

Workflow::process() B
last analyzed 2020-08-20 10:46 UTC

↳ Parent: Workflow

Complexity

Conditions	10
Paths	81

Size

Total Lines	36
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
eloc	20
c	1
b	1
f	0
dl	0
loc	36
rs	7.6666
cc	10
nc	81
nop	1

How to fix Complexity

<?php

namespace Jackal\Copycat;

use Jackal\Copycat\Converter\ConversionMap;
use Jackal\Copycat\Filter\FilterMap;
use Jackal\Copycat\Reader\ReaderInterface;
use Jackal\Copycat\Sorter\SorterMap;
use Jackal\Copycat\Writer\WriterInterface;
use RuntimeException;

/**
 * Class Workflow
 * @package Jackal\Copycat
 */
class Workflow
{
    /**
     * @var ReaderInterface
     */
    protected $reader;

    /**
     * @var WriterInterface[]
     */
    protected $writers = [];

    /**
     * @var ConversionMap
     */
    protected $conversionMap;

    /**
     * @var FilterMap
     */
    protected $filterMap;

    /**
     * @var SorterMap
     */
    protected $sorterMap;

    /**
     * Workflow constructor.
     * @param ReaderInterface $reader
     */
    public function __construct(ReaderInterface $reader)
    {
        $this->reader = $reader;
        $this->conversionMap = new ConversionMap();
        $this->filterMap = new FilterMap();
        $this->sorterMap = new SorterMap();
    }

    /**
     * @param WriterInterface $writer
     */
    public function addWriter(WriterInterface $writer)
    {
        $this->writers[] = $writer;
    }

    /**
     * @param callable $converter
     */
    public function addConverter(callable $converter)
    {
        $this->conversionMap->add($converter);
    }

    /**
     * @param callable $filter
     */
    public function addFilter(callable $filter)
    {
        $this->filterMap->add($filter);
    }

    /**
     * @param callable $sorter
     */
    public function addSorter(callable $sorter)
    {
        $this->sorterMap->add($sorter);
    }

    /**
     * @param callable|null $callback
     */
    public function process(callable $callback = null)
    {
        if (!$this->writers) {

            throw new RuntimeException('No writers set');
        }

        foreach ($this->writers as $writer) {
            $writer->prepare();
        }

        if ($this->sorterMap->hasSorter()) {
            $values = $this->reader->all();
            $this->sorterMap->apply($values);
        } else {
            $values = $this->reader;
        }

        foreach ($values as $k => $row) {
            foreach ($this->writers as $writer) {
                $copyRow = $row;

                if ($this->filterMap->apply($copyRow)) {
                    $this->conversionMap->apply($copyRow);
                    $writer->writeItem($copyRow);
                }
            }

            if ($callback) {
                if (isset($copyRow)) {
                    $callback($copyRow);
                }
            }
        }

        foreach ($this->writers as $writer) {
            $writer->finish();
        }
    }
}


1			<?php
2
3			namespace Jackal\Copycat;
4
5			use Jackal\Copycat\Converter\ConversionMap;
6			use Jackal\Copycat\Filter\FilterMap;
7			use Jackal\Copycat\Reader\ReaderInterface;
8			use Jackal\Copycat\Sorter\SorterMap;
9			use Jackal\Copycat\Writer\WriterInterface;
10			use RuntimeException;
11
12			/**
13			* Class Workflow
14			* @package Jackal\Copycat
15			*/
16			class Workflow
17			{
18			/**
19			* @var ReaderInterface
20			*/
21			protected $reader;
22
23			/**
24			* @var WriterInterface[]
25			*/
26			protected $writers = [];
27
28			/**
29			* @var ConversionMap
30			*/
31			protected $conversionMap;
32
33			/**
34			* @var FilterMap
35			*/
36			protected $filterMap;
37
38			/**
39			* @var SorterMap
40			*/
41			protected $sorterMap;
42
43			/**
44			* Workflow constructor.
45			* @param ReaderInterface $reader
46			*/
47			public function __construct(ReaderInterface $reader)
48			{
49			$this->reader = $reader;
50			$this->conversionMap = new ConversionMap();
51			$this->filterMap = new FilterMap();
52			$this->sorterMap = new SorterMap();
53			}
54
55			/**
56			* @param WriterInterface $writer
57			*/
58			public function addWriter(WriterInterface $writer)
59			{
60			$this->writers[] = $writer;
61			}
62
63			/**
64			* @param callable $converter
65			*/
66			public function addConverter(callable $converter)
67			{
68			$this->conversionMap->add($converter);
69			}
70
71			/**
72			* @param callable $filter
73			*/
74			public function addFilter(callable $filter)
75			{
76			$this->filterMap->add($filter);
77			}
78
79			/**
80			* @param callable $sorter
81			*/
82			public function addSorter(callable $sorter)
83			{
84			$this->sorterMap->add($sorter);
85			}
86
87			/**
88			* @param callable\|null $callback
89			*/
90			public function process(callable $callback = null)
91			{
92			if (!$this->writers) {
			0 ignored issues – show Bug Best Practice introduced 2020-08-19 08:19 UTC by Report Bug Copy Issue Report The expression `$this->writers` of type `Jackal\Copycat\Writer\WriterInterface[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
93			throw new RuntimeException('No writers set');
94			}
95
96			foreach ($this->writers as $writer) {
97			$writer->prepare();
98			}
99
100			if ($this->sorterMap->hasSorter()) {
101			$values = $this->reader->all();
102			$this->sorterMap->apply($values);
103			} else {
104			$values = $this->reader;
105			}
106
107			foreach ($values as $k => $row) {
108			foreach ($this->writers as $writer) {
109			$copyRow = $row;
110
111			if ($this->filterMap->apply($copyRow)) {
112			$this->conversionMap->apply($copyRow);
113			$writer->writeItem($copyRow);
114			}
115			}
116
117			if ($callback) {
118			if (isset($copyRow)) {
119			$callback($copyRow);
120			}
121			}
122			}
123
124			foreach ($this->writers as $writer) {
125			$writer->finish();
126			}
127			}
128			}
129

lucajackal85 / Copycat

Workflow::process() B last analyzed 2020-08-20 10:46 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

Workflow::process() B
last analyzed 2020-08-20 10:46 UTC