Jackal\Copycat\Reader\PDOMySQLReader::__construct()

Complexity

Conditions	2
Paths	2

Size

Total Lines	28
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function __construct($query, array $options)
    {
        $resolver = new OptionsResolver();
        $resolver->setDefaults([
            'host' => 'localhost',
            'port' => 3306,
            'username' => null,
            'password' => null,
            'database_name' => null,
            'query' => $query,
            'driver_options' => [
                PDO::ATTR_DEFAULT_FETCH_MODE => PDO::FETCH_ASSOC,
            ],
        ]);

        $this->options = $resolver->resolve($options);

        /** @noinspection SpellCheckingInspection */
        $dbh = $pdo = new PDO(

The assignment to $pdo is dead and can be removed.

            sprintf('mysql:host=%s;dbname=%s', $this->options['host'], $this->options['database_name']),
            $this->options['username'],
            $this->options['password'],
            $this->options['driver_options']
        );
        foreach ($dbh->query($query) as $row) {
            $this->addItem($row);
        }
        $dbh = null;

The assignment to $dbh is dead and can be removed.

    }