lubusIN / laravel-gymie

app/Http/Controllers/ExpensesController.php

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use Auth;
use Carbon\Carbon;
use App\Expense;
use App\ExpenseCategory;
use App\Http\Controllers\Controller;
use App\Http\Requests;


class ExpensesController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth');
    }
     /* Display a listing of the resource.
     *
     * @return Response

The type App\Http\Controllers\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

     */
    public function index(Request $request)
    {
      $expenses = Expense::indexQuery($request->category_id,$request->sort_field,$request->sort_direction,$request->drp_start,$request->drp_end)->search('"'.$request->input('search').'"')->paginate(10);
      $expenseTotal = Expense::indexQuery($request->category_id,$request->sort_field,$request->sort_direction,$request->drp_start,$request->drp_end)->search('"'.$request->input('search').'"')->get();
      $count = $expenseTotal->sum('amount');
     
 
      if (!$request->has('drp_start') or !$request->has('drp_end')) 
      {
        $drp_placeholder = "Select daterange filter";
      }
      else
      {
        $drp_placeholder = $request->drp_start. ' - ' .$request->drp_end;
      }

      $request->flash();
      
      return view('expenses.index', compact('expenses','count','drp_placeholder'));

The expression return view('expenses.index', compact('expenses', 'count', 'drp_placeholder')) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return Response
     */
    public function show()
    {
    	$expense = Expense::findOrFail($id);

The variable $id seems to be never defined.

    	return view('expenses.show', compact('expense'));

The expression return view('expenses.show', compact('expense')) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

     /**
     * Show the form for creating a new resource.
     *
     * @return Response
     */
    public function create()
    {
    	return view('expenses.create');

The expression return view('expenses.create') returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }
    
     /**
     * Store a newly created resource in storage.
     *
     * @return Response
     */
    public function store(Request $request)
    {
        $expenseData = array('name' => $request->name,
                             'category_id' => $request->category_id,
                             'due_date' => $request->due_date,
                             'repeat' => $request->repeat,
                             'note' => $request->note,
                             'amount' => $request->amount);

        $expense  = new Expense($expenseData);
        $expense->createdBy()->associate(Auth::user());
        $expense->updatedBy()->associate(Auth::user());
        $expense->save();

        if ($request->due_date <= Carbon::today()->format('Y-m-d')) 
        {
            $expense->paid = \constPaymentStatus::Paid;
        }
        else
        {
            $expense->paid = \constPaymentStatus::Unpaid;
        }

        $expense->createdBy()->associate(Auth::user());

        $expense->save();
        flash()->success('Expense was successfully added');
    	return redirect('expenses/all'); 

The expression return redirect('expenses/all') returns the type Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    public function edit($id)
    {
        $expense=Expense::findOrFail($id);

        return view('expenses.edit', compact('expense'));
    }

    public function update($id, Request $request)
    {
        $expense=Expense::findOrFail($id);

        $expense->update($request->all());

        if ($request->due_date == Carbon::today()) 
        {
            $expense->paid = \constPaymentStatus::Paid;
        }
        elseif($request->due_date != Carbon::today() && $expense->paid == \constPaymentStatus::Paid)
        {
            $expense->paid = \constPaymentStatus::Paid;
        }
        else
        {
            $expense->paid = \constPaymentStatus::Unpaid;
        }

        $expense->updatedBy()->associate(Auth::user());

        $expense->save();
        flash()->success('Expense was successfully updated');
        return redirect('expenses/all');
    }

    public function paid($id, Request $request)

The parameter $request is not used and could be removed.

    {
        Expense::where('id','=',$id)->update(['paid' => \constPaymentStatus::Paid]);
        
        flash()->success('Expense was successfully paid');
        return redirect('expenses/all');
    }

    public function delete($id)
    {
        Expense::destroy($id);
        
        return redirect('expenses/all');
    }

}