App\Http\Controllers\ExpenseCategoriesController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	archive()	0	5	1
A	index()	0	7	1
A	show()	0	5	1
A	create()	0	3	1
A	__construct()	0	3	1
A	edit()	0	5	1
A	store()	0	12	1
A	update()	0	11	1

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use Auth;
use App\ExpenseCategory;
use App\Http\Controllers\Controller;
use App\Http\Requests;
use Lubus\Constants\Status;

The type Lubus\Constants\Status was not found. Maybe you did not declare it correctly or list all dependencies?

class ExpenseCategoriesController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth');
    }
   
	/**
     * Display a listing of the resource.
     *
     * @return Response

The type App\Http\Controllers\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

     */
    public function index()
    {
        $expenseCategories = ExpenseCategory::paginate(10);
    	$expenseCategoriesTotal = ExpenseCategory::all();
        $count = $expenseCategoriesTotal->count();

    	return view('expenseCategories.index', compact('expenseCategories','count'));

The expression return view('expenseCategories.index', compact('expenseCategories', 'count')) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return Response
     */
    public function show()
    {
    	$expenseCategory = ExpenseCategory::findOrFail($id);

The variable $id seems to be never defined.

    	return view('expenseCategories.show', compact('expenseCategory'));

The expression return view('expenseCategories.show', compact('expenseCategory')) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }

     /**
     * Show the form for creating a new resource.
     *
     * @return Response
     */
    public function create()
    {
    	return view('expenseCategories.create');

The expression return view('expenseCategories.create') returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

    }
    
     /**
     * Store a newly created resource in storage.
     *
     * @return Response
     */
    public function store(Request $request)
    {
        $this->validate($request, ['name' => 'unique:mst_expenses_categories,name']);

        $expenseCategory = new ExpenseCategory($request->all());

        $expenseCategory->createdBy()->associate(Auth::user());
        $expenseCategory->updatedBy()->associate(Auth::user());

        $expenseCategory->save();
        flash()->success('Expense Category was successfully added');
    	return redirect('expenses/categories'); 

The expression return redirect('expenses/categories') returns the type Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector which is incompatible with the documented return type App\Http\Controllers\Response.

    }

    public function edit($id)
    {
        $expenseCategory=ExpenseCategory::findOrFail($id);

        return view('expenseCategories.edit', compact('expenseCategory'));
    }

    public function update($id, Request $request)
    {
        $expenseCategory=ExpenseCategory::findOrFail($id);

        $expenseCategory->update($request->all());

        $expenseCategory->updatedBy()->associate(Auth::user());

        $expenseCategory->save();
        flash()->success('Category was successfully updated');
        return redirect('expenses/categories');
    }    
    
    public function archive($id, Request $request)

The parameter $request is not used and could be removed.

    {
        ExpenseCategory::destroy($id);

        return redirect('expenses/categories');
    }
}