Response::getBody() - Code Metrics - Inspection of "Refactoring for better understanding" - lsolesen/edbbrugs-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Lars

created 2017-03-23 20:48 UTC

Response::getBody() B

↳ Parent: Response

Complexity

Conditions	6
Paths	6

Size

Total Lines	30
Code Lines	23

Duplication

Lines	20
Ratio	66.67 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	20
loc	30
ccs	0
cts	23
cp	0
rs	8.439
c	0
b	0
f	0
cc	6
eloc	23
nc	6
nop	0
crap	42

<?php
/**
 * SDK to communicate with EDBBrugs
 *
 * PHP Version 5
 *
 * @category EDBBrugs
 * @package  EDBBrugs
 * @author   Lars Olesen <[email protected]>
 * @license  MIT Open Source License https://opensource.org/licenses/MIT
 * @version  GIT: <git_id>
 */

namespace EDBBrugs;

use EDBBrugs\ResponseInterface;

/**
 * Service Communicator with EDB-Brugs
 *
 * @category EDBBrugs
 * @package  EDBBrugs
 * @author   Lars Olesen <[email protected]>
 * @license  MIT Open Source License https://opensource.org/licenses/MIT
 * @version  GIT: <git_id>
 */
class Response implements ResponseInterface
{
    protected $responseType;
    protected $response;

    /**
     * Constructor
     *
     * @param object $responseType Response type
     * @param object $response     Actual response from SOAP
     */
    public function __construct($responseType, $response)
    {
        $this->responseType = $responseType;
        $this->response = $response;
    }

    public function getCount()
    {
        return str_replace(
            'Oprettelse Ok, nye tilmeldinger: ',
            '',
            $this->response->NyTilmelding2Result
        );
    }

    /**
     * Add new registration to EDBBrugs
     *
     * @return mixed (number of successful registrations) or throws Exception
     */
    public function getBody()
    {
        switch ($this->responseType) {
            case 'NyTilmelding2':

                if (!$this->isOk()) {
                    throw new \Exception($this->response->NyTilmelding2Result);
                }
                return str_replace(
                    'Oprettelse Ok, nye tilmeldinger: ',
                    '',
                    $this->response->NyTilmelding2Result
                );
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'SletTilmeldingerV2':

                if (!$this->isOk()) {
                    throw new \Exception($this->response->SletTilmeldingerV2Result);
                }
                return str_replace(
                    'Oprettelse Ok, nye tilmeldinger: ',
                    '',
                    $this->response->SletTilmeldingerV2Response
                );
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'HentNyeTilmeldingerV2':
                return $this->response->HentNyeTilmeldingerV2Result;
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                throw new \Exception($this->responseType . ' is not a valid response type');
        }
    }

    /**
     * Checks whether the communication is OK
     *
     * @return boolean
     */
    public function isOk()
    {
        switch ($this->responseType) {
            case 'NyTilmelding2':
                $string = 'Oprettelse Ok, nye tilmeldinger';
                $result = strpos($this->response->NyTilmelding2Result, $string);
                return ($result !== false);
            case 'SletTilmeldingerV2':
                $string = 'Oprettelse Ok, nye tilmeldinger';
                $result = strpos($this->response->SletTilmeldingerV2Result, $string);
                return ($result !== false);
            case 'HentNyeTilmeldingerV2':
                $string = 'Oprettelse Ok, nye tilmeldinger';
                $result = strpos($this->response->HentNyeTilmeldingerV2Result, $string);
                return ($result !== false);
            default:
                throw new \Exception('Not a valid response type');
        }
    }
}


1			<?php
2			/**
3			* SDK to communicate with EDBBrugs
4			*
5			* PHP Version 5
6			*
7			* @category EDBBrugs
8			* @package EDBBrugs
9			* @author Lars Olesen <[email protected]>
10			* @license MIT Open Source License https://opensource.org/licenses/MIT
11			* @version GIT: <git_id>
12			*/
13
14			namespace EDBBrugs;
15
16			use EDBBrugs\ResponseInterface;
17
18			/**
19			* Service Communicator with EDB-Brugs
20			*
21			* @category EDBBrugs
22			* @package EDBBrugs
23			* @author Lars Olesen <[email protected]>
24			* @license MIT Open Source License https://opensource.org/licenses/MIT
25			* @version GIT: <git_id>
26			*/
27			class Response implements ResponseInterface
28			{
29			protected $responseType;
30			protected $response;
31
32			/**
33			* Constructor
34			*
35			* @param object $responseType Response type
36			* @param object $response Actual response from SOAP
37			*/
38	1		public function __construct($responseType, $response)
39			{
40	1		$this->responseType = $responseType;
41	1		$this->response = $response;
42	1		}
43
44	1		public function getCount()
45			{
46	1		return str_replace(
47	1		'Oprettelse Ok, nye tilmeldinger: ',
48	1		'',
49	1		$this->response->NyTilmelding2Result
50	1		);
51			}
52
53			/**
54			* Add new registration to EDBBrugs
55			*
56			* @return mixed (number of successful registrations) or throws Exception
57			*/
58			public function getBody()
59			{
60			switch ($this->responseType) {
61		View Code Duplication	case 'NyTilmelding2':
			0 ignored issues – show Duplication introduced 2017-03-23 20:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62			if (!$this->isOk()) {
63			throw new \Exception($this->response->NyTilmelding2Result);
64			}
65			return str_replace(
66			'Oprettelse Ok, nye tilmeldinger: ',
67			'',
68			$this->response->NyTilmelding2Result
69			);
70			break;
			0 ignored issues – show Unused Code introduced 2017-03-23 20:50 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
71		View Code Duplication	case 'SletTilmeldingerV2':
			0 ignored issues – show Duplication introduced 2017-03-23 20:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72			if (!$this->isOk()) {
73			throw new \Exception($this->response->SletTilmeldingerV2Result);
74			}
75			return str_replace(
76			'Oprettelse Ok, nye tilmeldinger: ',
77			'',
78			$this->response->SletTilmeldingerV2Response
79			);
80			break;
			0 ignored issues – show Unused Code introduced 2017-03-23 20:50 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
81			case 'HentNyeTilmeldingerV2':
82			return $this->response->HentNyeTilmeldingerV2Result;
83			break;
			0 ignored issues – show Unused Code introduced 2017-03-23 20:50 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
84			default:
85			throw new \Exception($this->responseType . ' is not a valid response type');
86			}
87			}
88
89			/**
90			* Checks whether the communication is OK
91			*
92			* @return boolean
93			*/
94			public function isOk()
95			{
96			switch ($this->responseType) {
97			case 'NyTilmelding2':
98			$string = 'Oprettelse Ok, nye tilmeldinger';
99			$result = strpos($this->response->NyTilmelding2Result, $string);
100			return ($result !== false);
101			case 'SletTilmeldingerV2':
102			$string = 'Oprettelse Ok, nye tilmeldinger';
103			$result = strpos($this->response->SletTilmeldingerV2Result, $string);
104			return ($result !== false);
105			case 'HentNyeTilmeldingerV2':
106			$string = 'Oprettelse Ok, nye tilmeldinger';
107			$result = strpos($this->response->HentNyeTilmeldingerV2Result, $string);
108			return ($result !== false);
109			default:
110			throw new \Exception('Not a valid response type');
111			}
112			}
113			}
114

lsolesen / edbbrugs-php-sdk

Pull Request — master (#9)

Response::getBody() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like