View GitHub Repository edbbrugs-php-sdk

Schedule Inspection
Subscribe
Completed
Pull Request — master (#19)
by Lars
01:46
created
Status
Category
Toggle Patches
src/Utility.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,7 @@  discard block
 
 block discarded – undo
33 33 
      */
34 34 
     public function getCountryCode($country)
35 35 
     {
36 
-        $rows = $this->getCSV(DIRNAME(__FILE__) . "/data/Landekoder.csv", $country);
36 
+        $rows = $this->getCSV(DIRNAME(__FILE__)."/data/Landekoder.csv", $country);
37 37 
         $stored_in_column = 3;
38 38 
         return $rows[$stored_in_column];
39 39 
     }
 
@@ -45,7 +45,7 @@  discard block
 
 block discarded – undo
45 45 
      */
46 46 
     public function getMunicipalityCode($municipality)
47 47 
     {
48 
-        $rows = $this->getCSV(DIRNAME(__FILE__) . "/data/Kommuner.csv", $municipality);
48 
+        $rows = $this->getCSV(DIRNAME(__FILE__)."/data/Kommuner.csv", $municipality);
49 49 
         $stored_in_column = 2;
50 50 
         return $rows[$stored_in_column];
51 51 
     }
 
@@ -80,7 +80,7 @@  discard block
 
 block discarded – undo
80 80 
      */
81 81 
     private function substrInArray($needle, array $haystack)
82 82 
     {
83 
-        $filtered = array_filter($haystack, function ($item) use ($needle) {
83 
+        $filtered = array_filter($haystack, function($item) use ($needle) {
84 84 
             return false !== strpos($item, $needle);
85 85 
         });
86 86
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -32,6 +32,7 @@  discard block
 
 block discarded – undo
32 32 
      * @param string $country Country name
33 33 
      *
34 34 
      * $return integer
35 
+     * @return string|null
35 36 
      */
36 37 
     public function getCountryCode($country)
37 38 
     {
 
@@ -46,6 +47,7 @@  discard block
 
 block discarded – undo
46 47 
      * @param string $municipality Municipality name
47 48 
      *
48 49 
      * $return integer
50 
+     * @return string|null
49 51 
      */
50 52 
     public function getMunicipalityCode($municipality)
51 53 
     {
 
@@ -71,8 +73,8 @@  discard block
 
 block discarded – undo
71 73 
     /**
72 74 
      * Loops through csv file and stops with search
73 75 
      *
74 
-     * @param $file_name
75 
-     * @param $search
76 
+     * @param string $file_name
77 
+     * @param string $search
76 78 
      * @return array
77 79 
      */
78 80 
     protected function getCSV($file_name, $search)
Please login to merge, or discard this patch.