Request::populateRequest() - Code Metrics - Inspection of "Refactoring for better understanding" - lsolesen/edbbrugs-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Lars

created 2017-03-23 11:24 UTC

Request::populateRequest() A

↳ Parent: Request

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	0
crap	1

<?php
/**
 * SDK to communicate with EDBBrugs
 *
 * PHP Version 5
 *
 * @category EDBBrugs
 * @package  EDBBrugs
 * @author   Lars Olesen <[email protected]>
 * @license  MIT Open Source License https://opensource.org/licenses/MIT
 * @version  GIT: <git_id>
 */

namespace EDBBrugs;

/**
 * Generate the XML
 *
 * @category EDBBrugs
 * @package  EDBBrugs
 * @author   Lars Olesen <[email protected]>
 * @license  MIT Open Source License https://opensource.org/licenses/MIT
 * @version  GIT: <git_id>
 */
class Request
{
    protected $username;
    protected $password;
    protected $school_code;
    protected $xml;

    /**
     * Constructor
     *
     * @param string $username    Username provided by EDBBrugs
     * @param string $password    Password provided by EDBBrugs
     * @param string $school_code School code provided by EDBBrugs
     */
    public function __construct($username, $password, $school_code)
    {
        $this->username    = $username;
        $this->password    = $password;
        $this->school_code = $school_code;

        $this->populateRequest();
    }

    /**
     * Populate the XML request
     *
     * @return void
     */
    protected function populateRequest()
    {
        $this->xml = new \SimpleXMLElement('<Tilmeldinger/>');
        $user = $this->xml->addChild('User');
        $user->addChild('Username', $this->username);
        $user->addChild('Passw', $this->password);
        $user->addChild('Skolekode', $this->school_code);
    }

    /**
     * Returns the XML request
     *
     * @return string
     */
    public function getRequest()
    {
        return $this->xml;
    }
}


1		<?php
2		/**
3		* SDK to communicate with EDBBrugs
4		*
5		* PHP Version 5
6		*
7		* @category EDBBrugs
8		* @package EDBBrugs
9		* @author Lars Olesen <[email protected]>
10		* @license MIT Open Source License https://opensource.org/licenses/MIT
11		* @version GIT: <git_id>
12		*/
13
14		namespace EDBBrugs;
15
16		/**
17		* Generate the XML
18		*
19		* @category EDBBrugs
20		* @package EDBBrugs
21		* @author Lars Olesen <[email protected]>
22		* @license MIT Open Source License https://opensource.org/licenses/MIT
23		* @version GIT: <git_id>
24		*/
25		class Request
26		{
27		protected $username;
28		protected $password;
29		protected $school_code;
30		protected $xml;
31
32		/**
33		* Constructor
34		*
35		* @param string $username Username provided by EDBBrugs
36		* @param string $password Password provided by EDBBrugs
37		* @param string $school_code School code provided by EDBBrugs
38		*/
39	4	public function __construct($username, $password, $school_code)
40		{
41	4	$this->username = $username;
42	4	$this->password = $password;
43	4	$this->school_code = $school_code;
44
45	4	$this->populateRequest();
46	4	}
47
48		/**
49		* Populate the XML request
50		*
51		* @return void
52		*/
53	4	protected function populateRequest()
54		{
55	4	$this->xml = new \SimpleXMLElement('<Tilmeldinger/>');
56	4	$user = $this->xml->addChild('User');
57	4	$user->addChild('Username', $this->username);
58	4	$user->addChild('Passw', $this->password);
59	4	$user->addChild('Skolekode', $this->school_code);
60	4	}
61
62		/**
63		* Returns the XML request
64		*
65		* @return string
66		*/
67	3	public function getRequest()
68		{
69	3	return $this->xml;
70		}
71		}
72

lsolesen / edbbrugs-php-sdk

Pull Request — master (#9)

Request::populateRequest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like