Builder::addUpdatedAtColumn() - Code Metrics - Inspection of "fix model touch updated_at" - lroman242/laravel-cassandra - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Retried Inspection

Push — testing ( 0db53a...88fcdf )

by Roman

created 2019-04-30 19:22 UTC

Builder::addUpdatedAtColumn() A

↳ Parent: Builder

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	9.584
c	0
b	0
f	0
cc	4
nc	3
nop	1

<?php

namespace lroman242\LaravelCassandra\Eloquent;

use Cassandra\Rows;
use lroman242\LaravelCassandra\Collection;
use Illuminate\Database\Eloquent\Builder as EloquentBuilder;

class Builder extends EloquentBuilder
{
    /**
     * Create a collection of models from plain arrays.
     *
     * @param  \Cassandra\Rows  $rows
     *
     * @return Collection
     */
    public function hydrateRows(Rows $rows)
    {
        $instance = $this->newModelInstance();

        return $instance->newCassandraCollection($rows);
    }

    /**
     * Execute the query as a "select" statement.
     *
     * @param  array  $columns
     *
     * @return Collection
     *
     * @throws \Exception
     */
    public function getPage($columns = ['*'])
    {
        $builder = $this->applyScopes();

        return $builder->getModelsPage($columns);
    }

    /**
     * Get the hydrated models without eager loading.
     *
     * @param  array  $columns
     *
     * @return Collection
     *
     * @throws \Exception
     */
    public function getModelsPage($columns = ['*'])

    {
        $results = $this->query->getPage($columns);

        if ($results instanceof Collection) {
            $results = $results->getRows();
        } elseif (!$results instanceof Rows) {
            throw new \Exception('Invalid type of getPage response. Expected lroman242\LaravelCassandra\Collection or Cassandra\Rows');
        }

        return $this->model->hydrateRows($results);
    }

    /**
     * Execute the query as a "select" statement.
     *
     * @param array $columns
     *
     * @return \Illuminate\Database\Eloquent\Collection|static[]
     *
     * @throws \Exception
     */
    public function get($columns = ['*'])
    {
        $builder = $this->applyScopes();

        return $builder->getModels($columns);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Get the hydrated models without eager loading.
     *
     * @param  array  $columns
     *
     * @return \Illuminate\Database\Eloquent\Collection|static[]
     *
     * @throws \Exception
     */
    public function getModels($columns = ['*'])

    {
        $results = $this->query->get($columns);

        if ($results instanceof Collection) {
            $results = $results->getRows();
        } elseif (!$results instanceof Rows) {
            throw new \Exception('Invalid type of getPage response. Expected lroman242\LaravelCassandra\Collection or Cassandra\Rows');
        }

        return $this->model->hydrateRows($results);
    }

    /**
     * Add the "updated at" column to an array of values.
     *
     * @param  array  $values
     * @return array
     */
    protected function addUpdatedAtColumn(array $values)
    {
        if (! $this->model->usesTimestamps() ||
            is_null($this->model->getUpdatedAtColumn())) {
            return $values;
        }

        $column = $this->model->getUpdatedAtColumn();

        $values = array_merge(
            [$column => $this->model->freshTimestampString()],
            $values
        );

        $values[$this->qualifyColumn($column)] = $values[$column];
        if ($column != $this->qualifyColumn($column)) {
            unset($values[$column]);
        }

        return $values;
    }


}


1		<?php
2
3		namespace lroman242\LaravelCassandra\Eloquent;
4
5		use Cassandra\Rows;
6		use lroman242\LaravelCassandra\Collection;
7		use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
8
9		class Builder extends EloquentBuilder
10		{
11		/**
12		* Create a collection of models from plain arrays.
13		*
14		* @param \Cassandra\Rows $rows
15		*
16		* @return Collection
17		*/
18		public function hydrateRows(Rows $rows)
19		{
20		$instance = $this->newModelInstance();
21
22		return $instance->newCassandraCollection($rows);
23		}
24
25		/**
26		* Execute the query as a "select" statement.
27		*
28		* @param array $columns
29		*
30		* @return Collection
31		*
32		* @throws \Exception
33		*/
34		public function getPage($columns = ['*'])
35		{
36		$builder = $this->applyScopes();
37
38		return $builder->getModelsPage($columns);
39		}
40
41		/**
42		* Get the hydrated models without eager loading.
43		*
44		* @param array $columns
45		*
46		* @return Collection
47		*
48		* @throws \Exception
49		*/
50	View Code Duplication	public function getModelsPage($columns = ['*'])
		0 ignored issues – show Duplication introduced 2019-04-24 19:07 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		$results = $this->query->getPage($columns);
53
54		if ($results instanceof Collection) {
55		$results = $results->getRows();
56		} elseif (!$results instanceof Rows) {
57		throw new \Exception('Invalid type of getPage response. Expected lroman242\LaravelCassandra\Collection or Cassandra\Rows');
58		}
59
60		return $this->model->hydrateRows($results);
61		}
62
63		/**
64		* Execute the query as a "select" statement.
65		*
66		* @param array $columns
67		*
68		* @return \Illuminate\Database\Eloquent\Collection\|static[]
69		*
70		* @throws \Exception
71		*/
72		public function get($columns = ['*'])
73		{
74		$builder = $this->applyScopes();
75
76		return $builder->getModels($columns);
		0 ignored issues – show Bug Best Practice introduced 2019-04-24 19:07 UTC by Report Bug Copy Issue Report The return type of `return $builder->getModels($columns);` (`Illuminate\Database\Eloquent\Model[]`) is incompatible with the return type of the parent method `Illuminate\Database\Eloquent\Builder::get` of type `Illuminate\Database\Eloq...base\Eloquent\Builder[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
77		}
78
79		/**
80		* Get the hydrated models without eager loading.
81		*
82		* @param array $columns
83		*
84		* @return \Illuminate\Database\Eloquent\Collection\|static[]
85		*
86		* @throws \Exception
87		*/
88	View Code Duplication	public function getModels($columns = ['*'])
		0 ignored issues – show Duplication introduced 2019-04-24 19:07 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
89		{
90		$results = $this->query->get($columns);
91
92		if ($results instanceof Collection) {
93		$results = $results->getRows();
94		} elseif (!$results instanceof Rows) {
95		throw new \Exception('Invalid type of getPage response. Expected lroman242\LaravelCassandra\Collection or Cassandra\Rows');
96		}
97
98		return $this->model->hydrateRows($results);
99		}
100
101		/**
102		* Add the "updated at" column to an array of values.
103		*
104		* @param array $values
105		* @return array
106		*/
107		protected function addUpdatedAtColumn(array $values)
108		{
109		if (! $this->model->usesTimestamps() \|\|
110		is_null($this->model->getUpdatedAtColumn())) {
111		return $values;
112		}
113
114		$column = $this->model->getUpdatedAtColumn();
115
116		$values = array_merge(
117		[$column => $this->model->freshTimestampString()],
118		$values
119		);
120
121		$values[$this->qualifyColumn($column)] = $values[$column];
122		if ($column != $this->qualifyColumn($column)) {
123		unset($values[$column]);
124		}
125
126		return $values;
127		}
128
129
130		}
131

lroman242 / laravel-cassandra

Push — testing ( 0db53a...88fcdf )

Builder::addUpdatedAtColumn() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like