Model - Code Metrics - Inspection of "Merge pull request #1 from lroman242/testing" - lroman242/laravel-cassandra - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Retried Inspection

Push — testing ( 0ab4c3...b23bbe )

by Roman

created 2019-05-21 18:29 UTC

Model B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	286
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

52.83%

Importance

Changes

Metric	Value
wmc	52
lcom	1
cbo	7
dl	0
loc	286
ccs	56
cts	106
cp	0.5283
rs	7.44
c	0
b	0
f	0

15 Methods

Rating	Name	Size	Complexity
A	newEloquentBuilder()	4	1
A	newBaseQueryBuilder()	6	1
A	freshTimestamp()	4	1
A	fromDateTime()	14	3
A	asDateTime()	9	2
A	originalIsNumericallyEquivalent()	15	4
A	getQualifiedKeyName()	4	1
A	qualifyColumn()	4	1
B	setAttribute()	33	7
A	__call()	9	2
A	newCassandraCollection()	4	1
B	originalIsEquivalent()	26	9
B	isCassandraObject()	15	8
A	isCompareableCassandraObject()	10	3
B	valueFromCassandraObject()	30	8

How to fix Complexity

<?php

namespace lroman242\LaravelCassandra\Eloquent;

use Carbon\Carbon;
use Cassandra\Rows;
use Cassandra\Timestamp;
use lroman242\LaravelCassandra\Collection;
use lroman242\LaravelCassandra\Query\Builder as QueryBuilder;
use Illuminate\Database\Eloquent\Model as BaseModel;
use Illuminate\Support\Str;

abstract class Model extends BaseModel
{
    /**
     * Indicates if the IDs are auto-incrementing.
     * This is not possible in cassandra so we override this
     *
     * @var bool
     */
    public $incrementing = false;

    /**
     * @inheritdoc
     */
    public function newEloquentBuilder($query)
    {
        return new Builder($query);
    }

    /**
     * @inheritdoc
     */
    protected function newBaseQueryBuilder()
    {
        $connection = $this->getConnection();

        return new QueryBuilder($connection, null, $connection->getPostProcessor());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @inheritdoc
     */
    public function freshTimestamp()
    {
        return new Timestamp();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    public function fromDateTime($value)
    {
        // If the value is already a Timestamp instance, we don't need to parse it.
        if ($value instanceof Timestamp) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return $value;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        // Let Eloquent convert the value to a DateTime instance.
        if (!$value instanceof \DateTime) {
            $value = parent::asDateTime($value);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }

        return new Timestamp($value->getTimestamp() * 1000);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    protected function asDateTime($value)
    {
        // Convert UTCDateTime instances.
        if ($value instanceof Timestamp) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return Carbon::instance($value->toDateTime());
        }

        return parent::asDateTime($value);
    }

    /**
     * @inheritdoc
     */
    protected function originalIsNumericallyEquivalent($key)
    {
        $current = $this->attributes[$key];
        $original = $this->original[$key];

        // Date comparison.
        if (in_array($key, $this->getDates())) {
            $current = $current instanceof Timestamp ? $this->asDateTime($current) : $current;
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $original = $original instanceof Timestamp ? $this->asDateTime($original) : $original;
if ($x instanceof DoesNotExist) {
    // Do something.
}

            return $current == $original;
        }

        return parent::originalIsNumericallyEquivalent($key);
    }

    /**
     * Get the table qualified key name.
     * Cassandra does not support the table.column annotation so
     * we override this
     *
     * @return string
     */
    public function getQualifiedKeyName()
    {
        return $this->getKeyName();
    }

    /**
     * Qualify the given column name by the model's table.
     *
     * @param  string  $column
     * @return string
     */
    public function qualifyColumn($column)
    {
        return $column;
    }

     /**
     * Set a given attribute on the model.
     *
     * @param  string  $key
     * @param  mixed  $value
     * @return $this
     */
    public function setAttribute($key, $value)
    {
        // First we will check for the presence of a mutator for the set operation
        // which simply lets the developers tweak the attribute as it is set on
        // the model, such as "json_encoding" an listing of data for storage.
        if ($this->hasSetMutator($key)) {
            $method = 'set' . Str::studly($key) . 'Attribute';

            return $this->{$method}($value);
        }

        // If an attribute is listed as a "date", we'll convert it from a DateTime
        // instance into a form proper for storage on the database tables using
        // the connection grammar's date format. We will auto set the values.
        elseif ($value !== null && $this->isDateAttribute($key)) {
            $value = $this->fromDateTime($value);
        }

        if ($this->isJsonCastable($key) && !is_null($value)) {
            $value = $this->castAttributeAsJson($key, $value);
        }

        // If this attribute contains a JSON ->, we'll set the proper value in the
        // attribute's underlying array. This takes care of properly nesting an
        // attribute in the array's value in the case of deeply nested items.
        if (Str::contains($key, '->')) {
            return $this->fillJsonAttribute($key, $value);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $this->attributes[$key] = $value;

        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
    
    /**
     * @inheritdoc
     */
    public function __call($method, $parameters)
    {
        // Unset method
        if ($method == 'unset') {
            return call_user_func_array([$this, 'drop'], $parameters);
        }

        return parent::__call($method, $parameters);
    }

    /**
     * Create a new Eloquent Collection instance.
     *
     * @param  Rows  $rows
     *
     * @return Collection
     */
    public function newCassandraCollection(Rows $rows)
    {
        return new Collection($rows, $this);
    }

    /**
     * Determine if the new and old values for a given key are equivalent.
     *
     * @param  string $key
     * @param  mixed $current
     * @return bool
     */
    public function originalIsEquivalent($key, $current)
    {
        if (!array_key_exists($key, $this->original)) {
            return false;
        }

        $original = $this->getOriginal($key);

        if ($current === $original) {
            return true;
        } elseif (is_null($current)) {
            return false;
        } elseif ($this->isDateAttribute($key)) {
            return $this->fromDateTime($current) ===
                $this->fromDateTime($original);
        } elseif ($this->hasCast($key)) {
            return $this->castAttribute($key, $current) ===
                $this->castAttribute($key, $original);
        } elseif ($this->isCassandraObject($current)) {
            return $this->valueFromCassandraObject($current) ===
                $this->valueFromCassandraObject($original);
        }

        return is_numeric($current) && is_numeric($original)
            && strcmp((string) $current, (string) $original) === 0;
    }

    /**
     * Check if object is instance of any cassandra object types
     *
     * @param $obj
     * @return bool
     */
    protected function isCassandraObject($obj)
    {
        if ($obj instanceof \Cassandra\Uuid ||
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $obj instanceof \Cassandra\Date ||
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $obj instanceof \Cassandra\Float ||
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $obj instanceof \Cassandra\Decimal ||
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $obj instanceof \Cassandra\Timestamp ||
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $obj instanceof \Cassandra\Inet ||
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $obj instanceof \Cassandra\Time
if ($x instanceof DoesNotExist) {
    // Do something.
}
        ) {
            return true;
        } else {
            return false;
        }
    }

    /**
     * Check if object is instance of any cassandra object types
     *
     * @param $obj
     * @return bool
     */
    protected function isCompareableCassandraObject($obj)
    {
        if ($obj instanceof \Cassandra\Uuid ||
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $obj instanceof \Cassandra\Inet
if ($x instanceof DoesNotExist) {
    // Do something.
}
        ) {
            return true;
        } else {
            return false;
        }
    }

    /**
     * Returns comparable value from cassandra object type
     *
     * @param $obj
     * @return mixed
     */
    protected function valueFromCassandraObject($obj)
    {
        $class = get_class($obj);
        $value = '';
        switch ($class) {
            case 'Cassandra\Date':
                $value = $obj->seconds();
                break;
            case 'Cassandra\Time':
                $value = $obj->__toString();
                break;
            case 'Cassandra\Timestamp':
                $value = $obj->time();
                break;
            case 'Cassandra\Float':
                $value = $obj->value();
                break;
            case 'Cassandra\Decimal':
                $value = $obj->value();
                break;
            case 'Cassandra\Inet':
                $value = $obj->address();
                break;
            case 'Cassandra\Uuid':
                $value = $obj->uuid();
                break;
        }

        return $value;
    }

}


Push — testing ( 0ab4c3...b23bbe )

Model B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

15 Methods

How to fix Complexity

Complex Class

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1		<?php
2
3		namespace lroman242\LaravelCassandra\Eloquent;
4
5		use Carbon\Carbon;
6		use Cassandra\Rows;
7		use Cassandra\Timestamp;
8		use lroman242\LaravelCassandra\Collection;
9		use lroman242\LaravelCassandra\Query\Builder as QueryBuilder;
10		use Illuminate\Database\Eloquent\Model as BaseModel;
11		use Illuminate\Support\Str;
12
13		abstract class Model extends BaseModel
14		{
15		/**
16		* Indicates if the IDs are auto-incrementing.
17		* This is not possible in cassandra so we override this
18		*
19		* @var bool
20		*/
21		public $incrementing = false;
22
23		/**
24		* @inheritdoc
25		*/
26	18	public function newEloquentBuilder($query)
27		{
28	18	return new Builder($query);
29		}
30
31		/**
32		* @inheritdoc
33		*/
34	18	protected function newBaseQueryBuilder()
35		{
36	18	$connection = $this->getConnection();
37
38	18	return new QueryBuilder($connection, null, $connection->getPostProcessor());
		0 ignored issues – show Compatibility introduced 2019-04-24 19:07 UTC by Report Bug Copy Issue Report `$connection` of type `object<Illuminate\Database\Connection>` is not a sub-type of `object<lroman242\LaravelCassandra\Connection>`. It seems like you assume a child class of the class `Illuminate\Database\Connection` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history... Documentation introduced 2019-04-24 19:07 UTC by Report Bug Copy Issue Report `$connection->getPostProcessor()` is of type `object<Illuminate\Databa...y\Processors\Processor>`, but the function expects a `null\|object<lroman242\La...sandra\Query\Processor>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39		}

lroman242 / laravel-cassandra

Push — testing ( 0ab4c3...b23bbe )

Model B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

15 Methods

How to fix Complexity

Complex Class

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like