Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | trait SoftManagedModelTrait |
||
9 | { |
||
10 | use ManagedModelTrait; |
||
11 | |||
12 | |||
13 | /** |
||
14 | * Retrieve a reference by name, ignoring soft-deleted entries. |
||
15 | * |
||
16 | * @param string $name Reference name. |
||
17 | * |
||
18 | * @return mixed Model instance if found, null otherwise. |
||
19 | * |
||
20 | * @throws RepositoryException If this model or the referenced model is not handled by a managed repository, or the referenced repository is not soft-deletion aware. |
||
21 | */ |
||
22 | 3 | View Code Duplication | public function getReferenceSoft($name) |
37 | } |
||
38 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.