LeadFile::validate() - Code Metrics - Inspection of "Merge pull request #10 from lptracker/hotfix/LPTBA..." - lptracker/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 959197...30aa65 )

unknown

created 2019-06-14 10:34 UTC

LeadFile::validate() A

↳ Parent: LeadFile

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace LPTracker\models;

use LPTracker\exceptions\LPTrackerSDKException;

class LeadFile extends Model
{
    /**
     * @var integer
     */
    protected $id;

    /**
     * @var string
     */
    protected $name;

    /**
     * @var string
     */
    protected $ext;

    /**
     * @var string
     */
    protected $data;

    public function __construct(array $fileData = [])
    {
        if (!empty($fileData['id'])) {
            $this->id = (int) $fileData['id'];
        }
        if (!empty($fileData['name'])) {
            $this->name = $fileData['name'];
        }
        if (!empty($fileData['ext'])) {
            $this->ext = $fileData['ext'];
        }
        if (!empty($fileData['data'])) {
            $this->data = $fileData['data'];
        }
    }

    /**
     * @return array
     */
    public function toArray()
    {
        $result = [];
        if (!empty($this->id)) {
            $result['id'] = $this->getId();
        }
        if (!empty($this->name)) {
            $result['name'] = $this->getName();
        }
        if (!empty($this->ext)) {
            $result['ext'] = $this->getExt();
        }
        if (!empty($this->data)) {
            $result['data'] = $this->getData();
        }
        return $result;
    }

    /**
     * @return int
     */
    public function getId()
    {
        return (int) $this->id;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @return string
     */
    public function getExt()
    {
        return $this->ext;
    }

    /**
     * @return string
     */
    public function getData()
    {
        return $this->data;
    }

    /**
     * @param string $path (Full path to file with name and ext)
     *
     * @return void
     */
    public function saveFile($path)
    {
        try{
            $content = $this->getData();
            if(!empty($content)){
                @file_put_contents($path, base64_decode($content));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
        }catch(\Exception $e){}

    }

    public function validate(){
        return true;
    }
}


1			<?php
2
3			namespace LPTracker\models;
4
5			use LPTracker\exceptions\LPTrackerSDKException;
6
7			class LeadFile extends Model
8			{
9			/**
10			* @var integer
11			*/
12			protected $id;
13
14			/**
15			* @var string
16			*/
17			protected $name;
18
19			/**
20			* @var string
21			*/
22			protected $ext;
23
24			/**
25			* @var string
26			*/
27			protected $data;
28
29			public function __construct(array $fileData = [])
30			{
31			if (!empty($fileData['id'])) {
32			$this->id = (int) $fileData['id'];
33			}
34			if (!empty($fileData['name'])) {
35			$this->name = $fileData['name'];
36			}
37			if (!empty($fileData['ext'])) {
38			$this->ext = $fileData['ext'];
39			}
40			if (!empty($fileData['data'])) {
41			$this->data = $fileData['data'];
42			}
43			}
44
45			/**
46			* @return array
47			*/
48			public function toArray()
49			{
50			$result = [];
51			if (!empty($this->id)) {
52			$result['id'] = $this->getId();
53			}
54			if (!empty($this->name)) {
55			$result['name'] = $this->getName();
56			}
57			if (!empty($this->ext)) {
58			$result['ext'] = $this->getExt();
59			}
60			if (!empty($this->data)) {
61			$result['data'] = $this->getData();
62			}
63			return $result;
64			}
65
66			/**
67			* @return int
68			*/
69			public function getId()
70			{
71			return (int) $this->id;
72			}
73
74			/**
75			* @return string
76			*/
77			public function getName()
78			{
79			return $this->name;
80			}
81
82			/**
83			* @return string
84			*/
85			public function getExt()
86			{
87			return $this->ext;
88			}
89
90			/**
91			* @return string
92			*/
93			public function getData()
94			{
95			return $this->data;
96			}
97
98			/**
99			* @param string $path (Full path to file with name and ext)
100			*
101			* @return void
102			*/
103			public function saveFile($path)
104			{
105			try{
106			$content = $this->getData();
107			if(!empty($content)){
108			@file_put_contents($path, base64_decode($content));
			0 ignored issues – show Security Best Practice introduced 2019-06-14 10:35 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
109			}
110			}catch(\Exception $e){}
			0 ignored issues – show Coding Style Comprehensibility introduced 2019-06-14 10:35 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
111			}
112
113			public function validate(){
114			return true;
115			}
116			}
117

lptracker / php-sdk

GitHub Access Token became invalid

Push — master ( 959197...30aa65 )

LeadFile::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like