Comment::getOwnerId() - Code Metrics - lptracker/php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Comment::getOwnerId() A
last analyzed 2020-06-25 12:00 UTC

↳ Parent: Comment

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace LPTracker\models;

use LPTracker\exceptions\LPTrackerSDKException;

class Comment extends Model
{
    /**
     * @var integer
     */
    protected $id;

    /**
     * @var string
     */
    protected $text;

    /**
     * @var integer
     */
    protected $ownerId;

    /**
     * @var \DateTime
     */
    protected $createdAt;

    public function __construct(array $commentData = [])
    {
        if (!empty($commentData['id'])) {
            $this->id = (int) $commentData['id'];
        }
        if (!empty($commentData['text'])) {
            $this->text = $commentData['text'];
        }
        if (!empty($commentData['author'])) {
            if ($commentData['author']['type'] === 'main') {
                $this->ownerId = 0;
            } else {
                $this->ownerId = (int) $commentData['author']['id'];
            }
        }
        if (!empty($commentData['created_at'])) {
            $this->setCreatedAt($commentData['created_at']);
        }
    }

    /**
     * @return array
     */
    public function toArray()
    {
        return [
            'id' => $this->getId(),
            'text' => $this->getText(),
            'owner' => $this->getOwnerId(),
            'created_at' => $this->getCreatedAt()->format('d.m.Y H:i:s'),
        ];
    }

    /**
     * @return bool
     * @throws LPTrackerSDKException
     */
    public function validate()
    {
        if (empty($this->text)) {
            throw new LPTrackerSDKException('Text is required');
        }

        return true;
    }

    /**
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return string
     */
    public function getText()
    {
        return $this->text;
    }

    /**
     * @param string $text
     * @return $this
     */
    public function setText($text)
    {
        $this->text = $text;
        return $this;
    }

    /**
     * @return int
     */
    public function getOwnerId()
    {
        return $this->ownerId;
    }

    /**
     * @return \DateTime
     */
    public function getCreatedAt()
    {
        return $this->createdAt;
    }

    /**
     * @param \DateTime|string $createdAt
     * @return $this
     */
    public function setCreatedAt($createdAt)
    {
        if (!$createdAt instanceof \DateTime) {
            $createdAt = \DateTime::createFromFormat('d.m.Y H:i:s', $createdAt);
        }
        $this->createdAt = $createdAt;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        return $this;
    }
}


1			<?php
2
3			namespace LPTracker\models;
4
5			use LPTracker\exceptions\LPTrackerSDKException;
6
7			class Comment extends Model
8			{
9			/**
10			* @var integer
11			*/
12			protected $id;
13
14			/**
15			* @var string
16			*/
17			protected $text;
18
19			/**
20			* @var integer
21			*/
22			protected $ownerId;
23
24			/**
25			* @var \DateTime
26			*/
27			protected $createdAt;
28
29			public function __construct(array $commentData = [])
30			{
31			if (!empty($commentData['id'])) {
32			$this->id = (int) $commentData['id'];
33			}
34			if (!empty($commentData['text'])) {
35			$this->text = $commentData['text'];
36			}
37			if (!empty($commentData['author'])) {
38			if ($commentData['author']['type'] === 'main') {
39			$this->ownerId = 0;
40			} else {
41			$this->ownerId = (int) $commentData['author']['id'];
42			}
43			}
44			if (!empty($commentData['created_at'])) {
45			$this->setCreatedAt($commentData['created_at']);
46			}
47			}
48
49			/**
50			* @return array
51			*/
52			public function toArray()
53			{
54			return [
55			'id' => $this->getId(),
56			'text' => $this->getText(),
57			'owner' => $this->getOwnerId(),
58			'created_at' => $this->getCreatedAt()->format('d.m.Y H:i:s'),
59			];
60			}
61
62			/**
63			* @return bool
64			* @throws LPTrackerSDKException
65			*/
66			public function validate()
67			{
68			if (empty($this->text)) {
69			throw new LPTrackerSDKException('Text is required');
70			}
71
72			return true;
73			}
74
75			/**
76			* @return int
77			*/
78			public function getId()
79			{
80			return $this->id;
81			}
82
83			/**
84			* @return string
85			*/
86			public function getText()
87			{
88			return $this->text;
89			}
90
91			/**
92			* @param string $text
93			* @return $this
94			*/
95			public function setText($text)
96			{
97			$this->text = $text;
98			return $this;
99			}
100
101			/**
102			* @return int
103			*/
104			public function getOwnerId()
105			{
106			return $this->ownerId;
107			}
108
109			/**
110			* @return \DateTime
111			*/
112			public function getCreatedAt()
113			{
114			return $this->createdAt;
115			}
116
117			/**
118			* @param \DateTime\|string $createdAt
119			* @return $this
120			*/
121			public function setCreatedAt($createdAt)
122			{
123			if (!$createdAt instanceof \DateTime) {
124			$createdAt = \DateTime::createFromFormat('d.m.Y H:i:s', $createdAt);
125			}
126			$this->createdAt = $createdAt;
			0 ignored issues – show Documentation Bug introduced 2018-07-26 12:55 UTC by Report Bug Copy Issue Report It seems like `$createdAt` can also be of type `false`. However, the property `$createdAt` is declared as type `object<DateTime>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
127			return $this;
128			}
129			}
130

lptracker / php-sdk

GitHub Access Token became invalid

Comment::getOwnerId() A last analyzed 2020-06-25 12:00 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Comment::getOwnerId() A
last analyzed 2020-06-25 12:00 UTC