Completed
Branch breakout (dc8038)
by Paul
03:49
created
Category
src/Request/SIP2Request.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
             //$this->logger->debug("SIP2: Skipping optional field {$field}");
79 79
         } else {
80 80
             $this->noFixed = true; /* no more fixed for this message */
81
-            $this->msgBuild .= $field . substr($value, 0, 255) . $this->fldTerminator;
81
+            $this->msgBuild .= $field.substr($value, 0, 255).$this->fldTerminator;
82 82
         }
83 83
         return true;
84 84
     }
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     {
88 88
         /* Finalizes the message and returns it.  Message will remain in msgBuild until newMessage is called */
89 89
         if ($withSeq) {
90
-            $this->msgBuild .= 'AY' . self::getSeqNumber();
90
+            $this->msgBuild .= 'AY'.self::getSeqNumber();
91 91
         }
92 92
         if ($withCrc) {
93 93
             $this->msgBuild .= 'AZ';
Please login to merge, or discard this patch.
src/SIP2Client.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
             }
168 168
             //@codeCoverageIgnoreEnd
169 169
 
170
-            $result = $result . $terminator;
170
+            $result = $result.$terminator;
171 171
         }
172 172
 
173 173
         $this->logger->info("SIP2: result={$result}");
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
                 $this->logger->warning("SIP2: Message failed CRC check, retry {$depth})");
183 183
                 $result = $this->getRawResponse($request, $depth);
184 184
             } else {
185
-                $errMsg="SIP2: Failed to get valid CRC after {$this->maxretry} retries.";
185
+                $errMsg = "SIP2: Failed to get valid CRC after {$this->maxretry} retries.";
186 186
                 $this->logger->critical($errMsg);
187 187
                 throw new RuntimeException($errMsg);
188 188
             }
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
         } catch (\Exception $e) {
218 218
             $this->socket->close();
219 219
             $this->socket = null;
220
-            $this->logger->error("SIP2Client: Failed to connect: " . $e->getMessage());
220
+            $this->logger->error("SIP2Client: Failed to connect: ".$e->getMessage());
221 221
             throw new RuntimeException("Connection failure", 0, $e);
222 222
         }
223 223
 
Please login to merge, or discard this patch.
src/Response/PatronStatusResponse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     ];
30 30
 
31 31
     //variable part of the response allowed to contain these...
32
-    protected $allowedVariables=[
32
+    protected $allowedVariables = [
33 33
         self::AO_INSTITUTION_ID,
34 34
         self::AA_PATRON_IDENTIFIER,
35 35
         self::AE_PERSONAL_NAME,
Please login to merge, or discard this patch.
src/Response/FeePaidResponse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
     ];
24 24
 
25 25
     //variable part of the response allowed to contain these...
26
-    protected $allowedVariables=[
26
+    protected $allowedVariables = [
27 27
         self::AO_INSTITUTION_ID,
28 28
         self::AA_PATRON_IDENTIFIER,
29 29
         self::BK_TRANSACTION_ID,
Please login to merge, or discard this patch.
src/Response/PatronInformationResponse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
     ];
54 54
 
55 55
     //variable part of the response allowed to contain these...
56
-    protected $allowedVariables=[
56
+    protected $allowedVariables = [
57 57
         self::AO_INSTITUTION_ID,
58 58
         self::AA_PATRON_IDENTIFIER,
59 59
         self::AE_PERSONAL_NAME,
Please login to merge, or discard this patch.
src/Response/HoldResponse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     ];
30 30
 
31 31
     //variable part of the response allowed to contain these...
32
-    protected $allowedVariables=[
32
+    protected $allowedVariables = [
33 33
         self::BW_EXPIRATION_DATE,
34 34
         self::BR_QUEUE_POSITION,
35 35
         self::BS_PICKUP_LOCATION,
Please login to merge, or discard this patch.
src/Response/CheckOutResponse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     ];
39 39
 
40 40
     //variable part of the response allowed to contain these...
41
-    protected $allowedVariables=[
41
+    protected $allowedVariables = [
42 42
         self::AO_INSTITUTION_ID,
43 43
         self::AA_PATRON_IDENTIFIER,
44 44
         self::AB_ITEM_IDENTIFIER,
Please login to merge, or discard this patch.
src/Response/RenewAllResponse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
     ];
28 28
 
29 29
     //variable part of the response allowed to contain these...
30
-    protected $allowedVariables=[
30
+    protected $allowedVariables = [
31 31
         self::AO_INSTITUTION_ID,
32 32
         self::BM_RENEWED_ITEMS,
33 33
         self::BN_UNRENEWED_ITEMS,
Please login to merge, or discard this patch.
src/Response/RenewResponse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     ];
39 39
 
40 40
     //variable part of the response allowed to contain these...
41
-    protected $allowedVariables=[
41
+    protected $allowedVariables = [
42 42
         self::AO_INSTITUTION_ID,
43 43
         self::AA_PATRON_IDENTIFIER,
44 44
         self::AB_ITEM_IDENTIFIER,
Please login to merge, or discard this patch.