lordelph / php-sip2

src/Response/ItemInformationResponse.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
     ];
 
     //variable part of the response allowed to contain these...
-    protected $allowedVariables=[
+    protected $allowedVariables = [
         self::CF_HOLD_QUEUE_LENGTH,
         self::AH_DUE_DATE,
         self::CJ_RECALL_DATE,

src/Response/PatronEnableResponse.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     ];
 
     //variable part of the response allowed to contain these...
-    protected $allowedVariables=[
+    protected $allowedVariables = [
         self::AO_INSTITUTION_ID,
         self::AA_PATRON_IDENTIFIER,
         self::AE_PERSONAL_NAME,

src/Response/PatronInformationResponse.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     ];
 
     //variable part of the response allowed to contain these...
-    protected $allowedVariables=[
+    protected $allowedVariables = [
         self::AO_INSTITUTION_ID,
         self::AA_PATRON_IDENTIFIER,
         self::AE_PERSONAL_NAME,

src/Response/RenewResponse.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     ];
 
     //variable part of the response allowed to contain these...
-    protected $allowedVariables=[
+    protected $allowedVariables = [
         self::AO_INSTITUTION_ID,
         self::AA_PATRON_IDENTIFIER,
         self::AB_ITEM_IDENTIFIER,

src/SIP2Message.php

Spacing +5 added lines, -5 removed lines

@@ -19,7 +19,7 @@ 
      * @var array provides a list of the variables this message can use. Array key is the variable name in
      * StudlyCaps, value is an array which can contain type, default values
      */
-    protected $var=[];
+    protected $var = [];
 
     /** @var integer|null current timestamp, useful for testing */
     protected $timestamp = null;
@@ -96,7 +96,7 @@ 
      */
     public function getAll()
     {
-        $result=[];
+        $result = [];
         foreach ($this->var as $name => $data) {
             $result[$name] = $this->getVariable($name);
         }
@@ -188,19 +188,19 @@ 
     protected function ensureVariableExists($name)
     {
         if (!isset($this->var[$name])) {
-            throw new LogicException(get_class($this) . ' has no ' . $name . ' member');
+            throw new LogicException(get_class($this).' has no '.$name.' member');
         }
     }
 
     protected function handleMissing($varName)
     {
-        throw new LogicException(get_class($this) . '::set' . $varName . ' must be called');
+        throw new LogicException(get_class($this).'::set'.$varName.' must be called');
     }
 
     public function __call($name, $arguments)
     {
         if (!preg_match('/^(get|set)(.+)$/', $name, $match)) {
-            throw new LogicException(get_class($this) . ' has no ' . $name . ' method');
+            throw new LogicException(get_class($this).' has no '.$name.' method');
         }
         $varName = $match[2];
 

src/Request/FeePaidRequest.php

Spacing +2 added lines, -2 removed lines

@@ -57,8 +57,8 @@
     {
         $this->newMessage('37');
         $this->addFixedOption($this->datestamp(), 18);
-        $this->addFixedOption(sprintf('%02d', (string)$this->getVariable('FeeType')), 2);
-        $this->addFixedOption(sprintf('%02d', (string)$this->getVariable('PaymentType')), 2);
+        $this->addFixedOption(sprintf('%02d', (string) $this->getVariable('FeeType')), 2);
+        $this->addFixedOption(sprintf('%02d', (string) $this->getVariable('PaymentType')), 2);
         $this->addFixedOption($this->getVariable('CurrencyType'), 3);
 
         // due to currency format localization, it is up to the programmer

src/Request/SCStatusRequest.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
         $this->newMessage('99');
         $this->addFixedOption($this->getVariable('Status'), 1);
         $this->addFixedOption($this->getVariable('Width'), 3);
-        $this->addFixedOption(sprintf("%03.2f", (float)$this->getVariable('Version')), 4);
+        $this->addFixedOption(sprintf("%03.2f", (float) $this->getVariable('Version')), 4);
 
         return $this->returnMessage($withSeq, $withCrc);
     }

src/SIP2Client.php

Spacing +5 added lines, -5 removed lines

@@ -40,7 +40,7 @@ 
     /**
      * @var array name=>value request defaults used for every request
      */
-    private $default=[];
+    private $default = [];
 
     //-----------------------------------------------------
     // connection handling
@@ -132,11 +132,11 @@ 
             }
             //@codeCoverageIgnoreEnd
 
-            $result = $result . $terminator;
+            $result = $result.$terminator;
         }
         //if the remote end uses CRLF as a terminator, we might have a stray LF in our buffer - by trimming
         //the responses, we ensure those don't upset us
-        $result=trim($result);
+        $result = trim($result);
 
         $this->logger->info("SIP2: result={$result}");
 
@@ -150,7 +150,7 @@ 
                 $this->logger->warning("SIP2: Message failed CRC check, retry {$depth})");
                 $result = $this->getRawResponse($request, $depth);
             } else {
-                $errMsg="SIP2: Failed to get valid CRC after {$this->maxretry} retries.";
+                $errMsg = "SIP2: Failed to get valid CRC after {$this->maxretry} retries.";
                 $this->logger->critical($errMsg);
                 throw new RuntimeException($errMsg);
             }
@@ -177,7 +177,7 @@ 
             $this->socket = $this->createClient($address, $bind, $timeout);
         } catch (\Exception $e) {
             $this->socket = null;
-            $this->logger->error("SIP2Client: Failed to connect: " . $e->getMessage());
+            $this->logger->error("SIP2Client: Failed to connect: ".$e->getMessage());
             throw new RuntimeException("Connection failure", 0, $e);
         }
 

src/Response/SIP2Response.php

Spacing +14 added lines, -14 removed lines

@@ -26,11 +26,11 @@ 
     const AG_PRINT_LINE = 'AG';
     const AH_DUE_DATE = 'AH';
     const AJ_TITLE_IDENTIFIER = 'AJ';
-    const AM_LIBRARY_NAME='AM';
-    const AN_TERMINAL_LOCATION='AN';
+    const AM_LIBRARY_NAME = 'AM';
+    const AN_TERMINAL_LOCATION = 'AN';
     const AO_INSTITUTION_ID = 'AO';
     const AP_CURRENT_LOCATION = 'AP';
-    const AQ_PERMANENT_LOCATION='AQ';
+    const AQ_PERMANENT_LOCATION = 'AQ';
     const AS_HOLD_ITEMS = 'AS';
     const AT_OVERDUE_ITEMS = 'AT';
     const AU_CHARGED_ITEMS = 'AU';
@@ -41,7 +41,7 @@ 
     const BF_HOME_PHONE_NUMBER = 'BF';
     const BG_OWNER = 'BG';
     const BH_CURRENCY_TYPE = 'BH';
-    const BK_TRANSACTION_ID= 'BK';
+    const BK_TRANSACTION_ID = 'BK';
     const BL_VALID_PATRON = 'BL';
     const BM_RENEWED_ITEMS = 'BM';
     const BN_UNRENEWED_ITEMS = 'BN';
@@ -51,18 +51,18 @@ 
     const BU_RECALL_ITEMS = 'BU';
     const BV_FEE_AMOUNT = 'BV';
     const BW_EXPIRATION_DATE = 'BW';
-    const BX_SUPPORTED_MESSAGES='BX';
+    const BX_SUPPORTED_MESSAGES = 'BX';
     const BZ_HOLD_ITEMS_LIMIT = 'BZ';
     const CA_OVERDUE_ITEMS_LIMIT = 'CA';
     const CB_CHARGED_ITEMS_LIMIT = 'CB';
     const CC_FEE_LIMIT = 'CC';
     const CD_UNAVAILABLE_HOLD_ITEMS = 'CD';
     const CF_HOLD_QUEUE_LENGTH = 'CF';
-    const CH_ITEM_PROPERTIES= 'CH';
+    const CH_ITEM_PROPERTIES = 'CH';
     const CI_SECURITY_INHIBIT = 'CI';
     const CJ_RECALL_DATE = 'CJ';
-    const CK_MEDIA_TYPE= 'CK';
-    const CL_SORT_BIN='CL';
+    const CK_MEDIA_TYPE = 'CK';
+    const CL_SORT_BIN = 'CL';
     const CM_HOLD_PICKUP_DATE = 'CM';
     const CQ_VALID_PATRON_PASSWORD = 'CQ';
 
@@ -139,7 +139,7 @@ 
     public static function parse($raw): SIP2Response
     {
         if (empty($raw) || !self::checkCRC($raw)) {
-            throw new LogicException("Empty string or bad CRC not expected here");//@codeCoverageIgnore
+            throw new LogicException("Empty string or bad CRC not expected here"); //@codeCoverageIgnore
         }
 
         $type = substr($raw, 0, 2);
@@ -159,8 +159,8 @@ 
             return true;
         }
         if (preg_match('/^(.*AZ)(.{4})$/', trim($raw), $match)) {
-            $plaintext=$match[1];
-            $checksum=$match[2];
+            $plaintext = $match[1];
+            $checksum = $match[2];
             return self::crc($plaintext) == $checksum;
         }
 
@@ -189,7 +189,7 @@ 
 
             //we ignore anything with no value
             $clean = trim($value, "\x00..\x1F");
-            if ($clean==='') {
+            if ($clean === '') {
                 continue;
             }
 
@@ -200,11 +200,11 @@ 
                 //we tolerate unexpected values and treat them as array types
                 //named after the code if we don't have a definition for it
                 if (!isset(self::$mapCodeToVarDef[$field])) {
-                    self::$mapCodeToVarDef[$field]=[
+                    self::$mapCodeToVarDef[$field] = [
                         'name' => $field,
                         'type' => 'array'
                     ];
-                    $name=$field;
+                    $name = $field;
                 } else {
                     $name = self::$mapCodeToVarDef[$field]['name'];
                 }